View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0032879 | Open CASCADE | OCCT:Visualization | public | 2022-03-17 20:01 | 2023-07-31 00:13 |
| Reporter | kgv | Assigned To | sshutina | ||
| Priority | normal | Severity | feature | ||
| Status | verified | Resolution | fixed | ||
| Product Version | 7.7.0 | ||||
| Target Version | Unscheduled | ||||
| Summary | 0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging | ||||
| Description | Currently, dragging is implemented in a way strongly bound to default mapping of Left mouse button assigned to view rotation. This assumption is unsafe - rotation gesture might be disabled (0032861) or mapped to another button (left mouse might be mapped to panning), in which case dragging doesn't work at all. It is desired defining a separate mapping to dragging gesture (bound to Left mouse button by default, but user might want to enable dragging using right mouse or with Ctrl modifier, for instance), in which case concurrency with other gestures (panning, zooming) should be handled in a similar way as it is done with rotation. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR32879 has been created by svetlana.shutina_170290. SHA-1: 6b4bce554a21626974665686dcdd1c87e071f975 Detailed log of new commits: Author: sshutina Date: Mon Jul 17 23:14:55 2023 +0100 0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging |
|
|
Branch CR32879 has been updated by svetlana.shutina_170290. SHA-1: b6c10fc792193498278ca86fa2a214f230a1d9f4 Detailed log of new commits: Author: sshutina Date: Tue Jul 18 10:11:13 2023 +0100 test fix |
|
|
Branch CR32879_1 has been created by svetlana.shutina_170290. SHA-1: feebf8c81a040cbea6ff5d89205c6708ffd0723e Detailed log of new commits: Author: sshutina Date: Mon Jul 17 23:14:55 2023 +0100 0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging |
|
|
Dear Rodrigo! Please review the brach CR32879_1. The testing is successful: http://jenkins-test-10.nnov.opencascade.com/view/CR32879-master-sshutina/view/ALL/. The failed tests aren't related to the task. |
|
|
Dear @sshutina Commit message has no any description. v3d / manipulator / drag_pan_zoom Has no new line at the end v3d / manipulator / drag_pan_zoom src/ViewerTest/ViewerTest_ViewerCommands.cxx Unused parameter should has no own name or should call on first line as (void)theVarName +//======================================================================= +//function : VMouseGesture +//purpose : +//======================================================================= +static int VMouseGesture (Draw_Interpretor& /*theDI*/, + Standard_Integer theArgsNb, + const char** theArgVec) Dummy space "(Standard_UInteger )" + Standard_UInteger aButton = (Standard_UInteger )Aspect_VKeyMouse_LeftButton; Rrobably different code style - dummy space berween function name and '(' There is just sample. It can be not fixed, just for infrom.
+ aGesture = aGestureMap.Find1 (aGestureStr);
+ aGestureMap.Bind ("none", AIS_MouseGesture_NONE);
@rodrlyra need to analyze new parameters on "src/AIS/AIS_ViewController.cxx" 'cause they look ucommented. At least I'm avaiting some comments there. |
|
|
Branch CR32879_1 has been updated by svetlana.shutina_170290. SHA-1: 2aebb2b42444d4935ab22a4cdcfc29bcfafe29f6 Detailed log of new commits: Author: sshutina Date: Tue Jul 18 15:53:01 2023 +0100 0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging Fixed problem of usage of objects dragging during zoom and pan Added new draw command to change gesture for muse buttons Added test |
|
|
Branch CR32879_2 has been created by svetlana.shutina_170290. SHA-1: 342132316488a6e7cf28fc1980b86e2a2cf9f970 Detailed log of new commits: Author: sshutina Date: Mon Jul 17 23:14:55 2023 +0100 0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging Fixed problem of usage of objects dragging during zoom and pan Added new draw command to change gesture for muse buttons Added test |
|
|
As discussed with Svetlana on Teams, I suggested to change the name of the new Draw method from `vmousegesture` to something like `vchangemousegesture`, for better clarity. This is optional change. Aside from that, there aren't any remarks and the fix can be merged. dear @bugmaster, please integrate: OCCT - CR32879_1 |
|
|
As noted by Vadim, the branch name was wrong. Sorry for the confusion. Checked branch CR32879_2 and it is all good. dear @bugmaster, please integrate: OCCT - CR32879_2 |
|
|
Combination - OCCT branch : IR-2023-07-28 Products branch : master was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Ubuntu2004-64: OCCT Total CPU difference: 18390.160000000218 / 17955.81000000025 [+2.42%] Products Total CPU difference: 12120.729999999998 / 11840.960000000014 [+2.36%] Windows-64-VC142: OCCT Total CPU difference: 19150.53125 / 18775.15625 [+2.00%] Products Total CPU difference: 13127.03125 / 12654.9375 [+3.73%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR32879 has been deleted by mnt. SHA-1: b6c10fc792193498278ca86fa2a214f230a1d9f4 |
|
|
Branch CR32879_1 has been deleted by mnt. SHA-1: 2aebb2b42444d4935ab22a4cdcfc29bcfafe29f6 |
|
|
Branch CR32879_2 has been deleted by mnt. SHA-1: 342132316488a6e7cf28fc1980b86e2a2cf9f970 |
|
occt: master feebf8c8 2023-07-17 22:14:55 Details Diff |
0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging |
Affected Issues 0032879 |
|
| mod - src/AIS/AIS_ViewController.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| add - tests/v3d/manipulator/drag_pan_zoom | Diff File | ||
|
occt: master 34213231 2023-07-17 22:14:55 Details Diff |
0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging Fixed problem of usage of objects dragging during zoom and pan Added new draw command to change gesture for muse buttons Added test |
Affected Issues 0032879 |
|
| mod - src/AIS/AIS_ViewController.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| add - tests/v3d/manipulator/drag_pan_zoom | Diff File | ||
|
occt: master 2aebb2b4 2023-07-18 14:53:01 Details Diff |
0032879: Visualization, AIS_ViewController - define separate gesture mappings for dragging Fixed problem of usage of objects dragging during zoom and pan Added new draw command to change gesture for muse buttons Added test |
Affected Issues 0032879 |
|
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-03-17 20:01 | kgv | New Issue | |
| 2022-03-17 20:01 | kgv | Assigned To | => kgv |
| 2022-03-17 20:02 | kgv | Relationship added | related to 0032861 |
| 2022-03-17 20:03 | kgv | Relationship added | child of 0030507 |
| 2022-08-17 11:55 | kgv | Target Version | 7.7.0 => 7.8.0 |
| 2022-10-19 15:50 |
|
Assigned To | kgv => vpozdyayev |
| 2023-07-18 01:15 | git | Note Added: 0113755 | |
| 2023-07-18 12:11 | git | Note Added: 0113756 | |
| 2023-07-18 12:46 | dpasukhi | Assigned To | vpozdyayev => svetlana.shutina_170290 |
| 2023-07-18 12:47 | dpasukhi | Status | new => assigned |
| 2023-07-18 12:47 | dpasukhi | Product Version | => 7.7.0 |
| 2023-07-18 12:47 | dpasukhi | Target Version | 7.8.0 => Unscheduled |
| 2023-07-18 12:50 | sshutina | Assigned To | svetlana.shutina_170290 => sshutina |
| 2023-07-18 16:32 | git | Note Added: 0113760 | |
| 2023-07-18 16:34 | sshutina | Note Added: 0113761 | |
| 2023-07-18 16:34 | sshutina | Assigned To | sshutina => rodrlyra |
| 2023-07-18 16:35 | sshutina | Status | assigned => resolved |
| 2023-07-18 17:19 | dpasukhi | Note Added: 0113762 | |
| 2023-07-18 17:53 | git | Note Added: 0113763 | |
| 2023-07-18 18:20 | git | Note Added: 0113764 | |
| 2023-07-18 19:02 | rodrlyra | Assigned To | rodrlyra => bugmaster |
| 2023-07-18 19:03 | rodrlyra | Status | resolved => reviewed |
| 2023-07-18 19:03 | rodrlyra | Note Added: 0113765 | |
| 2023-07-24 13:32 | sshutina | Changeset attached | => occt master 2aebb2b4 |
| 2023-07-24 13:32 | sshutina | Changeset attached | => occt master feebf8c8 |
| 2023-07-24 13:32 | sshutina | Assigned To | bugmaster => sshutina |
| 2023-07-24 13:32 | sshutina | Status | reviewed => verified |
| 2023-07-24 13:32 | sshutina | Resolution | open => fixed |
| 2023-07-24 13:54 | vglukhik | Status | verified => feedback |
| 2023-07-24 13:54 | vglukhik | Resolution | fixed => reopened |
| 2023-07-24 13:55 | vglukhik | Assigned To | sshutina => bugmaster |
| 2023-07-24 13:55 | vglukhik | Status | feedback => reviewed |
| 2023-07-24 14:24 | rodrlyra | Note Added: 0113781 | |
| 2023-07-31 00:11 | vglukhik | Note Added: 0113810 | |
| 2023-07-31 00:11 | sshutina | Changeset attached | => occt master 34213231 |
| 2023-07-31 00:11 | sshutina | Assigned To | bugmaster => sshutina |
| 2023-07-31 00:11 | sshutina | Status | reviewed => verified |
| 2023-07-31 00:11 | sshutina | Resolution | reopened => fixed |
| 2023-07-31 00:12 | git | Note Added: 0113811 | |
| 2023-07-31 00:13 | git | Note Added: 0113812 | |
| 2023-07-31 00:13 | git | Note Added: 0113813 |
