View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0032701 | Open CASCADE | OCCT:Modeling Algorithms | public | 2021-11-30 16:15 | 2023-03-19 19:03 |
Reporter | Assigned To | ||||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Target Version | 7.6.2 | Fixed in Version | 7.6.1 | ||
Summary | 0032701: Modeling Algorithms - 2d curve has bending near the degenerated edge of the face | ||||
Description | The problem here is the section curve between the face and fourth face of the tool is invalid – 2d curve has bending near the degenerated edge of the face. | ||||
Steps To Reproduce | Test case lowalgos intss bug32701 restore bug32701s.brep s restore bug32701t.brep t explode t f bopcurves s t_4 -2d Tolerance Reached=3.5368182442078826 1 curve(s) found. c_1 (c2d1_1, c2d2_1) | ||||
Tags | No tags attached. | ||||
Test case number | lowalgos/intss/bug32701 | ||||
|
Branch CR32701 has been created by ifv. SHA-1: ef6b6b2e12fac623e11b9052fe0c03ec84fe8e79 Detailed log of new commits: Author: ifv Date: Thu Dec 2 17:02:17 2021 +0300 0032701: Modeling Algorithms - 2d curve has bending near the degenerated edge of the face IntPatch_Intersection.cxx = adjusting max step |
|
Branch CR32701 has been updated by ifv. SHA-1: 17e04354487398ce8f4d3509185012bcdfe4389b Detailed log of new commits: Author: ifv Date: Thu Dec 2 19:55:06 2021 +0300 Correction 1 |
|
Branch CR32701 has been updated by ifv. SHA-1: c3f9bfdd1f8c4afdd2c768f5e70b545c3022cc6a Detailed log of new commits: Author: ifv Date: Thu Dec 2 22:40:56 2021 +0300 Correction 2 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 6960f864d71af427bb639a994d7842b5ecfcfabe |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 1077f6ec3279c1260a7ca9690be6e8a405a430fc |
|
Branch CR32701_3 has been created by ifv. SHA-1: 2ffa19a5b224b572b52adff334af5a479438b07c Detailed log of new commits: Author: ifv Date: Fri Dec 3 12:32:35 2021 +0300 Set parameter for approximation |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: f9aa752e01186a5014df50b24add3eb4862c4a3c |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 97d9cc6c221b91ca7b5b519550c12f48dcda60ef |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 87b9f53d42b0b06b591865f653ba7b15612efcc4 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: b56e610b26ecd0323d41491e41328cb301fc02ca |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 70a5602c68d77e75a4186863efcb050a4d30be41 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: efc0a769e8726e090d6cb924d6b7bd4adc193d5c |
|
Branch CR32701 has been updated by ifv. SHA-1: ca765a2389e26d6950528e481fd962fd14399de6 Detailed log of new commits: Author: ifv Date: Wed Dec 8 17:16:29 2021 +0300 Removing problem for t_3 |
|
Branch CR32701_BOP has been created by emv. SHA-1: ea7215e867042d150a3c3eef90f26ceed126541a Detailed log of new commits: Author: Eugeny Maltchikov Date: Fri Dec 10 12:35:38 2021 +0300 Move one of the intersection faces to the exact intersection of two of its edges to obtain intersection closer to the boundary. |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 40a0dbe55937b98c0d58d923aa7982381fd77944 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 4dfd0eb03082c8d3258ceb0d1afc82d84b288ddc |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: dde7e5ff83e72fcc8f5f9fb627b5852e754e85b2 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 8b0d700fd83da86b3d6ac92b0a1b689307420e7a |
|
Branch CR32701 has been updated by ifv. SHA-1: a0b57f98c8ef931ae8342e88217e74aaa76c3931 Detailed log of new commits: Author: ifv Date: Wed Dec 15 10:37:51 2021 +0300 Fix gap |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: c4dc3945f1353ef4af3cbf53fc577512be66a54d |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: f207a5ddaf9775f6c60282c4542c086723a70c57 |
|
Branch CR32701_BOP_1 has been created by andrey.kaftasev_159541. SHA-1: 244f8f8f19dd47394817a90f6501d0b795d577cd Detailed log of new commits: Author: akaftasev Date: Thu Dec 16 17:35:36 2021 +0300 Added condition for distance between projection points Author: ifv Date: Thu Dec 2 17:02:17 2021 +0300 0032701: Modeling Algorithms - 2d curve has bending near the degenerated edge of the face IntPatch_Intersection.cxx - adding methods for estimation of UV max step depending on used surfaces GeomInt_IntSS.cxx, IntTools_FaceFace.cxx - using methods for max step estimation Author: ifv Date: Fri Dec 3 12:32:35 2021 +0300 Set parameter for approximation Author: Eugeny Maltchikov Date: Fri Dec 10 12:35:38 2021 +0300 Move one of the intersection faces to the exact intersection of two of its edges to obtain intersection closer to the boundary. |
|
Branch CR32701_BOP_1 has been updated forcibly by andrey.kaftasev_159541. SHA-1: f9baa5cab5223088a2d0a3b887335cb4cbf08716 |
|
bug32701s.brep (7,020 bytes) bug32701t.brep (19,227 bytes) |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 6ffba1ac9c1f5a3c194cca48221f46031e291384 |
|
Branch CR32701_BOP_3 has been created by andrey.kaftasev_159541. SHA-1: 9ac3fed923b50462578a9dad3b205248c64067fc Detailed log of new commits: Author: akaftasev Date: Thu Dec 16 17:23:50 2021 +0300 Move one of the intersection faces to the exact intersection of two of its edges to obtain intersection closer to the boundary. Added condition for distance between projection points Author: ifv Date: Thu Dec 2 17:02:17 2021 +0300 0032701: Modeling Algorithms - 2d curve has bending near the degenerated edge of the face ApproxInt_Approx, ApproxInt_KnotTools, BRepApprox_Approx, GeomInt_IntSS, IntTools_FaceFace: Analysis of curvature is added for adjusting ParametrizationType IntPatch_Intersection.cxx - adding methods for estimation of UV max step depending on used surfaces GeomInt_IntSS.cxx, IntTools_FaceFace.cxx - using methods for max step estimation Approx_SameParameter.cxx - adding control against big values. |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: b08f94c7935f6c9857c8453a28ba95c5940e21fb |
|
Branch CR32701_BOP_3 has been updated forcibly by andrey.kaftasev_159541. SHA-1: 195d86b3d7ddeaf0f3c401f13c350dd381abd30e |
|
Branch CR32701 has been updated by ifv. SHA-1: 3d46f06b0442c0e63fd34cecc2474d4deac3124a Detailed log of new commits: Author: ifv Date: Mon Dec 20 14:26:06 2021 +0300 BO included |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: a415c1d8a43c901a9881b8782f1ef3da6732ba45 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 7929db46d2fe974d4ea29846106d7fadd8ce68d6 |
|
Branch CR32701_BOP_3 has been updated forcibly by andrey.kaftasev_159541. SHA-1: 7403759b83f6e899f5d2852eefc5cfc09d00a079 |
|
Branch CR32701_BOP_3 has been updated forcibly by andrey.kaftasev_159541. SHA-1: 82f9ddd31da2d4308958dd722e215fbf80c3c221 |
|
Branch CR32701 is ready for review Test results: CR32701-master-ifv Branches for integration: OCCT - CR32701 Products - CR32701 |
|
+ catch (const Standard_Failure) Please pass exception by reference - this copying will generate a compiler warning. |
|
Branch CR32701 has been updated forcibly by andrey.kaftasev_159541. SHA-1: d07a0d81f9a5f12014251802ed2e7bbcf66cc617 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 2bfa7040b7cfd535b7e9a73dfa2e7d0124a48a25 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: cd7fc8451f38fcdbe1d41ebe7511234c66ff9c06 |
|
Re-basing on current master and testing |
|
OCCT branch CR32701 and Products branch CR32701 are ready for review Test result: http://jenkins-test-08.nnov.opencascade.com/view/CR32701-master-ifv/view/COMPARE/ Branches for integration: OCCT - CR32701 Products - CR32701 |
|
Dear Igor, could you please add CUT operation in the new test case? There was a problem that the COMMON was produced OK, while CUT was totally wrong. |
|
In my opinion, result of cut seems to be valid: Draw[5]> bcut cct s t Draw[6]> don cct cct Draw[7]> fit Draw[8]> checkshape cct This shape seems to be valid cut.png (37,870 bytes) |
|
Sure it is OK now, but at some point with intermediate patches it wasn't. |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 4a25647bf9b81d48c80c99df07e079a6f7eb0953 |
|
src/ApproxInt/ApproxInt_KnotTools.hxxStandard_EXPORT static Approx_ParametrizationType RecParType(const Handle(IntPatch_WLine)& theWL, Please use more meaningful method name, like RecognizeParType. src/ApproxInt/ApproxInt_KnotTools.cxx static Standard_Real MaxParamRatio(const math_Vector thePars) Pass by reference instead of value. |
|
In BOPAlgo_PaveFiller_6.cxx, you move one of faces before intersection. In this case, theoretically the result intersection curve can deviate from the 'true' intersection on that shift value. So, I think it is needed to consider this shift when defining tolerance for the new intersection edge. |
|
Dear emv, please analyze msv's remark https://tracker.dev.opencascade.org/view.php?id=32701#c106337 |
|
src/BOPAlgo/BOPAlgo_PaveFiller_6.cxxStandard_Boolean bIsClosed1 = !BRep_Tool::IsClosed(aE1, aF1); Standard_Boolean bIsClosed2 = !BRep_Tool::IsClosed(aE2, aF2); I think the negation sign must be removed here. |
|
src/GeomInt/GeomInt_IntSS_1.cxxif (typs1 == GeomAbs_Plane) { anApprox = Standard_False; anApprox1 = Standard_True; } else if (typs2 == GeomAbs_Plane) { anApprox = Standard_False; anApprox1 = Standard_True; } I think it is a mistake here in the 'else' block. anApprox2 must be assigned. Am I right? |
|
> In BOPAlgo_PaveFiller_6.cxx, you move one of faces before intersection. In this case, theoretically the result intersection curve can deviate from the 'true' intersection on that shift value. So, I think it is needed to consider this shift when defining tolerance for the new intersection edge. I agree with this remark - the tolerance for the intersection curve in case of the shift should be set not less than the value of this shift. Andrey, could you please proceed with implementation of this remark? |
|
src/IntPatch/IntPatch_Intersection.hxx//! Cheks if surface theS1 has degenerated boundary (dS/du or dS/dv = 0) and Cheks -> Checks //! calculates minimal distance between corresponding singular points and surface theS2 End the sentence with the dot. //! If singular point exist method returns "true" and stores minimal distance in theDist exist -> exists method -> the method |
|
The same misprint as in the comment https://tracker.dev.opencascade.org/view.php?id=32701#c106341 exists in the file IntTools_FaceFace.cxx. |
|
Branch CR32701_BOP has been updated forcibly by andrey.kaftasev_159541. SHA-1: 7b17c6c0ba41111c62ab2cd430125e08faa5d449 |
|
Branch CR32701 has been updated forcibly by ifv. SHA-1: 44c532012e7bf612cfe794f3e43ab97c452b3d9b |
|
Branches OCCT - CR32701 Products - CR32701 are ready for review Test results: job CR32701-master-ifv |
|
For integration: OCCT - CR32701 Products - CR32701 |
|
Combination - OCCT branch : IR-2022-01-28 master SHA - 7109a4ae5843002ea7a35ed2b5aafba7ccef13d4 49e51745631c52b6c452c65adae4d6dfa21a1b1e Products branch : IR-2022-01-28 SHA - 1fcdecce4d5d9ed7b667fcd27ecafe7d444140a3 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 18541.880000000696 / 18411.29000000044 [+0.71%] Products Total CPU difference: 11695.81000000013 / 11647.290000000106 [+0.42%] Windows-64-VC14: OCCT Total CPU difference: 20349.546875 / 20285.25 [+0.32%] Products Total CPU difference: 13126.203125 / 13132.546875 [-0.05%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
Branch CR32701 has been deleted by mnt. SHA-1: 44c532012e7bf612cfe794f3e43ab97c452b3d9b |
|
Branch CR32701_3 has been deleted by mnt. SHA-1: 2ffa19a5b224b572b52adff334af5a479438b07c |
|
Branch CR32701_BOP has been deleted by mnt. SHA-1: 7b17c6c0ba41111c62ab2cd430125e08faa5d449 |
|
Branch CR32701_BOP_1 has been deleted by mnt. SHA-1: f9baa5cab5223088a2d0a3b887335cb4cbf08716 |
|
Branch CR32701_BOP_3 has been deleted by mnt. SHA-1: 82f9ddd31da2d4308958dd722e215fbf80c3c221 |
occt: master 9eee5ab7 2021-12-02 17:02:17
Committer: |
0032701: Modeling Algorithms - 2d curve has bending near the degenerated edge of the face ApproxInt_Approx, ApproxInt_KnotTools, BRepApprox_Approx, GeomInt_IntSS, IntTools_FaceFace: Analysis of curvature is added for adjusting ParametrizationType IntPatch_Intersection.cxx - adding methods for estimation of UV max step depending on used surfaces GeomInt_IntSS.cxx, IntTools_FaceFace.cxx - using methods for max step estimation Approx_SameParameter.cxx - adding control against big values. BOPAlgo_PaveFiller_6.cxx - adjusting position of faces before intersection |
Affected Issues 0032701 |
|
mod - src/Approx/Approx_SameParameter.cxx | Diff File | ||
mod - src/ApproxInt/ApproxInt_Approx.gxx | Diff File | ||
mod - src/ApproxInt/ApproxInt_KnotTools.cxx | Diff File | ||
mod - src/ApproxInt/ApproxInt_KnotTools.hxx | Diff File | ||
mod - src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx | Diff File | ||
mod - src/BRepApprox/BRepApprox_Approx.hxx | Diff File | ||
mod - src/GeomInt/GeomInt_IntSS.cxx | Diff File | ||
mod - src/GeomInt/GeomInt_IntSS.hxx | Diff File | ||
mod - src/GeomInt/GeomInt_IntSS_1.cxx | Diff File | ||
mod - src/GeomInt/GeomInt_WLApprox.hxx | Diff File | ||
mod - src/IntPatch/IntPatch_Intersection.cxx | Diff File | ||
mod - src/IntPatch/IntPatch_Intersection.hxx | Diff File | ||
mod - src/IntPatch/IntPatch_PrmPrmIntersection.cxx | Diff File | ||
mod - src/IntPatch/IntPatch_RstInt.cxx | Diff File | ||
mod - src/IntTools/IntTools_FaceFace.cxx | Diff File | ||
mod - src/IntWalk/IntWalk_PWalking.cxx | Diff File | ||
mod - tests/lowalgos/intss/bug24472 | Diff File | ||
mod - tests/lowalgos/intss/bug27190 | Diff File | ||
mod - tests/lowalgos/intss/bug27664_1 | Diff File | ||
mod - tests/lowalgos/intss/bug28764 | Diff File | ||
mod - tests/lowalgos/intss/bug29972_3 | Diff File | ||
add - tests/lowalgos/intss/bug32701 | Diff File | ||
occt-products: master 0d27f300 2021-12-08 10:57:36
Committer: |
0032701: Modeling Algorithms - 2d curve has bending near the degenerated edge of the face Correction of tests according to current behavior of intersection algorithm |
Affected Issues 0032701 |
|
mod - diff | Diff File | ||
mod - tests/parasolid/doc_3/B7 | Diff File | ||
mod - tests/parasolid/doc_3/E3 | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-11-30 16:15 |
|
New Issue | |
2021-11-30 16:15 |
|
Assigned To | => ifv |
2021-11-30 16:15 |
|
File Added: shape.brep | |
2021-11-30 16:16 |
|
File Added: tool.brep | |
2021-11-30 16:20 |
|
Steps to Reproduce Updated | |
2021-12-02 17:03 | git | Note Added: 0105614 | |
2021-12-02 19:55 | git | Note Added: 0105619 | |
2021-12-02 22:41 | git | Note Added: 0105623 | |
2021-12-03 11:27 | git | Note Added: 0105625 | |
2021-12-03 11:32 | git | Note Added: 0105626 | |
2021-12-03 12:33 | git | Note Added: 0105630 | |
2021-12-06 18:22 | git | Note Added: 0105705 | |
2021-12-07 12:07 | git | Note Added: 0105713 | |
2021-12-07 16:18 | git | Note Added: 0105726 | |
2021-12-07 21:12 | git | Note Added: 0105731 | |
2021-12-07 21:19 | git | Note Added: 0105732 | |
2021-12-08 11:06 | git | Note Added: 0105739 | |
2021-12-08 17:17 | git | Note Added: 0105749 | |
2021-12-08 17:31 |
|
Status | new => assigned |
2021-12-10 12:36 | git | Note Added: 0105779 | |
2021-12-10 15:14 | git | Note Added: 0105786 | |
2021-12-10 15:29 | git | Note Added: 0105788 | |
2021-12-10 15:36 | git | Note Added: 0105789 | |
2021-12-13 16:37 | git | Note Added: 0105960 | |
2021-12-15 10:38 | git | Note Added: 0105987 | |
2021-12-15 13:30 | git | Note Added: 0105991 | |
2021-12-15 15:55 | git | Note Added: 0105996 | |
2021-12-16 17:37 | git | Note Added: 0106023 | |
2021-12-16 19:39 | git | Note Added: 0106027 | |
2021-12-17 12:48 |
|
Note Added: 0106052 | |
2021-12-17 12:48 |
|
File Added: bug32701s.brep | |
2021-12-17 12:48 |
|
File Added: bug32701t.brep | |
2021-12-17 12:50 |
|
Steps to Reproduce Updated | |
2021-12-17 12:50 |
|
File Deleted: shape.brep | |
2021-12-17 12:51 |
|
File Deleted: tool.brep | |
2021-12-17 18:30 | git | Note Added: 0106053 | |
2021-12-17 20:02 | git | Note Added: 0106056 | |
2021-12-19 20:42 | git | Note Added: 0106106 | |
2021-12-20 10:02 | git | Note Added: 0106110 | |
2021-12-20 14:26 | git | Note Added: 0106112 | |
2021-12-21 15:24 | git | Note Added: 0106128 | |
2021-12-21 15:30 | git | Note Added: 0106129 | |
2021-12-22 13:51 | git | Note Added: 0106140 | |
2021-12-22 13:58 | git | Note Added: 0106141 | |
2021-12-22 14:23 |
|
Assigned To | ifv => msv |
2021-12-22 14:23 |
|
Status | assigned => resolved |
2021-12-22 14:23 |
|
Steps to Reproduce Updated | |
2021-12-22 14:26 |
|
Note Added: 0106142 | |
2021-12-22 14:26 |
|
Test case number | => lowalgos/intss/bug32701 |
2021-12-22 14:34 | kgv | Note Added: 0106143 | |
2021-12-22 19:05 | git | Note Added: 0106153 | |
2021-12-23 11:23 | git | Note Added: 0106163 | |
2022-01-12 17:06 | git | Note Added: 0106314 | |
2022-01-12 17:13 |
|
Assigned To | msv => ifv |
2022-01-12 17:13 |
|
Status | resolved => assigned |
2022-01-12 17:13 |
|
Note Added: 0106316 | |
2022-01-13 10:24 |
|
Assigned To | ifv => azv |
2022-01-13 10:24 |
|
Status | assigned => resolved |
2022-01-13 10:24 |
|
Note Added: 0106327 | |
2022-01-13 10:33 |
|
Note Added: 0106328 | |
2022-01-13 10:49 |
|
Note Added: 0106329 | |
2022-01-13 10:49 |
|
File Added: cut.png | |
2022-01-13 10:52 |
|
Note Added: 0106330 | |
2022-01-13 11:12 | git | Note Added: 0106332 | |
2022-01-13 15:11 |
|
Note Added: 0106336 | |
2022-01-13 16:40 |
|
Note Added: 0106337 | |
2022-01-13 16:47 |
|
Note Added: 0106338 | |
2022-01-13 17:01 |
|
Note Added: 0106340 | |
2022-01-13 17:04 |
|
Note Added: 0106341 | |
2022-01-13 17:07 |
|
Note Added: 0106342 | |
2022-01-13 17:59 |
|
Note Added: 0106347 | |
2022-01-13 18:00 |
|
Note Added: 0106348 | |
2022-01-13 18:32 |
|
Assigned To | azv => ifv |
2022-01-13 18:32 |
|
Status | resolved => assigned |
2022-01-14 11:41 | git | Note Added: 0106365 | |
2022-01-14 12:40 |
|
Time allocated | 14.1.2022: 11 h. => set |
2022-01-14 15:44 | akaftasev | Time allocated | 14.1.2022: 1 h. => set |
2022-01-17 12:22 | git | Note Added: 0106425 | |
2022-01-21 10:28 |
|
Time allocated | 17.1.2022: 6 h. => set |
2022-01-21 10:38 |
|
Assigned To | ifv => msv |
2022-01-21 10:38 |
|
Status | assigned => resolved |
2022-01-21 10:38 |
|
Note Added: 0106493 | |
2022-01-24 10:29 |
|
Assigned To | msv => bugmaster |
2022-01-24 10:29 |
|
Status | resolved => reviewed |
2022-01-24 10:29 |
|
Note Added: 0106550 | |
2022-01-29 12:19 |
|
Status | reviewed => tested |
2022-01-29 12:19 |
|
Note Added: 0106660 | |
2022-01-29 13:00 |
|
Changeset attached | => occt master 9eee5ab7 |
2022-01-29 13:00 |
|
Assigned To | bugmaster => ifv |
2022-01-29 13:00 |
|
Status | tested => verified |
2022-01-29 13:00 |
|
Resolution | open => fixed |
2022-01-29 13:00 |
|
Changeset attached | => occt-products master 0d27f300 |
2022-01-29 13:13 | git | Note Added: 0106666 | |
2022-01-29 13:13 | git | Note Added: 0106667 | |
2022-01-29 13:13 | git | Note Added: 0106668 | |
2022-01-29 13:13 | git | Note Added: 0106669 | |
2022-01-29 13:13 | git | Note Added: 0106670 | |
2022-04-26 12:35 |
|
Target Version | 7.7.0 => 7.6.2 |
2023-03-19 19:03 | vglukhik | Status | verified => closed |
2023-03-19 19:03 | vglukhik | Fixed in Version | => 7.6.1 |