View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0032547Open CASCADEOCCT:Visualizationpublic2021-08-30 17:022023-03-19 20:15
Reporterkgv Assigned Tomzernova  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Product Version7.6.0 
Target Version7.7.0Fixed in Version7.7.0 
Summary0032547: Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder
Description0032281 introduced Select3D_SensitiveCylinder for picking a solid cylinder.
However, in many cases it is desired picking a hollow cylinder and cylinder circular boundaries independently - in case of subshape decomposition or just in case of a hollow pipe definition (or maybe a pipe with addition thickness).
Steps To Reproduce
pload MODELING VISUALIZATION
pcylinder cyl 10 20
explode cyl F
vclear
vdisplay cyl_1 -dispmode 1
# KO - entities are not Select3D_SensitiveCylinder 

vclear
vdisplay cyl -dispmode 1
vselmode cyl FACES 1
# KO - entities are not Select3D_SensitiveCylinder
TagsNo tags attached.
Test case numbervselect/cone_cylinder/circle_sector, circle_wire, filled_circle, hollow_cone_cyl, transformed_circle

Relationships

child of 0032281 closedbugmaster Visualization - add Select3D_SensitiveCylinder 

Activities

git

2022-01-24 10:35

administrator   ~0106551

Branch CR32547 has been created by svetlana.shutina_170290.

SHA-1: 206ed35b77050aff2b1bafc8ab3f890a1d09ac85


Detailed log of new commits:

Author: sshutina
Date: Mon Jan 24 10:16:50 2022 +0300

    0032547: Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder
    
     - cylinder overlap divided into 2 steps : intersection with cylinder disks and intersection with hollow cylinder

git

2022-08-15 10:57

administrator   ~0110234

Branch CR32547_1 has been created by mzernova.

SHA-1: 192de9590e79a09dd8f284dae3c1bc4c9fadac6b


Detailed log of new commits:

Author: mzernova
Date: Mon Aug 15 10:46:06 2022 +0300

    # Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
    # Added appropriate methods for selecting sensitive circles.
    # Added parameter myIsHollow to Select3D_SensitiveCylinder class.
    # It allows you to search for intersections with cylinders without covers.
    # Added tests: vselect/circle
    
    # TODO:
    # Define circle segments as sensitive polygons.
    # Add more hollow cylinder intersection tests.
    # Solve the problem with the inverted cylindrical surface.
    # Check how the sensitive circle intersection algorithm works with various transformations.
    # Reorganize the SelectMgr::ComputeSensitivePrs method, move the circle drawing to a separate method.

git

2022-08-15 17:33

administrator   ~0110238

Branch CR32547_1 has been updated by mzernova.

SHA-1: 1acafac69a985bde0e561cb851203838bdc9ddf7


Detailed log of new commits:

Author: mzernova
Date: Mon Aug 15 17:33:06 2022 +0300

    # Added Select3D_SensitiveCircleSector class for sensitive arc and segments.
    # Added test: vselect/circle/transformed
    
    # TODO:
    # Add more hollow cylinder intersection tests.
    # Solve the problem with the inverted cylindrical surface.

git

2022-08-16 18:18

administrator   ~0110248

Branch CR32547_1 has been updated by mzernova.

SHA-1: dd39479dbaed46ab7905de41ee9aec1d240bf416


Detailed log of new commits:

Author: mzernova
Date: Tue Aug 16 18:18:20 2022 +0300

    # Fixed some bugs
    # Added test: vselect/cone_cylinder/hollow_cone_cyl
    
    # TODO:
    # Solve the problem with the inverted cylindrical surface.
    # Update v3d/manipulator tests

git

2022-08-18 15:30

administrator   ~0110296

Branch CR32547_1 has been updated by mzernova.

SHA-1: 1c33d22ce7e61238917ea9583e0de73881bf9905


Detailed log of new commits:

Author: mzernova
Date: Thu Aug 18 15:30:24 2022 +0300

    # Fixed the problem with the inverted cylindrical surface.

Author: mzernova
Date: Thu Aug 18 11:39:46 2022 +0300

    # fix tests

git

2022-08-18 17:13

administrator   ~0110301

Branch CR32547_2 has been created by mzernova.

SHA-1: 20657f3c61c42f3d8c8b8dc2b26374f98c59e7fe


Detailed log of new commits:

Author: mzernova
Date: Thu Aug 18 17:12:03 2022 +0300

    Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
    Added Select3D_SensitiveCircleSector class for sensitive arc and segments.
    
    Added appropriate methods for selecting sensitive circles.
    Added parameter myIsHollow to Select3D_SensitiveCylinder class.
    It allows you to search for intersections with cylinders without covers.
    
    Added tests: vselect/circle/circle_wire
                 vselect/circle/filled_circle
                 vselect/circle/transformed
                 vselect/cone_cylinder/hollow_cone_cyl

git

2022-08-18 17:54

administrator   ~0110305

Branch CR32547_2 has been updated forcibly by mzernova.

SHA-1: ce755aacc54e9d5b9440ed49f3ce5bf350dea217

mzernova

2022-08-19 01:04

developer   ~0110312

http://jenkins-test-occt.nnov.opencascade.com/view/CR32547-master-mzernova

mzernova

2022-08-19 01:20

developer   ~0110313

The patch CR32547 is ready to review

git

2022-08-19 17:53

administrator   ~0110328

Branch CR32547_2 has been updated forcibly by mzernova.

SHA-1: a820b8008744f7b03bc3b4396215aba66e309ae9

kgv

2022-08-22 13:09

developer   ~0110343

Please consider remarks.

git

2022-08-25 17:30

administrator   ~0110366

Branch CR32547_3 has been created by mzernova.

SHA-1: 573430866644c105cc014ea0e462fa5fad85a960


Detailed log of new commits:

Author: mzernova
Date: Thu Aug 18 17:12:03 2022 +0300

    0032547: Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder
    
    Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
    The sensitive circle sector is created using the Select3D_SensitivePoly class directly.
    
    Added appropriate methods for selecting sensitive circles.
    Added parameter myIsHollow to Select3D_SensitiveCylinder class.
    It allows you to search for intersections with cylinders without covers.
    
    The Draw vcircle command has been extended with UStart and UEnd parameters
    to create a sector of a circle.
    
    Added tests: vselect/cone_cylinder/circle_sector
                 vselect/cone_cylinder/circle_wire
                 vselect/cone_cylinder/filled_circle
                 vselect/cone_cylinder/transformed
                 vselect/cone_cylinder/hollow_cone_cyl

git

2022-08-25 17:30

administrator   ~0110367

Branch CR32547_2 has been updated forcibly by mzernova.

SHA-1: ee84cb7eb35129881f2c5f1bc4d8018b3387f343

git

2022-08-25 20:56

administrator   ~0110368

Branch CR32547_2 has been updated forcibly by mzernova.

SHA-1: 47087bb37e3e8174e8a8ac79f5a8d94d432e6ec9

git

2022-08-25 20:57

administrator   ~0110369

Branch CR32547_3 has been updated forcibly by mzernova.

SHA-1: 316224f4abe7342d39b29b078baadc5388d9217d

mzernova

2022-08-26 00:03

developer   ~0110371

The patch CR32547 is ready to review

kgv

2022-08-26 11:48

developer   ~0110377

Please raise the patch
- OCCT: branch CR32547_3.

smoskvin

2022-08-27 14:16

administrator   ~0110387

Combination -
OCCT branch : IR-2022-08-26
master SHA - changes and them, and you can discard any commits you make in this
acac44d571c379b974e609ab8376ab3fb38f992e
changes and them, and you can discard any commits you make in this
e0ceb716c70188b98130b1550914140d0502a6f9
Products branch : IR-2022-08-26 SHA - d69fdb0b90e80500fad94ec94a075185cd820071
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18740.360000000626 / 18736.06000000064 [+0.02%]
Products
Total CPU difference: 11987.570000000105 / 11972.270000000151 [+0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 20800.71875 / 20773.21875 [+0.13%]
Products
Total CPU difference: 13554.96875 / 13548.546875 [+0.05%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2022-08-28 10:59

administrator   ~0110390

Branch CR32547 has been deleted by mnt.

SHA-1: 206ed35b77050aff2b1bafc8ab3f890a1d09ac85

git

2022-08-28 10:59

administrator   ~0110391

Branch CR32547_1 has been deleted by mnt.

SHA-1: 1c33d22ce7e61238917ea9583e0de73881bf9905

git

2022-08-28 10:59

administrator   ~0110392

Branch CR32547_2 has been deleted by mnt.

SHA-1: 47087bb37e3e8174e8a8ac79f5a8d94d432e6ec9

git

2022-08-28 10:59

administrator   ~0110393

Branch CR32547_3 has been deleted by mnt.

SHA-1: 316224f4abe7342d39b29b078baadc5388d9217d

Related Changesets

occt: master 7aaed2ce

2022-08-18 17:12:03

mzernova


Committer: smoskvin Details Diff		 0032547: Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder

Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
The sensitive circle sector is created using the Select3D_SensitivePoly class directly.

Added appropriate methods for selecting sensitive circles.
Added parameter myIsHollow to Select3D_SensitiveCylinder class.
It allows you to search for intersections with cylinders without covers.

The Draw vcircle command has been extended with UStart and UEnd parameters
to create a sector of a circle.

Added tests: vselect/cone_cylinder/circle_sector
vselect/cone_cylinder/circle_wire
vselect/cone_cylinder/filled_circle
vselect/cone_cylinder/transformed
vselect/cone_cylinder/hollow_cone_cyl		 Affected Issues
0032547
mod - src/AIS/AIS_Circle.cxx Diff File
mod - src/AIS/AIS_Manipulator.cxx Diff File
mod - src/PrsDim/PrsDim_ConcentricRelation.cxx Diff File
mod - src/PrsDim/PrsDim_EqualDistanceRelation.cxx Diff File
mod - src/Select3D/Select3D_SensitiveCircle.cxx Diff File
mod - src/Select3D/Select3D_SensitiveCircle.hxx Diff File
mod - src/Select3D/Select3D_SensitiveCylinder.cxx Diff File
mod - src/Select3D/Select3D_SensitiveCylinder.hxx Diff File
mod - src/Select3D/Select3D_SensitivePoly.cxx Diff File
mod - src/Select3D/Select3D_SensitivePoly.hxx Diff File
mod - src/SelectBasics/SelectBasics_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr.cxx Diff File
mod - src/SelectMgr/SelectMgr_AxisIntersector.cxx Diff File
mod - src/SelectMgr/SelectMgr_AxisIntersector.hxx Diff File
mod - src/SelectMgr/SelectMgr_BaseIntersector.cxx Diff File
mod - src/SelectMgr/SelectMgr_BaseIntersector.hxx Diff File
mod - src/SelectMgr/SelectMgr_Frustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_Frustum.lxx Diff File
mod - src/SelectMgr/SelectMgr_RectangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_RectangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.cxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.hxx Diff File
mod - src/StdSelect/StdSelect_BRepSelectionTool.cxx Diff File
mod - src/StdSelect/StdSelect_BRepSelectionTool.hxx Diff File
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff File
mod - tests/v3d/manipulator/rotate Diff File
mod - tests/vselect/bugs/bug27477 Diff File
add - tests/vselect/cone_cylinder/circle_sector Diff File
add - tests/vselect/cone_cylinder/circle_wire Diff File
add - tests/vselect/cone_cylinder/filled_circle Diff File
add - tests/vselect/cone_cylinder/hollow_cone_cyl Diff File
add - tests/vselect/cone_cylinder/transformed_circle Diff File
mod - tests/vselect/cone_cylinder/trsf_cone Diff File
mod - tests/vselect/cone_cylinder/trsf_cyl Diff File

Issue History

Date Modified Username Field Change
2021-08-30 17:02 kgv New Issue
2021-08-30 17:02 kgv Assigned To => kgv
2021-08-30 17:02 kgv Relationship added child of 0032281
2021-08-30 17:05 kgv Steps to Reproduce Updated
2021-09-06 16:39 kgv Assigned To kgv => sshutina
2021-09-06 16:39 kgv Status new => assigned
2022-01-24 10:35 git Note Added: 0106551
2022-08-01 15:07 kgv Assigned To sshutina => mzernova
2022-08-15 10:57 git Note Added: 0110234
2022-08-15 17:33 git Note Added: 0110238
2022-08-16 18:18 git Note Added: 0110248
2022-08-18 15:30 git Note Added: 0110296
2022-08-18 17:13 git Note Added: 0110301
2022-08-18 17:54 git Note Added: 0110305
2022-08-19 01:04 mzernova Note Added: 0110312
2022-08-19 01:20 mzernova Assigned To mzernova => kgv
2022-08-19 01:20 mzernova Status assigned => resolved
2022-08-19 01:20 mzernova Note Added: 0110313
2022-08-19 17:53 git Note Added: 0110328
2022-08-22 13:09 kgv Assigned To kgv => mzernova
2022-08-22 13:09 kgv Status resolved => assigned
2022-08-22 13:09 kgv Note Added: 0110343
2022-08-25 17:30 git Note Added: 0110366
2022-08-25 17:30 git Note Added: 0110367
2022-08-25 20:56 git Note Added: 0110368
2022-08-25 20:57 git Note Added: 0110369
2022-08-26 00:03 mzernova Assigned To mzernova => kgv
2022-08-26 00:03 mzernova Status assigned => resolved
2022-08-26 00:03 mzernova Note Added: 0110371
2022-08-26 11:48 kgv Assigned To kgv => bugmaster
2022-08-26 11:48 kgv Status resolved => reviewed
2022-08-26 11:48 kgv Note Added: 0110377
2022-08-27 14:16 smoskvin Status reviewed => tested
2022-08-27 14:16 smoskvin Note Added: 0110387
2022-08-27 14:17 smoskvin Test case number => vselect/cone_cylinder/circle_sector, circle_wire, filled_circle, hollow_cone_cyl, transformed_circle
2022-08-28 10:55 smoskvin Changeset attached => occt master 7aaed2ce
2022-08-28 10:55 mzernova Assigned To bugmaster => mzernova
2022-08-28 10:55 mzernova Status tested => verified
2022-08-28 10:55 mzernova Resolution open => fixed
2022-08-28 10:59 git Note Added: 0110390
2022-08-28 10:59 git Note Added: 0110391
2022-08-28 10:59 git Note Added: 0110392
2022-08-28 10:59 git Note Added: 0110393
2023-03-19 20:15 vglukhik Status verified => closed
2023-03-19 20:15 vglukhik Fixed in Version => 7.7.0