View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0032508 | Open CASCADE | OCCT:Visualization | public | 2021-08-01 12:05 | 2021-08-07 13:38 |
| Reporter | kgv | Assigned To | kgv | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 7.5.1 | ||||
| Target Version | 7.6.0 | Fixed in Version | 7.6.0 | ||
| Summary | 0032508: Visualization - OpenGl_FrameBuffer::InitWrapper() should not fail on wrapping textured FBO | ||||
| Description | OpenGl_FrameBuffer::InitWrapper() currently allows wrapping only render-buffered FBO. But in context when this method is used for wrapping existing FBO (QOpenGLWidget or Gtk::GLArea) to be set as default render target to OpenGl_Context::SetDefaultFrameBuffer(), it doesn't really matter to wrap FBO attachments - wrapping FBO id is enough. | ||||
| Steps To Reproduce | N/A | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR32508 has been created by kgv. SHA-1: 286e9f13f3eb3d21e12cc352ff74aafb2e6a3c22 Detailed log of new commits: Author: kgv Date: Sun Aug 1 12:34:41 2021 +0300 0032508: Visualization - OpenGl_FrameBuffer::InitWrapper() should not fail on wrapping textured FBO OpenGl_FrameBuffer::InitWrapper() now reads viewport from GL_VIEWPORT and doesn't return error on GL_TEXTURE attachments. OpenGl_FrameBuffer::Release() assertion is now skipped for wrapped FBOs. |
|
|
Patch is ready for review - OCCT: branch CR32508. http://jenkins-test-12.nnov.opencascade.com/view/CR32508-master-KGV |
|
|
The patch was reviewed |
|
|
Combination - OCCT branch : IR-2021-08-06 master SHA - 27e64adb38a9a8e6370b5dbd38a9018313884a9c a87b7ddc8cb44606b91e3f37113847c3f5f50fdc Products branch : IR-2021-08-06 SHA - d93b03b621e54fe532eb3f2eba1a1613534cfc91 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 17370.66000000038 / 17380.800000000403 [-0.06%] Products Total CPU difference: 11454.410000000084 / 11476.060000000101 [-0.19%] Windows-64-VC14: OCCT Total CPU difference: 19180.84375 / 19196.421875 [-0.08%] Products Total CPU difference: 12822.75 / 12808.78125 [+0.11%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR32508 has been deleted by mnt. SHA-1: 286e9f13f3eb3d21e12cc352ff74aafb2e6a3c22 |
|
occt: master 286e9f13 2021-08-01 09:34:41 Details Diff |
0032508: Visualization - OpenGl_FrameBuffer::InitWrapper() should not fail on wrapping textured FBO OpenGl_FrameBuffer::InitWrapper() now reads viewport from GL_VIEWPORT and doesn't return error on GL_TEXTURE attachments. OpenGl_FrameBuffer::Release() assertion is now skipped for wrapped FBOs. |
Affected Issues 0032508 |
|
| mod - src/OpenGl/OpenGl_FrameBuffer.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-08-01 12:05 | kgv | New Issue | |
| 2021-08-01 12:05 | kgv | Assigned To | => kgv |
| 2021-08-01 12:34 | git | Note Added: 0102914 | |
| 2021-08-01 13:43 | kgv | Note Added: 0102915 | |
| 2021-08-01 13:43 | kgv | Assigned To | kgv => osa |
| 2021-08-01 13:43 | kgv | Status | new => resolved |
| 2021-08-02 17:02 |
|
Note Added: 0102930 | |
| 2021-08-02 17:02 |
|
Assigned To | osa => bugmaster |
| 2021-08-02 17:02 |
|
Status | resolved => reviewed |
| 2021-08-07 13:10 | bugmaster | Note Added: 0103052 | |
| 2021-08-07 13:10 | bugmaster | Status | reviewed => tested |
| 2021-08-07 13:12 | bugmaster | Test case number | => Not required |
| 2021-08-07 13:27 | kgv | Changeset attached | => occt master 286e9f13 |
| 2021-08-07 13:27 | kgv | Assigned To | bugmaster => kgv |
| 2021-08-07 13:27 | kgv | Status | tested => verified |
| 2021-08-07 13:27 | kgv | Resolution | open => fixed |
| 2021-08-07 13:38 | git | Note Added: 0103073 |
