View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0032487Open CASCADEOCCT:Visualizationpublic2021-07-20 06:162024-01-17 15:33
Reporternds Assigned Todrochalo 
PrioritynormalSeverityminor 
Status verifiedResolutionfixed 
Target VersionUnscheduled 
Summary0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
DescriptionOffer of 27919:
"Maybe replacing myHasEntityWithPersistence with a counter?"
Replace boolean value myHasEntityWithPersistence of SelectMgr_SensitiveEntitySet on integer. It should be incremented when new entity is added and decremented when it's removed.
Steps To Reproducev3d/dimensions/bug27919
TagsNo tags attached.
Test case number

Attached Files

  • image.png (43,195 bytes)

Relationships

child of 0027919 closedbugmaster Visualization - support multiple transformation persistence groups within single presentation 

Activities

git

2023-10-26 13:44

administrator   ~0114439

Branch CR32487 has been created by drochalo.

SHA-1: 94caf7a7c9dfb6046071b667aecd5b05f0bd6fa3


Detailed log of new commits:

Author: drochalo
Date: Thu Oct 26 11:43:19 2023 +0100

    0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
    
    Changed myHasEntityWithPersistence to a counter.
    Modified logical test in SelectMgr_ViewerSelector::traverseObject.

drochalo

2023-10-27 15:56

developer   ~0114443

Dear Marina, please review.
Tests on jenkins: http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/

mzernova

2023-10-27 17:41

developer   ~0114445

Last edited: 2023-10-27 17:44

 Standard_Integer HasEntityWithPersistence() const { return myHasEntityWithPersistence; }
Please change to
Standard_Boolean HasEntityWithPersistence() const { return myNbEntityWithPersistence > 0; }

Standard_Integer myHasEntityWithPersistence;
Please rename => myNbEntityWithPersistence

git

2023-10-27 18:20

administrator   ~0114446

Branch CR32487 has been updated by drochalo.

SHA-1: e3639ef43ff8e2a83b092783397d4801e1d936c2


Detailed log of new commits:

Author: drochalo
Date: Fri Oct 27 16:19:21 2023 +0100

    0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
    
    Renamed variable to myNbEntityWithPersistence.
    Modified HasEntityWithPersistence() method.

drochalo

2023-10-30 13:29

developer   ~0114451

Dear Marina,
the requested changes were made.
New tests were performed in Jenkins and apart from a test that fails but that does not appear to have a connection to the changes made, everything else looks fine.
Jenkins test: http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/

mzernova

2023-11-17 02:39

developer   ~0114606

Last edited: 2023-11-17 02:39

 Please remove extra brackets
  Standard_Boolean HasEntityWithPersistence() const { return (myNbEntityWithPersistence > 0); }

Please remove extra spaces.

git

2023-11-20 14:12

administrator   ~0114617

Branch CR32487 has been updated by drochalo.

SHA-1: 48f147fa0236563cdfe5e4800713dcd9b0f08d58


Detailed log of new commits:

Author: drochalo
Date: Mon Nov 20 11:11:09 2023 +0000

    0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
    
    Code cleanup.

Author: drochalo
Date: Mon Nov 20 10:48:22 2023 +0000

    Merge branch 'master' of git.dev.opencascade.org:occt into CR32487

git

2023-12-18 13:24

administrator   ~0114791

Branch CR32487 has been updated by drochalo.

SHA-1: 5240e81a78d791e7d48145ec37845a50feedbde6


Detailed log of new commits:

Author: drochalo
Date: Mon Dec 18 09:57:04 2023 +0000

    Merge branch 'master' of git.dev.opencascade.org:occt into CR32487

drochalo

2023-12-19 12:24

developer   ~0114817

Dear Marina,
please review.

New tests were done and failed tests are not connected to the changes made:
http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/

mzernova

2023-12-19 16:44

developer   ~0114819

Please remove extra spaces and lines
And use rebase instead merge to rebase you branch on current master
image.png (43,195 bytes)

git

2023-12-19 17:28

administrator   ~0114820

Branch CR32487 has been updated forcibly by drochalo.

SHA-1: f8845b88e518701be6fd083f603b5bc36a34b124

git

2023-12-19 17:59

administrator   ~0114821

Branch CR32487 has been updated forcibly by drochalo.

SHA-1: de104a47ef36ff11e986c2638f9cd630086f25e0

vglukhik

2024-01-05 01:52

administrator   ~0114857

Combination -
OCCT branch : IR-2023-12-22
master SHA - 5c9480638558bd1b4528669b1eb4859cadd9a257
d2ef868da4165400c82322bd7f11b652decce47a
Products branch : IR-2023-12-22 SHA - d905a754c332d70a065c12a268be47676ea2c6a9
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18633.43999999986 / 18269.079999999904 [+1.99%]
Products
Total CPU difference: 11763.979999999934 / 11554.499999999949 [+1.81%]
Windows-64-VC142:
OCCT
Total CPU difference: 20136.3125 / 20132.90625 [+0.02%]
Products
Total CPU difference: 13131.234375 / 12359.828125 [+6.24%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2024-01-05 20:00

administrator   ~0114870

Branch CR32487 has been deleted by vglukhik.

SHA-1: de104a47ef36ff11e986c2638f9cd630086f25e0

Related Changesets

occt: master de104a47

2023-10-26 10:43:19

drochalo

Details Diff		 0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number

Changed myHasEntityWithPersistence to a counter.
Renamed variable to myNbEntityWithPersistence.
Modified HasEntityWithPersistence() method.
Modified logical test in SelectMgr_ViewerSelector::traverseObject.		 Affected Issues
0032487
mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.cxx Diff File
mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.hxx Diff File

occt: master 5c948063

2023-10-26 10:43:19

drochalo


Committer: dpasukhi Details Diff		 0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number

Changed myHasEntityWithPersistence to a counter.
Renamed variable to myNbEntityWithPersistence.
Modified HasEntityWithPersistence() method.
Modified logical test in SelectMgr_ViewerSelector::traverseObject.		 Affected Issues
0032487
mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.cxx Diff File
mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.hxx Diff File

Issue History

Date Modified Username Field Change
2021-07-20 06:16 nds New Issue
2021-07-20 06:16 nds Assigned To => kgv
2021-07-22 23:32 kgv Relationship added child of 0027919
2021-08-24 14:19 kgv Target Version 7.6.0 => 7.7.0
2022-08-17 11:59 kgv Target Version 7.7.0 => 7.8.0
2022-10-19 15:49 smoskvin Assigned To kgv => vpozdyayev
2023-08-01 15:09 dpasukhi Target Version 7.8.0 => Unscheduled
2023-10-25 14:10 drochalo Assigned To vpozdyayev => drochalo
2023-10-26 13:44 git Note Added: 0114439
2023-10-27 15:56 drochalo Assigned To drochalo => mzernova
2023-10-27 15:56 drochalo Status new => feedback
2023-10-27 15:56 drochalo Note Added: 0114443
2023-10-27 16:56 drochalo Status feedback => resolved
2023-10-27 17:41 mzernova Note Added: 0114445
2023-10-27 17:42 mzernova Note Edited: 0114445
2023-10-27 17:44 mzernova Note Edited: 0114445
2023-10-27 17:44 mzernova Note Edited: 0114445
2023-10-27 17:45 mzernova Status resolved => assigned
2023-10-27 17:45 mzernova Assigned To mzernova => drochalo
2023-10-27 18:20 git Note Added: 0114446
2023-10-30 13:29 drochalo Assigned To drochalo => mzernova
2023-10-30 13:29 drochalo Status assigned => resolved
2023-10-30 13:29 drochalo Steps to Reproduce Updated
2023-10-30 13:29 drochalo Note Added: 0114451
2023-10-30 13:30 drochalo Steps to Reproduce Updated
2023-11-17 02:39 mzernova Note Added: 0114606
2023-11-17 02:39 mzernova Assigned To mzernova => drochalo
2023-11-17 02:39 mzernova Status resolved => assigned
2023-11-17 02:39 mzernova Note Edited: 0114606
2023-11-20 14:12 git Note Added: 0114617
2023-12-18 13:24 git Note Added: 0114791
2023-12-19 12:24 drochalo Note Added: 0114817
2023-12-19 12:24 drochalo Assigned To drochalo => mzernova
2023-12-19 12:24 drochalo Status assigned => resolved
2023-12-19 16:44 mzernova Note Added: 0114819
2023-12-19 16:44 mzernova File Added: image.png
2023-12-19 16:46 mzernova Assigned To mzernova => drochalo
2023-12-19 16:46 mzernova Status resolved => assigned
2023-12-19 17:28 git Note Added: 0114820
2023-12-19 17:41 drochalo Assigned To drochalo => mzernova
2023-12-19 17:41 drochalo Status assigned => resolved
2023-12-19 17:49 mzernova Assigned To mzernova => bugmaster
2023-12-19 17:49 mzernova Status resolved => reviewed
2023-12-19 17:59 git Note Added: 0114821
2024-01-05 01:52 vglukhik Note Added: 0114857
2024-01-05 01:54 drochalo Changeset attached => occt master de104a47
2024-01-05 01:54 drochalo Assigned To bugmaster => drochalo
2024-01-05 01:54 drochalo Status reviewed => verified
2024-01-05 01:54 drochalo Resolution open => fixed
2024-01-05 20:00 git Note Added: 0114870
2024-01-17 15:32 dpasukhi Changeset attached => occt master 5c948063