View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0032337 | Open CASCADE | OCCT:Visualization | public | 2021-04-28 09:50 | 2021-12-17 18:41 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.6.0 | Fixed in Version | 7.6.0 | ||
| Summary | 0032337: Visualization - rename Overlaps() method in selection to more self-describable names | ||||
| Description | Selection defines numerous overloaded methods called Overlaps() for point, AABB, triangle, segment. Although it is possible deducing the method purpose from the list of its arguments, this is not straight-forward and might be misleading in some cases. It is proposed renaming these methods to have primitive type in the name. Overlaps() might be preserved for compatibility redirecting to new ones. | ||||
| Steps To Reproduce | Not required | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
| related to | 0032182 | closed | bugmaster | Visualization - add Select3D_SensitiveSphere |
| related to | 0032338 | closed | bugmaster | Visualization - provide straightforward interface for ray-picking |
| parent of | 0032419 | closed | bugmaster | Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases |
|
|
Branch CR32337 has been created by mkrylova. SHA-1: 3dfc6de5cda3a60c079812fb435a2f7c322b044e Detailed log of new commits: Author: mkrylova Date: Wed May 12 16:39:17 2021 +0300 0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
|
|
Solution Implementation, Testing |
|
|
Please also handle > Overlaps() might be preserved for compatibility redirecting to new ones. Overlaps() methods should be preserved at high-level API (e.g. SelectMgr_SelectingVolumeManager class) as non-virtual deprecated methods redirected to new methods. Please also check compilation of samples, OCC Products and start Jenkins job. |
|
|
Branch CR32337 has been updated by mkrylova. SHA-1: 1ce11103fe71c08c1be588d4c2c8a5bb9ebe6b8e Detailed log of new commits: Author: mkrylova Date: Thu May 13 12:46:29 2021 +0300 # kgv remarks: - restored Overlaps() methods as non-virtual and deprecated |
|
|
Branch CR32337_1 has been created by mkrylova. SHA-1: 38a2e8afbe4065a0d9a1e4dd03681660307ce70a Detailed log of new commits: Author: mkrylova Date: Wed May 12 16:39:17 2021 +0300 0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
|
|
Solution implementation |
|
|
Please rebase patch on top of 0032365. |
|
|
Branch CR32337_1 has been updated forcibly by mkrylova. SHA-1: b5d5c0fe93add95d3e453264fcf390547edbf321 |
|
|
Branch CR32337_2 has been created by mkrylova. SHA-1: 307eac1b4d024c24d7828192848c7bf6d1e6ba73 Detailed log of new commits: Author: mkrylova Date: Wed May 12 16:39:17 2021 +0300 0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
|
|
Solution implementation |
|
|
Branch CR32337_2 has been updated forcibly by mkrylova. SHA-1: bcf63f44a35e233b27440530d8b0d8cc2fb6b9f7 |
|
|
Branch CR32337_3 has been created by mkrylova. SHA-1: e28b4bf90a34089ca1b89fa202172898ad123060 Detailed log of new commits: Author: mkrylova Date: Wed May 12 16:39:17 2021 +0300 0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
|
|
Branch CR32337_3 has been updated by mkrylova. SHA-1: 7089b47a7eae0bf5ded0193c330237aa420ee770 Detailed log of new commits: Author: mkrylova Date: Mon May 24 12:36:41 2021 +0300 # kgv remarks - moved deprecated methods to the end of file |
|
|
Branch CR32337_4 has been created by mkrylova. SHA-1: 0d13c23e07ed459a72cd6b710aa5cd9d9fb89d54 Detailed log of new commits: Author: mkrylova Date: Wed May 12 16:39:17 2021 +0300 0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
|
|
Solution implementation, Testing |
|
|
http://jenkins-test-occt/view/CR32337_4-CR32337_2-MKRYLOVA/view/ALL/ |
|
|
Please raise the patch - OCCT: branch CR32337_4; - OCC Products: branch CR32337_2. |
|
|
Combination - OCCT branch : IR-2021-05-28 master SHA - 2315a044240803013da63dd2f5209c739ab03727 a87b7ddc8cb44606b91e3f37113847c3f5f50fdc Products branch : IR-2021-05-28 SHA - 2131ac830b9e3c707d427f2aac9c50dcfa5c74db was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 17574.5700000004 / 17867.41000000037 [-1.64%] Products Total CPU difference: 11533.700000000124 / 11535.680000000108 [-0.02%] Windows-64-VC14: OCCT Total CPU difference: 19393.5625 / 19367.75 [+0.13%] Products Total CPU difference: 12891.8125 / 12920.9375 [-0.23%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR32337 has been deleted by mnt. SHA-1: 1ce11103fe71c08c1be588d4c2c8a5bb9ebe6b8e |
|
|
Branch CR32337_1 has been deleted by mnt. SHA-1: b5d5c0fe93add95d3e453264fcf390547edbf321 |
|
|
Branch CR32337_2 has been deleted by mnt. SHA-1: bcf63f44a35e233b27440530d8b0d8cc2fb6b9f7 |
|
|
Branch CR32337_3 has been deleted by mnt. SHA-1: 7089b47a7eae0bf5ded0193c330237aa420ee770 |
|
|
Branch CR32337_4 has been deleted by mnt. SHA-1: 0d13c23e07ed459a72cd6b710aa5cd9d9fb89d54 |
|
occt: master 03c9cc86 2021-05-12 13:39:17
Committer: bugmaster Details Diff |
0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
Affected Issues 0032337 |
|
| mod - src/MeshVS/MeshVS_CommonSensitiveEntity.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitivePolyhedron.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveQuad.cxx | Diff File | ||
| mod - src/Select3D/Select3D_InteriorSensitivePointSet.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveBox.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveCircle.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePoint.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePoly.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePrimitiveArray.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveSegment.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveSet.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveTriangle.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveTriangulation.cxx | Diff File | ||
| mod - src/SelectBasics/SelectBasics_SelectingVolumeManager.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_AxisIntersector.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_AxisIntersector.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_BaseFrustum.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_BaseFrustum.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_BaseIntersector.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_BaseIntersector.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_Frustum.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_Frustum.lxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_RectangularFrustum.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_RectangularFrustum.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_TriangularFrustum.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_TriangularFrustum.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_ViewerSelector.cxx | Diff File | ||
|
occt-products: master 606ded06 2021-05-21 11:42:32
Committer: bugmaster Details Diff |
0032337: Visualization - rename Overlaps() method in selection to more self-describable names - renamed Overlaps and hasOverlap overloaded methods to self-describable names |
Affected Issues 0032337 |
|
| mod - src/PrsPointCloud/PrsPointCloud_PointCloudSensitive.cxx | Diff File | ||
| mod - src/PrsPointCloud/PrsPointCloud_RasterRenderer.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-04-28 09:50 | kgv | New Issue | |
| 2021-04-28 09:50 | kgv | Assigned To | => mkrylova |
| 2021-04-28 09:50 | kgv | Relationship added | related to 0032182 |
| 2021-05-12 17:49 | git | Note Added: 0100918 | |
| 2021-05-12 17:50 |
|
Assigned To | mkrylova => kgv |
| 2021-05-12 17:50 |
|
Status | new => resolved |
| 2021-05-12 17:50 |
|
Steps to Reproduce Updated | |
| 2021-05-12 18:20 |
|
Note Added: 0100920 | |
| 2021-05-12 18:30 | kgv | Note Added: 0100922 | |
| 2021-05-12 18:31 | kgv | Assigned To | kgv => mkrylova |
| 2021-05-12 18:31 | kgv | Status | resolved => assigned |
| 2021-05-12 18:48 | kgv | Relationship added | related to 0032338 |
| 2021-05-13 12:44 | git | Note Added: 0100942 | |
| 2021-05-13 12:47 | git | Note Added: 0100943 | |
| 2021-05-13 12:47 |
|
Assigned To | mkrylova => kgv |
| 2021-05-13 12:47 |
|
Status | assigned => resolved |
| 2021-05-13 20:03 |
|
Note Added: 0100953 | |
| 2021-05-20 12:04 | kgv | Note Added: 0101200 | |
| 2021-05-20 12:04 | kgv | Assigned To | kgv => mkrylova |
| 2021-05-20 12:04 | kgv | Status | resolved => assigned |
| 2021-05-20 14:50 | git | Note Added: 0101209 | |
| 2021-05-20 14:52 | git | Note Added: 0101210 | |
| 2021-05-21 11:30 |
|
Note Added: 0101227 | |
| 2021-05-24 11:45 | git | Note Added: 0101316 | |
| 2021-05-24 11:46 | git | Note Added: 0101317 | |
| 2021-05-24 12:06 |
|
Note Edited: 0101227 | |
| 2021-05-24 12:44 | git | Note Added: 0101324 | |
| 2021-05-24 12:45 | git | Note Added: 0101325 | |
| 2021-05-24 18:44 |
|
Note Added: 0101337 | |
| 2021-05-25 18:33 |
|
Note Added: 0101361 | |
| 2021-05-25 18:34 |
|
Assigned To | mkrylova => kgv |
| 2021-05-25 18:34 |
|
Status | assigned => resolved |
| 2021-05-25 23:23 | kgv | Note Added: 0101374 | |
| 2021-05-25 23:23 | kgv | Assigned To | kgv => bugmaster |
| 2021-05-25 23:23 | kgv | Status | resolved => reviewed |
| 2021-05-29 12:02 | bugmaster | Note Added: 0101469 | |
| 2021-05-29 12:02 | bugmaster | Status | reviewed => tested |
| 2021-05-29 12:04 | bugmaster | Test case number | => Not required |
| 2021-05-29 12:12 | bugmaster | Changeset attached | => occt master 03c9cc86 |
| 2021-05-29 12:12 | bugmaster | Status | tested => verified |
| 2021-05-29 12:12 | bugmaster | Resolution | open => fixed |
| 2021-05-29 13:12 | git | Note Added: 0101493 | |
| 2021-05-29 13:12 | git | Note Added: 0101494 | |
| 2021-05-29 13:12 | git | Note Added: 0101495 | |
| 2021-05-29 13:12 | git | Note Added: 0101496 | |
| 2021-05-29 13:12 | git | Note Added: 0101497 | |
| 2021-06-04 10:58 | kgv | Relationship added | parent of 0032419 |
| 2021-12-17 18:41 | bugmaster | Changeset attached | => occt-products master 606ded06 |
