MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0032292Open CASCADE[OCCT] OCCT:Codingpublic2021-04-10 10:162021-05-10 12:16
Reporterkgv 
Assigned Tomsv 
PrioritynormalSeverityintegration request 
StatusresolvedResolutionreopened 
PlatformOSOS Version
Product Version[OCCT] 7.5.0 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0032292: Coding Rules - improve HLRBRep_PolyAlgo readability part 1
DescriptionProposed changes in the patch remove a couple of redundant variables - pointers to handles in HLRBRep_PolyAlgo.cxx.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot required
Attached Files

- Relationships
child of 0027870closedapn Open CASCADE Modeling - refactoring of HLR algorithms 

-  Notes
(0100216)
git (administrator)
2021-04-10 10:21

Branch CR32292 has been created by kgv.

SHA-1: d8bbfacf30086ec97872470a1b3e3db3e2c4a307


Detailed log of new commits:

Author: kgv
Date: Sat Apr 10 10:21:33 2021 +0300

    0032292: Coding Rules - improve HLRBRep_PolyAlgo readability part 1
    
    HLRBRep_PolyAlgo::StoreShell() - removed a couple of redundant variables (pointers to handles) and extra iterators.
    Added a couple of missing NULL checks (HLRBRep_PolyAlgo::Normal() now skips CSLib::Normal() in case of no surface).
(0100231)
git (administrator)
2021-04-10 19:07

Branch CR32292 has been updated forcibly by kgv.

SHA-1: 67ae634be7b787c5b7d1d09794efd7a99055082a
(0100233)
git (administrator)
2021-04-10 19:31

Branch CR32292 has been updated forcibly by kgv.

SHA-1: fb1009d9d4a3d25fef75c6c473ef5016e19a600a
(0100234)
kgv (developer)
2021-04-10 20:40

Patch is ready for review
- OCCT: branch CR32292.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32292-master-KGV/ [^]
(0100267)
msv (developer)
2021-04-12 23:22

What about failure of the test bugs xde bug24759 on Windows?
(0100268)
kgv (developer)
2021-04-12 23:37
edited on: 2021-04-12 23:42

> What about failure of the test bugs xde bug24759 on Windows?
This test case is unstable: #32245.

(0100269)
msv (developer)
2021-04-12 23:51

For integration:
occt - CR32292
products - none
(0100386)
bugmaster (administrator)
2021-04-17 13:07

Combination -
OCCT branch : IR-2021-04-16
master SHA - 1294d5e39ed35dc97b2241956855fe794a03b0d8
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-04-16 SHA - 03c3cb382950144b11c09108f24673216c4e5922
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17987.850000000446 / 18020.24000000038 [-0.18%]
Products
Total CPU difference: 11564.760000000093 / 11543.43000000007 [+0.18%]
Windows-64-VC14:
OCCT
Total CPU difference: 19496.34375 / 19510.890625 [-0.07%]
Products
Total CPU difference: 12932.890625 / 12891.265625 [+0.32%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0100412)
git (administrator)
2021-04-17 14:02

Branch CR32292 has been deleted by inv.

SHA-1: fb1009d9d4a3d25fef75c6c473ef5016e19a600a
(0100436)
git (administrator)
2021-04-17 23:45

Branch CR32292_2 has been created by kgv.

SHA-1: d9c97185167ef7a05c70d13dd26834f405463d70


Detailed log of new commits:

Author: kgv
Date: Sat Apr 17 22:32:17 2021 +0300

    0032292: Coding Rules - improve HLRBRep_PolyAlgo readability part 2
(0100437)
git (administrator)
2021-04-18 01:01

Branch CR32292_2 has been updated forcibly by kgv.

SHA-1: 7d786ea8974691e3fe0c0bf04fd7d4de1246e131
(0100438)
git (administrator)
2021-04-18 10:58

Branch CR32292_2 has been updated forcibly by kgv.

SHA-1: cf21374bbf8bc06a648a993717ec91db3361197d
(0100439)
git (administrator)
2021-04-18 11:36

Branch CR32292_2 has been updated forcibly by kgv.

SHA-1: 86ccdda292c1c7ad0e529a412a1fecc7975e6a72
(0100440)
git (administrator)
2021-04-18 12:46

Branch CR32292_2 has been updated forcibly by kgv.

SHA-1: af47cc659155d8e2e7a5bc79bf826ae7cefa4067
(0100441)
kgv (developer)
2021-04-18 18:02

Second patch is ready for review
- OCCT: branch CR32292_2.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32292_2-master-KGV/ [^]
(0100459)
msv (developer)
2021-04-19 16:52

(0100544)
bugmaster (administrator)
2021-04-25 10:57

Combination -
OCCT branch : IR-2021-04-23
master SHA - fd2efe5428b3b2b9d300b0612c0a53ee2486ba64
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-04-23 SHA - 740db2b9c0429fd95b1e8cf3790001245aaec02b
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17901.710000000523 / 17988.35000000045 [-0.48%]
Products
Total CPU difference: 11558.800000000136 / 11564.760000000093 [-0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 5522.40625 / 5520.953125 [+0.03%]
Products
Total CPU difference: 12871.203125 / 12932.890625 [-0.48%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0100564)
git (administrator)
2021-04-25 12:24

Branch CR32292_2 has been deleted by inv.

SHA-1: af47cc659155d8e2e7a5bc79bf826ae7cefa4067
(0100827)
git (administrator)
2021-05-08 15:21

Branch CR32292_3 has been created by kgv.

SHA-1: bd7c1c2324867c2315d1ebb49bbf55b60d766187


Detailed log of new commits:

Author: kgv
Date: Mon May 3 21:00:18 2021 +0300

    0032292: Coding Rules - improve HLRBRep_PolyAlgo readability part 3
    
    Use typed collections instead Handle(Standard_Transient) values.
(0100842)
kgv (developer)
2021-05-10 12:16

Third patch is ready for review
- OCCT: branch CR32292_3.

http://jenkins-test-occt/view/CR32292_3-master-KGV/ [^]

- Related Changesets
occt: master 75e1b511
Timestamp: 2021-04-10 07:21:33
Author: kgv
Committer: bugmaster
Details ] Diff ]
0032292: Coding Rules - improve HLRBRep_PolyAlgo readability part 1

HLRBRep_PolyAlgo::StoreShell() - removed a couple of redundant variables (pointers to handles) and extra iterators.
Added a couple of missing NULL checks (HLRBRep_PolyAlgo::Normal() now skips CSLib::Normal() in case of no surface).
mod - src/HLRBRep/HLRBRep_PolyAlgo.cxx Diff ] File ]
occt: master e186cf15
Timestamp: 2021-04-17 19:32:17
Author: kgv
Committer: bugmaster
Details ] Diff ]
0032292: Coding Rules - improve HLRBRep_PolyAlgo readability part 2

Applied name conventions and dropped tabulation symbols.
mod - src/HLRBRep/HLRBRep_PolyAlgo.cxx Diff ] File ]
mod - src/HLRBRep/HLRBRep_PolyAlgo.hxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2021-04-10 10:16 kgv New Issue
2021-04-10 10:16 kgv Assigned To => kgv
2021-04-10 10:21 git Note Added: 0100216
2021-04-10 10:21 kgv Relationship added child of 0027870
2021-04-10 10:22 kgv Relationship added related to 0031963
2021-04-10 10:22 kgv Product Version => 7.5.0
2021-04-10 19:07 git Note Added: 0100231
2021-04-10 19:31 git Note Added: 0100233
2021-04-10 20:40 kgv Note Added: 0100234
2021-04-10 20:40 kgv Assigned To kgv => msv
2021-04-10 20:40 kgv Status new => resolved
2021-04-12 23:22 msv Note Added: 0100267
2021-04-12 23:37 kgv Note Added: 0100268
2021-04-12 23:42 kgv Note Edited: 0100268 View Revisions
2021-04-12 23:51 msv Note Added: 0100269
2021-04-12 23:51 msv Assigned To msv => bugmaster
2021-04-12 23:51 msv Status resolved => reviewed
2021-04-17 13:07 bugmaster Note Added: 0100386
2021-04-17 13:07 bugmaster Status reviewed => tested
2021-04-17 13:13 bugmaster Test case number => Not required
2021-04-17 13:41 bugmaster Changeset attached => occt master 75e1b511
2021-04-17 13:41 bugmaster Status tested => verified
2021-04-17 13:41 bugmaster Resolution open => fixed
2021-04-17 14:02 git Note Added: 0100412
2021-04-17 23:45 git Note Added: 0100436
2021-04-18 01:01 git Note Added: 0100437
2021-04-18 10:58 git Note Added: 0100438
2021-04-18 11:36 git Note Added: 0100439
2021-04-18 12:46 git Note Added: 0100440
2021-04-18 18:02 kgv Assigned To bugmaster => kgv
2021-04-18 18:02 kgv Status verified => feedback
2021-04-18 18:02 kgv Resolution fixed => reopened
2021-04-18 18:02 kgv Note Added: 0100441
2021-04-18 18:02 kgv Assigned To kgv => msv
2021-04-18 18:02 kgv Status feedback => resolved
2021-04-19 16:52 msv Note Added: 0100459
2021-04-19 16:52 msv Assigned To msv => bugmaster
2021-04-19 16:52 msv Status resolved => reviewed
2021-04-25 10:57 bugmaster Note Added: 0100544
2021-04-25 10:57 bugmaster Status reviewed => tested
2021-04-25 11:55 bugmaster Changeset attached => occt master e186cf15
2021-04-25 11:55 bugmaster Status tested => verified
2021-04-25 12:24 git Note Added: 0100564
2021-05-08 15:21 git Note Added: 0100827
2021-05-10 12:15 kgv Assigned To bugmaster => kgv
2021-05-10 12:15 kgv Status verified => feedback
2021-05-10 12:16 kgv Note Added: 0100842
2021-05-10 12:16 kgv Assigned To kgv => msv
2021-05-10 12:16 kgv Status feedback => resolved


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker