View Issue Details

IDProjectCategoryView StatusLast Update
0032217Open CASCADEOCCT:Visualizationpublic2021-12-17 18:41
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityintegration request 
Status closedResolutionfixed 
Target Version7.6.0Fixed in Version7.6.0 
Summary0032217: Visualization, TKOpenGl - drop propagation of unused FFP functions
DescriptionTKOpenGl uses very limited set of functions for FFP fallback, and it is proposed removing unused definitions for deprecated render path.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot required

Relationships

parent of 0032533 closedbugmaster Visualization, TKOpenGl - suppress error reported on Intel drivers due to OpenGL 4.5 specs violation 

Activities

kgv

2021-03-16 21:14

developer   ~0099535

Patch is ready for review
- OCCT: branch CR32217;
- OCC Products: branch CR32217.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32217-master-KGV

osa

2021-03-17 11:46

developer   ~0099543

Parches were reviewed without remarks

bugmaster

2021-03-20 12:49

administrator   ~0099609

Combination -
OCCT branch : IR-2021-03-19
master SHA - d209b3176e21010e096833052698f1c0da5b04d5
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-03-19 SHA - 6baf3a921c29525981c0ad7881214c9b20ffe3c1
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17753.85000000016 / 17750.250000000156 [+0.02%]
Products
Total CPU difference: 11481.660000000102 / 11540.5800000001 [-0.51%]
Windows-64-VC14:
OCCT
Total CPU difference: 19361.09375 / 19341.28125 [+0.10%]
Products
Total CPU difference: 12879.75 / 12869.921875 [+0.08%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Related Changesets

occt: master 43eddb47

2021-03-10 18:59:45

kgv


Committer: bugmaster Details Diff
0032217: Visualization, TKOpenGl - drop propagation of unused FFP functions

OpenGl_GlFunctions no more loads unused FFP functions.
OpenGl_GlCoreXX function tables no more defined two hierarchies with and without FFP functions,
and OpenGl_Context::coreXXback fields have been removed.
Introduced OpenGl_Context::core11ffp as more straightforward naming for obsolete FFP function set.
Affected Issues
0032217
mod - src/OpenGl/OpenGl_AspectsSprite.cxx Diff File
mod - src/OpenGl/OpenGl_Context.cxx Diff File
mod - src/OpenGl/OpenGl_Context.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore11.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore12.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore13.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore14.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore15.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore20.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore21.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore30.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore31.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore32.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore33.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore40.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore41.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore42.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore43.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore44.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore45.hxx Diff File
mod - src/OpenGl/OpenGl_GlCore46.hxx Diff File
mod - src/OpenGl/OpenGl_GlFunctions.cxx Diff File
mod - src/OpenGl/OpenGl_GlFunctions.hxx Diff File
mod - src/OpenGl/OpenGl_LineAttributes.cxx Diff File
mod - src/OpenGl/OpenGl_PrimitiveArray.cxx Diff File
mod - src/OpenGl/OpenGl_Sampler.cxx Diff File
mod - src/OpenGl/OpenGl_ShaderManager.cxx Diff File
mod - src/OpenGl/OpenGl_ShaderProgram.cxx Diff File
mod - src/OpenGl/OpenGl_Structure.cxx Diff File
mod - src/OpenGl/OpenGl_Text.cxx Diff File
mod - src/OpenGl/OpenGl_TextureFormat.cxx Diff File
mod - src/OpenGl/OpenGl_VertexBuffer.cxx Diff File
mod - src/OpenGl/OpenGl_VertexBuffer.lxx Diff File
mod - src/OpenGl/OpenGl_View.cxx Diff File
mod - src/OpenGl/OpenGl_Window.cxx Diff File
mod - src/OpenGl/OpenGl_Window_1.mm Diff File
mod - src/OpenGl/OpenGl_Workspace.cxx Diff File

occt-products: master 0244e8a1

2021-03-16 19:52:14

kgv

Details Diff
0032217: Visualization, TKOpenGl - drop propagation of unused FFP functions

core11 has been replaced by core11ffp.
Affected Issues
0032217
mod - src/PrsPointCloud/PrsPointCloud_RasterRenderer.cxx Diff File

Issue History

Date Modified Username Field Change
2021-03-16 17:36 kgv New Issue
2021-03-16 17:36 kgv Assigned To => kgv
2021-03-16 21:14 kgv Note Added: 0099535
2021-03-16 21:14 kgv Assigned To kgv => osa
2021-03-16 21:14 kgv Status new => resolved
2021-03-17 11:46 osa Note Added: 0099543
2021-03-17 11:46 osa Assigned To osa => bugmaster
2021-03-17 11:46 osa Status resolved => reviewed
2021-03-20 12:49 bugmaster Note Added: 0099609
2021-03-20 12:49 bugmaster Status reviewed => tested
2021-03-20 12:55 bugmaster Test case number => Not required
2021-03-23 21:46 bugmaster Changeset attached => occt master 43eddb47
2021-03-23 21:46 bugmaster Status tested => verified
2021-03-23 21:46 bugmaster Resolution open => fixed
2021-08-12 15:47 kgv Relationship added parent of 0032533
2021-12-17 18:41 kgv Changeset attached => occt-products master 0244e8a1