MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0032206Open CASCADE[OCCT] OCCT:Visualizationpublic2021-03-14 11:112021-04-03 12:52
Reporterkgv 
Assigned Tobugmaster 
PrioritynormalSeverityintegration request 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0032206: Visualization, TKOpenGl - move out OpenGL ES support to dedicated library TKOpenGles
DescriptionCurrently TKOpenGl can be built either in OpenGL (desktop) and OpenGL ES modes.
This has a rationale - both share majority of source code and most interested target platforms support one of two.

However, some systems provide both OpenGL and OpenGL ES implementations at once.
This includes desktop Linux (Mesa) and Windows (with help of Angle library).
Therefore, it is proposed moving out OpenGL ES support to a dedicated library TKOpenGles to allow both being built at once.

The main objective is improved development and testing environment - so that changes in common code could be tested within a single build.
Applications will able to choose which library to use, though obviously full-featured desktop OpenGL should be always preferred when both implementations are available.
But some trickery applications would be able to select library at startup (for instance, when OpenGL drivers are unavailable on Windows, while Direct3D driver available and could be used by Angle).

The simplest way to support TKOpenGl + TKOpenGles configuration is reusing existing source code and just building two libraries with different compiler and linker flags.
In this case, both libraries will export the so-named classes of OpenGl package, but this should be fine as both libraries shouldn't be loaded at once anyway.
This is what this first patch is supposed to implement.

The next steps could be aimed on improving package structure.
One approach could be using macros to rename OpenGl_ classes to OpenGles_ within TKOpenGles library.
This, however, would require a considerable and not nice-looking code modifications across the whole package.

Another approach would be moving out the common code into a dedicated base library TKOpenGlBase.
Within this approach OpenGl_GlFunctions function table should be filled with both OpenGL ES and OpenGL functions at once.
This might be challenging, as it would require solving name collisions between glext.h, OpenGl_GLESExtensions.hxx and system-provided headers of OpenGL and OpenGL ES implementations.
OpenGl_Context sub-classes will be responsible for filling in this function tables from OpenGL or OpenGL ES implementations.
The drawback of this solution would be code paths practically unreachable for TKOpenGles (this should be relatively small amounts of code, mostly FFP-compatibility related), and some extra branching at runtime.
But in result packages structure would look cleaner, so that OpenGL-related code at application side or in extra packages can be build without direct dependency from system OpenGL libraries, and export unified OpenGL/OpenGL ES implementation without duplicating toolkits.
TagsNo tags attached.
Test case numberNot required
Attached Files

- Relationships
parent of 0032242verifiedbugmaster Configuration, CMake - USE_GLES2 option does not appear in interactive configurator 
related to 0032207verifiedbugmaster Draw Harness, ViewerTest - explicitly close 3D Viewer windows at Tcl interpreter closure 
related to 0032208verifiedbugmaster Tests - refactor visualization tests to cover several graphic drivers 

-  Notes
(0099566)
kgv (developer)
2021-03-18 09:09

Patch is ready for review
- OCCT: branch CR32206;
- OCC Products: branch CR32206.
(0099567)
osa (developer)
2021-03-18 10:32

Patches were reviewed without remarks
(0099618)
bugmaster (administrator)
2021-03-20 12:50

Combination -
OCCT branch : IR-2021-03-19
master SHA - d209b3176e21010e096833052698f1c0da5b04d5
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-03-19 SHA - 6baf3a921c29525981c0ad7881214c9b20ffe3c1
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17753.85000000016 / 17750.250000000156 [+0.02%]
Products
Total CPU difference: 11481.660000000102 / 11540.5800000001 [-0.51%]
Windows-64-VC14:
OCCT
Total CPU difference: 19361.09375 / 19341.28125 [+0.10%]
Products
Total CPU difference: 12879.75 / 12869.921875 [+0.08%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

- Related Changesets
occt: master b8ef513c
Timestamp: 2021-03-17 18:03:04
Author: kgv
Committer: bugmaster
Details ] Diff ]
0032206: Visualization, TKOpenGl - move out OpenGL ES support to dedicated library TKOpenGles

Added TKOpenGles and TKOpenGlesTest toolkits built with HAVE_GLES2 macros.
Added CSF_OpenGlesLibs as alternative to CSF_OpenGlLibs.
mod - adm/cmake/egl.cmake Diff ] File ]
mod - adm/cmake/gles2.cmake Diff ] File ]
mod - adm/cmake/occt_csf.cmake Diff ] File ]
mod - adm/cmake/occt_toolkit.cmake Diff ] File ]
mod - adm/cmake/vardescr.cmake Diff ] File ]
mod - adm/genproj.tcl Diff ] File ]
mod - adm/MODULES Diff ] File ]
mod - adm/qmake/OccCppConfig.pri Diff ] File ]
mod - adm/qmake/OccModule.pri Diff ] File ]
mod - adm/qmake/OccToolkit.pri Diff ] File ]
mod - adm/templates/env.bat Diff ] File ]
mod - adm/templates/env.sh Diff ] File ]
mod - adm/templates/template.vc10 Diff ] File ]
mod - adm/templates/template.vc10x Diff ] File ]
mod - adm/UDLIST Diff ] File ]
mod - CMakeLists.txt Diff ] File ]
mod - dox/upgrade/upgrade.md Diff ] File ]
mod - samples/ios/UIKitSample/UIKitSample.xcodeproj/project.pbxproj Diff ] File ]
mod - samples/java/jniviewer/app/src/main/java/com/opencascade/jnisample/OcctJniActivity.java Diff ] File ]
mod - samples/java/jniviewer/app/src/main/jni/CMakeLists.txt Diff ] File ]
mod - samples/qt/AndroidQt/OCCT.pri Diff ] File ]
mod - samples/webgl/CMakeLists.txt Diff ] File ]
mod - samples/webgl/WasmOcctView.cpp Diff ] File ]
mod - src/Draw/Draw_BasicCommands.cxx Diff ] File ]
mod - src/DrawResources/DrawPlugin Diff ] File ]
mod - src/OpenGl/OpenGl_GraphicDriver.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_GraphicDriver.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_GraphicDriverFactory.cxx Diff ] File ]
mod - src/OS/Draw.tcl Diff ] File ]
mod - src/OS/Visualization.tcl Diff ] File ]
add - src/TKOpenGles/CMakeLists.txt Diff ] File ]
add - src/TKOpenGles/EXTERNLIB Diff ] File ]
add - src/TKOpenGles/FILES Diff ] File ]
add - src/TKOpenGles/PACKAGES Diff ] File ]
add - src/TKOpenGlesTest/CMakeLists.txt Diff ] File ]
add - src/TKOpenGlesTest/EXTERNLIB Diff ] File ]
add - src/TKOpenGlesTest/FILES Diff ] File ]
add - src/TKOpenGlesTest/PACKAGES Diff ] File ]
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff ] File ]
add - tests/v3d/glsl/opengles Diff ] File ]

- Issue History
Date Modified Username Field Change
2021-03-14 11:11 kgv New Issue
2021-03-14 11:11 kgv Assigned To => kgv
2021-03-14 11:30 kgv Relationship added related to 0032207
2021-03-14 11:34 kgv Relationship added related to 0032208
2021-03-18 09:09 kgv Note Added: 0099566
2021-03-18 09:09 kgv Assigned To kgv => osa
2021-03-18 09:09 kgv Status new => resolved
2021-03-18 10:32 osa Note Added: 0099567
2021-03-18 10:32 osa Assigned To osa => bugmaster
2021-03-18 10:32 osa Status resolved => reviewed
2021-03-20 12:50 bugmaster Note Added: 0099618
2021-03-20 12:50 bugmaster Status reviewed => tested
2021-03-20 13:00 bugmaster Test case number => Not required
2021-03-23 21:46 bugmaster Changeset attached => occt master b8ef513c
2021-03-23 21:46 bugmaster Status tested => verified
2021-03-23 21:46 bugmaster Resolution open => fixed
2021-03-24 00:31 kgv Relationship added parent of 0032242


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker