View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0032183 | Open CASCADE | OCCT:Visualization | public | 2021-03-01 10:22 | 2021-10-04 13:58 |
Reporter | kgv | Assigned To | bugmaster | ||
Priority | normal | Severity | feature | ||
Status | closed | Resolution | fixed | ||
Target Version | 7.6.0 | Fixed in Version | 7.6.0 | ||
Summary | 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light | ||||
Description | It is proposed implementing AIS_LightSource::ProcessDragging() interface for rotating directional light source. This could be done like this: - Add sphere sensitive for a light (0032182). - Dynamically draw a point (cross of two lines on sphere) via HilightWithColor() method implemented for a custom Owner object. Implement IsForcedHilight() to ensure cross is updated on mouse move. - Calculate AIS_LightSource::ProcessDragging() interface to apply rotation as a delta between points on a sensitive sphere. | ||||
Steps To Reproduce | v3d light_source dyn_highlight | ||||
Tags | No tags attached. | ||||
Test case number | v3d/light_source/dyn_highlight | ||||
related to | 0032182 | closed | bugmaster | Visualization - add Select3D_SensitiveSphere |
parent of | 0032604 | closed | Visualization, AIS_LightSource - improve dragging robustness | |
parent of | 0032605 | assigned | sshutina | Visualization, AIS_LightSource - handle dragging outside of sphere |
child of | 0031704 | closed | bugmaster | Visualization - add an interactive object AIS_LightSource representing a light source |
Not all the children of this issue are yet resolved or closed. |
|
Branch CR32183 has been created by mkrylova. SHA-1: 89726110ba9d66fe247143d440b0529e1ce5f54b Detailed log of new commits: Author: mkrylova Date: Wed Mar 17 17:38:00 2021 +0300 0032182: Visualization - add Select3D_SensitiveSphere - created Select3D_SensitiveSphere class - implemented interfaces for intersection methods - added tests Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source |
|
Branch CR32183 has been updated forcibly by mkrylova. SHA-1: b0c022bfc97d694a7994b6d3ddd0262adaf46462 |
|
Branch CR32183 has been updated forcibly by mkrylova. SHA-1: 8967b2fb26027505c14cfd9e98ce15cf354a8e00 |
|
Solution Implementation, Testing |
|
Branch CR32183 has been updated forcibly by mkrylova. SHA-1: 7e4d8931374ad083b5b31901b5f3383611a83a22 |
|
Testing |
|
Branch CR32183 has been updated forcibly by mkrylova. SHA-1: 619d11e583836795935067d24d0645656e9b76b6 |
|
Solution Evaluation |
|
Solution Evaluation |
|
Solution implementation, Testing |
|
Solution implementation |
|
Branch CR32183 has been updated forcibly by mkrylova. SHA-1: 2a80b7c06bfb7819f52886304997a77ee8761bbf |
|
Branch CR32183_1 has been created by mkrylova. SHA-1: 9d68120def11d16439cf8fa81852e23732d321a6 Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source |
|
http://jenkins-test-occt.nnov.opencascade.com/view/CR32183_1-master-MKRYLOVA/view/ALL/ |
|
Patch is ready to review: - OCCT: CR32183_1 |
|
Solution Implementation |
|
Solution Implementation |
|
Solution Implementation |
|
Solution Implementation |
|
Branch CR32183_1 has been updated forcibly by mkrylova. SHA-1: 15c9be44822bedf5e08e3c06d0eade5aae6857a3 |
|
Branch CR32183_2 has been created by mkrylova. SHA-1: 1833156e3abe9688c715667717f0100fbd1b68e4 Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source |
|
http://jenkins-test-occt.nnov.opencascade.com/view/CR32183_2-master-MKRYLOVA/view/ALL/ (opengl drivers d3dhost is unstable) |
|
Patch is ready to review: - OCCT: CR32183_2 |
|
Solution Implementation, Testing |
|
Solution Implementation, Testing |
2021-07-01 10:50 developer |
arc_by_angle.png (206,022 bytes) |
2021-07-01 10:50 developer |
arc_by_size_in_pixels.png (202,172 bytes) |
2021-07-01 10:51 developer |
presentation.gif (1,253,450 bytes) |
|
Branch CR32183_2 has been updated by mkrylova. SHA-1: 6f549c47ac0efff4b7107919627bc53a008a39c2 Detailed log of new commits: Author: mkrylova Date: Wed Jun 30 18:14:34 2021 +0300 # osa remarks - added highlighting - fixed default arc size |
|
Solution Implementation, Testing |
|
Solution Implementation, Testing |
|
Solution Implementation, Testing |
|
Branch CR32183_2 has been updated by mkrylova. SHA-1: 1a5a49d49604a0e5c379d66fa9f9a5b49ca82dd2 Detailed log of new commits: Author: mkrylova Date: Mon Jul 5 10:33:17 2021 +0300 # kgv remarks |
|
Branch CR32183_3 has been created by mkrylova. SHA-1: 97067015f94de10ba87f32f31ef32092740888cf Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source |
|
Analysis, Solution Implementation |
|
Branch CR32183_3 has been updated forcibly by mkrylova. SHA-1: c6aada24c1ac57b80aac40a860b82469678c8f94 |
|
Branch CR32183_3 has been updated forcibly by mkrylova. SHA-1: a6b35261829ea174ac57ce4b5fe5a27bdab38a6b |
|
Branch CR32183_4 has been created by mkrylova. SHA-1: 523c7baf2869f3aa2fec99d965c25a6d067b9a75 Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source |
|
Testing, Integration |
|
http://jenkins-test-occt.nnov.opencascade.com/view/CR32183_4-master-MKRYLOVA/view/ALL/ |
|
Patch is ready to review: - OCCT: CR32183_4 |
|
Branch CR32183_4 has been updated by mkrylova. SHA-1: a492ddce81195a142481efd8cc5745edcb4da600 Detailed log of new commits: Author: mkrylova Date: Fri Jul 16 14:19:42 2021 +0300 # fixed constructor and added test |
|
Branch CR32183_5 has been created by mkrylova. SHA-1: 0ca48989d3cb6825c40ce815049d8264ea5dc00d Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source - Added test |
|
Branch CR32183_5 has been updated forcibly by mkrylova. SHA-1: a4a6ef5cb6cdb12681760fea30a47e7ae6af0307 |
|
Branch CR32183_5 has been updated by mkrylova. SHA-1: 75c6924f1982655b8eb70f3591a762a290e37254 Detailed log of new commits: Author: mkrylova Date: Mon Jul 19 11:16:24 2021 +0300 # fixed constructor |
|
Branch CR32183_6 has been created by mkrylova. SHA-1: 145c2d7430eb171ab6b737162d5e2f0bcae848cf Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source - Added test # fixed constructor |
|
Branch CR32183_6 has been updated forcibly by mkrylova. SHA-1: a95d39b95ad34cb9ba9d259e6ba8ba705b8b5755 |
|
http://jenkins-test-occt.nnov.opencascade.com/view/CR32183_6-master-MKRYLOVA/view/ALL/ |
|
Patch is ready to review: - OCCT: CR32183_6 |
|
Branch CR32183_6 has been updated by kgv. SHA-1: a041dc37675a5e5bee8d3fd647b78ca7778e6f0b Detailed log of new commits: Author: kgv Date: Tue Jul 20 09:32:45 2021 +0300 # cosmetics |
|
Cosmetic remarks have been pushed to CR32183_6.+Standard_Boolean AIS_LightSourceOwner::IsForcedHilight() const +{ + return true; Is there a reason to force highlight for non-draggable light source types? @@ -53,7 +54,7 @@ Standard_Boolean Select3D_SensitiveSphere::Matches (SelectBasics_SelectingVolume ... + myLastDetectedPoint = theMgr.DetectedPoint (thePickResult.Depth()); Why not using thePickResult.PickedPoint() here? In addition, normally ::Matches() is expected to reset last detected result on failure. +void AIS_LightSourceOwner::HilightWithColor() ... + aPrs->Display(); White highlighting is not reset when dragging another object - only after clicking on no object. I don't think that white highlighting is necessary at all. The following scripts leads to unhandled exception and application crash: pload MODELING VISUALIZATION # create simple scene box b 1 2 3 box bb -5 -5 0 10 10 0 -preview vclear vinit View1 vcamera -persp vdisplay -dispMode 1 b bb vaspects bb -material STONE vfit # setup light sources set aPrsSize 75 vlight -clear vlight -add AMBIENT -color WHITE -display amb -prsSize $aPrsSize # add WHITE directional light source vlight -add DIRECTIONAL -color WHITE -direction 1.0 1.0 -1.0 -head 0 -display dir1 -prsSize $aPrsSize vlight -change 1 -castShadows 1 # add RED directional light source in disabled state vlight -add DIRECTIONAL -color RED -direction 1.0 -1.0 -0.5 -head 0 -display dir2 -prsSize $aPrsSize vselect 300 85 vlight -change 2 -castShadows 1 vrenderparams -shadowMapBias 0.01 Result: An exception was caught 000001EAE9A6C7B0 : Standard_ConstructionError: gp_Dir::Crossed() - result vector has zero norm and then crash. |
|
Branch CR32183_6 has been updated forcibly by mkrylova. SHA-1: 6f7c74fa4d216a378a7d7198714a502a6088dbc5 |
|
Branch CR32183_7 has been created by mkrylova. SHA-1: 39e6a324181bac521e822c647568ddb0e243217a Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source - Added test |
|
Testing, Solution Implementation |
2021-07-21 13:53 developer |
new_presentation.gif (1,708,112 bytes) |
|
Branch CR32183_7 has been updated by mkrylova. SHA-1: 3a6c3cb9a22bf00984b3de1ea26a3024cc19fdcb Detailed log of new commits: Author: mkrylova Date: Wed Jul 21 15:53:15 2021 +0300 # kgv remarks - added possibility to turn on/off light source dragging |
|
Branch CR32183_8 has been created by mkrylova. SHA-1: 6fcd3e3ce36455c8915fc9a2c92bfcaa961c6043 Detailed log of new commits: Author: mkrylova Date: Fri Mar 26 12:31:22 2021 +0300 0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source - Added possibility to turn on/off directional light source dragging - Added test |
|
Testing, Solution Implementation |
|
http://jenkins-test-occt.nnov.opencascade.com/view/CR32183_8-master-MKRYLOVA/view/ALL/ |
|
Patch is ready to review: - OCCT: CR32183_8 |
|
Solution Implementation |
|
Combination - OCCT branch : IR-2021-07-23 master SHA - 4e993e4d0df118716a2ccca02a5735fc4dec54ef a87b7ddc8cb44606b91e3f37113847c3f5f50fdc Products branch : IR-2021-07-23 SHA - 5beb1e287b2273f9e4c222f042380bc3c0fa91dc was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 17248.180000000266 / 17229.680000000302 [+0.11%] Products Total CPU difference: 11453.40000000009 / 11477.160000000118 [-0.21%] Windows-64-VC14: OCCT Total CPU difference: 19038.78125 / 19020.171875 [+0.10%] Products Total CPU difference: 12762.65625 / 12734.125 [+0.22%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
Branch CR32183 has been deleted by mnt. SHA-1: 2a80b7c06bfb7819f52886304997a77ee8761bbf |
|
Branch CR32183_1 has been deleted by mnt. SHA-1: 15c9be44822bedf5e08e3c06d0eade5aae6857a3 |
|
Branch CR32183_2 has been deleted by mnt. SHA-1: 1a5a49d49604a0e5c379d66fa9f9a5b49ca82dd2 |
|
Branch CR32183_3 has been deleted by mnt. SHA-1: a6b35261829ea174ac57ce4b5fe5a27bdab38a6b |
|
Branch CR32183_4 has been deleted by mnt. SHA-1: a492ddce81195a142481efd8cc5745edcb4da600 |
|
Branch CR32183_5 has been deleted by mnt. SHA-1: 75c6924f1982655b8eb70f3591a762a290e37254 |
|
Branch CR32183_6 has been deleted by mnt. SHA-1: 6f7c74fa4d216a378a7d7198714a502a6088dbc5 |
|
Branch CR32183_7 has been deleted by mnt. SHA-1: 3a6c3cb9a22bf00984b3de1ea26a3024cc19fdcb |
|
Branch CR32183_8 has been deleted by mnt. SHA-1: 6fcd3e3ce36455c8915fc9a2c92bfcaa961c6043 |
|
Solution elaboration |
occt: master a3b2aaef 2021-03-26 09:31:22
Committer: bugmaster Details Diff |
0032183: Visualization - implement AIS_LightSource::ProcessDragging() for rotating directional light - Added sensitive sphere for a light source - Implemented AIS_LightSource::ProcessDragging() interface for rotating directional light source - Added possibility to turn on/off directional light source dragging - Added test |
Affected Issues 0032183 |
|
mod - src/AIS/AIS_LightSource.cxx | Diff File | ||
mod - src/AIS/AIS_LightSource.hxx | Diff File | ||
mod - src/Select3D/Select3D_SensitiveSphere.cxx | Diff File | ||
mod - src/Select3D/Select3D_SensitiveSphere.hxx | Diff File | ||
mod - src/SelectMgr/SelectMgr_RectangularFrustum.cxx | Diff File | ||
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
add - tests/v3d/light_source/dyn_highlight | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-03-01 10:22 | kgv | New Issue | |
2021-03-01 10:22 | kgv | Assigned To | => kgv |
2021-03-01 10:22 | kgv | Relationship added | related to 0032182 |
2021-03-01 10:23 | kgv | Assigned To | kgv => mkrylova |
2021-03-01 10:23 | kgv | Description Updated | |
2021-03-01 10:23 | kgv | Relationship added | child of 0031704 |
2021-03-01 10:23 | kgv | Status | new => assigned |
2021-04-21 12:36 | git | Note Added: 0100487 | |
2021-04-22 11:43 |
|
Assigned To | mkrylova => kgv |
2021-04-22 11:43 |
|
Status | assigned => resolved |
2021-04-22 11:43 |
|
Steps to Reproduce Updated | |
2021-04-23 11:51 | git | Note Added: 0100522 | |
2021-04-23 13:59 | kgv | Assigned To | kgv => osa |
2021-05-26 13:33 | git | Note Added: 0101389 | |
2021-05-26 19:24 |
|
Note Added: 0101412 | |
2021-06-08 15:45 | git | Note Added: 0101691 | |
2021-06-08 18:06 |
|
Note Added: 0101698 | |
2021-06-15 11:05 | git | Note Added: 0101837 | |
2021-06-16 15:00 |
|
Assigned To | osa => mkrylova |
2021-06-16 15:00 |
|
Status | resolved => assigned |
2021-06-16 18:33 |
|
Note Added: 0101875 | |
2021-06-17 19:21 |
|
Note Added: 0101901 | |
2021-06-18 18:22 |
|
Note Added: 0101921 | |
2021-06-21 18:54 |
|
Note Added: 0101974 | |
2021-06-22 14:58 | git | Note Added: 0101994 | |
2021-06-22 15:00 | git | Note Added: 0101995 | |
2021-06-22 18:12 |
|
Note Added: 0102001 | |
2021-06-22 18:13 |
|
Note Added: 0102002 | |
2021-06-22 18:14 |
|
Assigned To | mkrylova => osa |
2021-06-22 18:14 |
|
Status | assigned => resolved |
2021-06-22 18:14 |
|
Steps to Reproduce Updated | |
2021-06-22 18:17 |
|
Note Added: 0102003 | |
2021-06-23 18:32 |
|
Note Added: 0102016 | |
2021-06-24 15:09 | kgv | Assigned To | osa => mkrylova |
2021-06-24 15:09 | kgv | Status | resolved => assigned |
2021-06-24 18:09 |
|
Note Added: 0102041 | |
2021-06-25 15:48 |
|
Note Added: 0102051 | |
2021-06-28 15:09 | git | Note Added: 0102117 | |
2021-06-28 15:10 | git | Note Added: 0102118 | |
2021-06-28 18:29 |
|
Note Added: 0102127 | |
2021-06-28 18:30 |
|
Note Added: 0102128 | |
2021-06-28 18:30 |
|
Assigned To | mkrylova => osa |
2021-06-28 18:30 |
|
Status | assigned => resolved |
2021-06-28 18:32 |
|
Note Added: 0102129 | |
2021-06-30 18:58 |
|
Note Added: 0102192 | |
2021-07-01 10:50 |
|
File Added: arc_by_angle.png | |
2021-07-01 10:50 |
|
File Added: arc_by_size_in_pixels.png | |
2021-07-01 10:51 |
|
File Added: presentation.gif | |
2021-07-01 11:13 | git | Note Added: 0102202 | |
2021-07-01 17:45 |
|
Note Added: 0102215 | |
2021-07-03 14:44 |
|
Note Added: 0102250 | |
2021-07-05 18:56 |
|
Note Added: 0102285 | |
2021-07-07 14:19 |
|
Assigned To | osa => mkrylova |
2021-07-07 14:19 |
|
Status | resolved => assigned |
2021-07-07 15:04 | git | Note Added: 0102326 | |
2021-07-07 15:07 | git | Note Added: 0102327 | |
2021-07-13 17:39 |
|
Note Added: 0102501 | |
2021-07-15 17:44 | git | Note Added: 0102551 | |
2021-07-15 18:23 | git | Note Added: 0102552 | |
2021-07-15 18:31 | git | Note Added: 0102553 | |
2021-07-15 18:33 |
|
Note Added: 0102554 | |
2021-07-16 12:32 |
|
Note Added: 0102566 | |
2021-07-16 12:33 |
|
Note Added: 0102567 | |
2021-07-16 12:33 |
|
Assigned To | mkrylova => osa |
2021-07-16 12:33 |
|
Status | assigned => resolved |
2021-07-16 12:57 |
|
Assigned To | osa => mkrylova |
2021-07-16 12:57 |
|
Status | resolved => assigned |
2021-07-16 14:21 | git | Note Added: 0102574 | |
2021-07-16 14:22 | git | Note Added: 0102575 | |
2021-07-19 10:32 |
|
Note Edited: 0102554 | |
2021-07-19 10:44 | git | Note Added: 0102621 | |
2021-07-19 11:17 | git | Note Added: 0102623 | |
2021-07-19 11:23 | git | Note Added: 0102624 | |
2021-07-19 11:25 | git | Note Added: 0102625 | |
2021-07-19 14:16 |
|
Note Added: 0102642 | |
2021-07-19 14:17 |
|
Note Added: 0102643 | |
2021-07-19 14:19 |
|
Assigned To | mkrylova => osa |
2021-07-19 14:19 |
|
Status | assigned => resolved |
2021-07-19 14:19 |
|
Steps to Reproduce Updated | |
2021-07-20 09:33 | git | Note Added: 0102670 | |
2021-07-20 09:47 | kgv | Note Added: 0102671 | |
2021-07-20 09:47 | kgv | Assigned To | osa => mkrylova |
2021-07-20 09:47 | kgv | Status | resolved => assigned |
2021-07-20 18:08 | git | Note Added: 0102684 | |
2021-07-20 18:51 | git | Note Added: 0102687 | |
2021-07-20 18:54 |
|
Note Added: 0102688 | |
2021-07-21 13:53 |
|
File Added: new_presentation.gif | |
2021-07-21 15:54 | git | Note Added: 0102711 | |
2021-07-21 15:56 | git | Note Added: 0102712 | |
2021-07-21 17:07 |
|
Note Added: 0102715 | |
2021-07-22 11:44 |
|
Note Added: 0102721 | |
2021-07-22 11:44 |
|
Note Added: 0102722 | |
2021-07-22 11:45 |
|
Assigned To | mkrylova => osa |
2021-07-22 11:45 |
|
Status | assigned => resolved |
2021-07-22 13:39 | kgv | Assigned To | osa => bugmaster |
2021-07-22 13:39 | kgv | Status | resolved => reviewed |
2021-07-23 16:53 |
|
Note Added: 0102752 | |
2021-07-24 12:10 | bugmaster | Note Added: 0102763 | |
2021-07-24 12:10 | bugmaster | Status | reviewed => tested |
2021-07-24 12:17 | bugmaster | Test case number | => v3d/light_source/dyn_highlight |
2021-07-24 13:23 | bugmaster | Changeset attached | => occt master a3b2aaef |
2021-07-24 13:23 | bugmaster | Status | tested => verified |
2021-07-24 13:23 | bugmaster | Resolution | open => fixed |
2021-07-24 13:28 | git | Note Added: 0102790 | |
2021-07-24 13:28 | git | Note Added: 0102791 | |
2021-07-24 13:28 | git | Note Added: 0102792 | |
2021-07-24 13:28 | git | Note Added: 0102793 | |
2021-07-24 13:28 | git | Note Added: 0102794 | |
2021-07-24 13:28 | git | Note Added: 0102795 | |
2021-07-24 13:28 | git | Note Added: 0102796 | |
2021-07-24 13:28 | git | Note Added: 0102797 | |
2021-07-24 13:28 | git | Note Added: 0102798 | |
2021-07-27 17:23 |
|
Note Added: 0102838 | |
2021-10-04 13:34 | kgv | Relationship added | parent of 0032604 |
2021-10-04 13:58 | kgv | Relationship added | parent of 0032605 |