View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0032121Open CASCADEOCCT:DRAWpublic2021-02-06 18:492021-07-17 10:05
Reporterkgv Assigned Tokgv  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Target Version7.6.0Fixed in Version7.6.0 
Summary0032121: Draw Harness, ViewerTest - implement -reset option for vlight command
DescriptionIt is proposed extended vlight command with -reset argument which will replace light source with specified index with newly created one.
If replaced light source was already displayed - the new once should be displayed instead.
Steps To Reproduce
pload MODELING VISUALIZATION
vclear
vinit View1 -width 1280 -height 720
vlight -clear
vbackground -color GRAY
vrenderparams -shadingModel PBR
box b 10 10 10 30 30 30
vdisplay b -dispMode 1
vaspects b -material Brass
vfit

vlight light1   -type positional -pos 25 25 50 -intensity 10000000000 -range 20 -color BLUE -display
vlight light1   -reset
vlight amblight -type ambient -color WHITE -display
vlight spot     -type spotlight -pos 50 25 25 -dir -1 0 0 -intensity 1000000000 -color RED -display
vlight dirlight -type directional -dir 0 1 0 -color GREEN -display
vlight

TagsNo tags attached.
Test case numberNot required

Relationships

related to 0031704 closedbugmaster Visualization - add an interactive object AIS_LightSource representing a light source 

Activities

git

2021-02-09 18:23

administrator   ~0098797

Branch CR32121 has been created by mkrylova.

SHA-1: bb747def4fffd3333f081274a399d35258a9757c


Detailed log of new commits:

Author: mkrylova
Date: Tue Feb 9 18:01:53 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -set option for vlight command
    
    - Extended vlight command with -set/-replace argument

git

2021-07-09 17:57

administrator   ~0102409

Branch CR32121_1 has been created by kgv.

SHA-1: f77c792eed1f50c8c1544be79bce600bd3cc52ac


Detailed log of new commits:

Author: mkrylova
Date: Tue Feb 9 18:01:53 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -set option for vlight command
    
    vlight command has been revised to make it more friendly.
    Added arguments -enable/-disable for managing enabled state.
    vlight command now accepts light index or name as first argument.
    Added -set/-replace argument.
    
    V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
    Draw::Atof(), applied corrections to avoid explicit new/delete calls.

git

2021-07-10 00:19

administrator   ~0102428

Branch CR32121_2 has been created by kgv.

SHA-1: 1f9cb5ee7c6049ee676c5a9648046eb2f7cc9071


Detailed log of new commits:

Author: kgv
Date: Fri Jul 9 23:22:29 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -reset option for vlight command
    
    vlight command has been revised to provide more friendly syntax.
    Command now accepts light index or name as first argument.
    Added arguments -enable/-disable for managing enabled state.
    Added argument -reset to reset light parameters to default values.
    
    V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
    Graphic3d_TypeOfLightSource enumeration values have been renamed to avoid shortcuts.
    Draw::Atof(), applied corrections to avoid explicit new/delete calls.

git

2021-07-10 10:36

administrator   ~0102429

Branch CR32121_2 has been updated forcibly by kgv.

SHA-1: c134d00dec5de3b7b12121898ed5f1ae149f8a0a

kgv

2021-07-10 12:11

developer   ~0102430

Please raise the patch
- OCCT: branch CR32121_2.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32121_2-master-KGV/

git

2021-07-12 20:50

administrator   ~0102479

Branch CR32121_2 has been updated forcibly by kgv.

SHA-1: 06d40093b715adf9cb1e36d25e5fde6bef2f7b41

bugmaster

2021-07-17 09:45

administrator   ~0102594

Combination -
OCCT branch : IR-2021-07-16
master SHA - acab849d30f2acb733586120dcd2b43f2ae59769
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-07-16 SHA - 0b2936175e8e41158165aa983c4bd52035d88570
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17229.290000000303 / 17544.51000000034 [-1.80%]
Products
Total CPU difference: 11476.020000000117 / 11490.74000000011 [-0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 19019.8125 / 19318.21875 [-1.54%]
Products
Total CPU difference: 12732.515625 / 12831.40625 [-0.77%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2021-07-17 10:04

administrator   ~0102605

Branch CR32121 has been deleted by mnt.

SHA-1: bb747def4fffd3333f081274a399d35258a9757c

git

2021-07-17 10:04

administrator   ~0102606

Branch CR32121_1 has been deleted by mnt.

SHA-1: f77c792eed1f50c8c1544be79bce600bd3cc52ac

git

2021-07-17 10:05

administrator   ~0102607

Branch CR32121_2 has been deleted by mnt.

SHA-1: 06d40093b715adf9cb1e36d25e5fde6bef2f7b41

Related Changesets

occt: master 06d40093

2021-07-09 20:22:29

kgv

Details Diff		 0032121: Draw Harness, ViewerTest - implement -reset option for vlight command

vlight command has been revised to provide more friendly syntax.
Command now accepts light index or name as first argument.
Added arguments -enable/-disable for managing enabled state.
Added argument -reset to reset light parameters to default values.

V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
Graphic3d_TypeOfLightSource enumeration values have been renamed to avoid shortcuts.
Draw::Atof(), applied corrections to avoid explicit new/delete calls.		 Affected Issues
0032121
mod - samples/tcl/cpu.tcl Diff File
mod - samples/tcl/pathtrace_ball.tcl Diff File
mod - samples/tcl/pathtrace_cube.tcl Diff File
mod - samples/tcl/pathtrace_materials.tcl Diff File
mod - samples/tcl/Penrose.tcl Diff File
mod - samples/tcl/raytrace.tcl Diff File
mod - samples/webgl/WasmOcctView.cpp Diff File
mod - src/AIS/AIS_LightSource.cxx Diff File
mod - src/Draw/Draw_VariableCommands.cxx Diff File
mod - src/Graphic3d/Graphic3d_CLight.cxx Diff File
mod - src/Graphic3d/Graphic3d_CLight.hxx Diff File
mod - src/Graphic3d/Graphic3d_LightSet.cxx Diff File
mod - src/Graphic3d/Graphic3d_LightSet.hxx Diff File
mod - src/Graphic3d/Graphic3d_ShaderManager.cxx Diff File
mod - src/Graphic3d/Graphic3d_TypeOfLightSource.hxx Diff File
mod - src/OpenGl/OpenGl_ShaderManager.cxx Diff File
mod - src/OpenGl/OpenGl_ShadowMap.cxx Diff File
mod - src/OpenGl/OpenGl_View.cxx Diff File
mod - src/OpenGl/OpenGl_View_Raytrace.cxx Diff File
mod - src/V3d/V3d_AmbientLight.cxx Diff File
mod - src/V3d/V3d_DirectionalLight.cxx Diff File
mod - src/V3d/V3d_PositionalLight.cxx Diff File
mod - src/V3d/V3d_SpotLight.cxx Diff File
mod - src/V3d/V3d_Viewer.cxx Diff File
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File
mod - tests/opengl/data/general/double_precision Diff File
mod - tests/opengl/data/general/light_off Diff File
mod - tests/opengl/data/raytrace/bug25201 Diff File
mod - tests/opengl/data/raytrace/refraction Diff File
mod - tests/opengl/data/shaderprog/phong_fuse Diff File
mod - tests/opengl/data/shaderprog/phong_fuse2 Diff File
mod - tests/opengl/data/shading/flat_fuse1 Diff File
mod - tests/opengl/data/shading/gouraud_dir2 Diff File
mod - tests/opengl/data/shading/gouraud_pos1 Diff File
mod - tests/opengl/data/shading/gouraud_spot1 Diff File
mod - tests/opengl/data/shading/phong_dir2 Diff File
mod - tests/opengl/data/shading/phong_pos2 Diff File
mod - tests/opengl/data/shading/phong_pos3 Diff File
mod - tests/opengl/data/shading/phong_pos4 Diff File
mod - tests/opengl/data/shading/phong_spot1 Diff File
mod - tests/opengl/data/textures/bug24725 Diff File
mod - tests/v3d/light_source/display_all Diff File
mod - tests/v3d/light_source/headlight Diff File
mod - tests/v3d/light_source/manipulator Diff File

Issue History

Date Modified Username Field Change
2021-02-06 18:49 kgv New Issue
2021-02-06 18:49 kgv Assigned To => mkrylova
2021-02-06 18:49 kgv Status new => assigned
2021-02-06 18:50 kgv Relationship added related to 0031704
2021-02-09 18:23 git Note Added: 0098797
2021-02-09 18:28 mkrylova Assigned To mkrylova => kgv
2021-02-09 18:28 mkrylova Status assigned => resolved
2021-02-09 18:28 mkrylova Steps to Reproduce Updated
2021-07-09 17:57 git Note Added: 0102409
2021-07-09 23:21 kgv Summary Draw Harness, ViewerTest - implement -set option for vlight command => Draw Harness, ViewerTest - implement -reset option for vlight command
2021-07-09 23:21 kgv Description Updated
2021-07-09 23:21 kgv Steps to Reproduce Updated
2021-07-10 00:19 git Note Added: 0102428
2021-07-10 10:36 git Note Added: 0102429
2021-07-10 12:11 kgv Note Added: 0102430
2021-07-10 12:11 kgv Assigned To kgv => bugmaster
2021-07-10 12:11 kgv Status resolved => reviewed
2021-07-12 20:50 git Note Added: 0102479
2021-07-17 09:45 bugmaster Note Added: 0102594
2021-07-17 09:45 bugmaster Status reviewed => tested
2021-07-17 09:47 bugmaster Test case number => Not required
2021-07-17 09:58 kgv Changeset attached => occt master 06d40093
2021-07-17 09:58 kgv Assigned To bugmaster => kgv
2021-07-17 09:58 kgv Status tested => verified
2021-07-17 09:58 kgv Resolution open => fixed
2021-07-17 10:04 git Note Added: 0102605
2021-07-17 10:04 git Note Added: 0102606
2021-07-17 10:05 git Note Added: 0102607