0032045: Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders

Notes
(0098028) git (administrator) 2021-01-10 01:42	Branch CR32045 has been created by kgv. SHA-1: 352a58bfedfb92858951823dc3474bb28ddbf8ca Detailed log of new commits: Author: kgv Date: Sun Jan 10 01:43:03 2021 +0300 0032045: Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders Author: kgv Date: Sun Jan 3 03:05:32 2021 +0300 0032036: Visualization, TKOpenGl - broken Cubemap background on GeForce 320M Enable GL_DEPTH_CLAMP while rendering skybox to workaround unexpected clamping issue on some GPUs.

(0098034) git (administrator) 2021-01-10 02:34	Branch CR32045 has been updated forcibly by kgv. SHA-1: cbf9d595d62baa547fc811e6c8b6b0859fae2594

(0098038) kgv (developer) 2021-01-10 11:11	Patch is ready for review - OCCT branch: CR32045. http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32045-master-KGV/ [^]

(0098091) osa (developer) 2021-01-12 14:58	The patch was reviewed without remarks

(0098149) bugmaster (administrator) 2021-01-16 13:30	Combination - OCCT branch : IR-2021-01-15 master SHA - 6fab0b34288ef3f29ecf4eabc0283540460dbc31 a206de37fbfa0bf71bd534ae47192bbec23b8522 Products branch : IR-2021-01-15 SHA - a8521c25e41405ac279e65e1fcde5de75a344b0b was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 17754.160000000134 / 17720.07000000011 [+0.19%] Products Total CPU difference: 12412.630000000105 / 12419.360000000095 [-0.05%] Windows-64-VC14: OCCT Total CPU difference: 19336.3125 / 19330.015625 [+0.03%] Products Total CPU difference: 13740.03125 / 13831.828125 [-0.66%] Image differences : No differences that require special attention Memory differences : No differences that require special attention

Related Changesets
occt: master c0efce7c Timestamp: 2021-01-09 22:43:03 Author: kgv Committer: bugmaster [ Details ] [ Diff ]	0032045: Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders
	mod - src/OpenGl/OpenGl_ShaderManager.cxx	[ Diff ] [ File ]
	mod - src/Shaders/FILES	[ Diff ] [ File ]
	add - src/Shaders/PBRDirectionalLight.glsl	[ Diff ] [ File ]
	add - src/Shaders/PBRPointLight.glsl	[ Diff ] [ File ]
	add - src/Shaders/PBRSpotLight.glsl	[ Diff ] [ File ]
	add - src/Shaders/PhongDirectionalLight.glsl	[ Diff ] [ File ]
	add - src/Shaders/PhongPointLight.glsl	[ Diff ] [ File ]
	add - src/Shaders/PhongSpotLight.glsl	[ Diff ] [ File ]
	add - src/Shaders/Shaders_PBRDirectionalLight_glsl.pxx	[ Diff ] [ File ]
	add - src/Shaders/Shaders_PBRPointLight_glsl.pxx	[ Diff ] [ File ]
	add - src/Shaders/Shaders_PBRSpotLight_glsl.pxx	[ Diff ] [ File ]
	add - src/Shaders/Shaders_PhongDirectionalLight_glsl.pxx	[ Diff ] [ File ]
	add - src/Shaders/Shaders_PhongPointLight_glsl.pxx	[ Diff ] [ File ]
	add - src/Shaders/Shaders_PhongSpotLight_glsl.pxx	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2021-01-10 01:41	kgv	New Issue
2021-01-10 01:41	kgv	Assigned To	=> kgv
2021-01-10 01:42	git	Note Added: 0098028
2021-01-10 02:34	git	Note Added: 0098034
2021-01-10 11:11	kgv	Note Added: 0098038
2021-01-10 11:11	kgv	Assigned To	kgv => osa
2021-01-10 11:11	kgv	Status	new => resolved
2021-01-12 14:58	osa	Note Added: 0098091
2021-01-12 14:58	osa	Assigned To	osa => bugmaster
2021-01-12 14:58	osa	Status	resolved => reviewed
2021-01-16 13:30	bugmaster	Note Added: 0098149
2021-01-16 13:30	bugmaster	Status	reviewed => tested
2021-01-16 13:53	bugmaster	Test case number	=> Not required
2021-01-16 14:12	bugmaster	Changeset attached	=> occt master c0efce7c
2021-01-16 14:12	bugmaster	Status	tested => verified
2021-01-16 14:12	bugmaster	Resolution	open => fixed

Relationships