MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0032042Open CASCADE[OCCT] OCCT:Visualizationpublic2021-01-07 11:202021-01-12 12:17
Reporterkgv 
Assigned Tobugmaster 
PrioritynormalSeverityintegration request 
StatusreviewedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0032042: Visualization, TKOpenGl - pre-multiply headlight flag into light source position
DescriptionCurrently headlight flag is passed to GLSL program so that transformation has to be applied dynamically.

This looks like unnecessary overcomplication - as camera position remains static within frame, it makes sense premultiplying transformation and passing final headlight position.
TagsNo tags attached.
Test case number
Attached Files

- Relationships
related to 0027750closedbugmaster Visualization, V3d_View - remove unused functionality ZClipping and ZCueing 

-  Notes
(0098022)
git (administrator)
2021-01-09 23:34

Branch CR32042 has been created by kgv.

SHA-1: c262aafaff5398237d85c2ab434141501460ab70


Detailed log of new commits:

Author: kgv
Date: Fri Jan 8 00:48:29 2021 +0300

    0032042: Visualization, TKOpenGl - pre-multiply headlight flag into light source position
    
    OpenGl_ShaderManager::pushLightSourceState() now pre-multiplies headlight transformation.
    Built-in shading GLSL programs have been updated to remove special handling if headlight flag;
    also removed redundant pre-normalization of light source direction
    (already normalized implicitly by Graphic3d_CLight interface).
    
    Graphic3d_CLight::SetHeadlight() now raises exception in case of ambient light type.
    OpenGl_ShaderManager::SetLastView() - removed unused property.
(0098032)
git (administrator)
2021-01-10 02:29

Branch CR32042 has been updated forcibly by kgv.

SHA-1: f9be7ae44ff09900e41e2b41627ab91bdf803fe9
(0098036)
kgv (developer)
2021-01-10 04:25

Patch is ready for review
- OCCT branch: CR32042.

http://jenkins-test-12.nnov.opencascade.com/view/CR32042-master-KGV [^]
(0098088)
osa (developer)
2021-01-12 12:17

The patch was reviewed

- Issue History
Date Modified Username Field Change
2021-01-07 11:20 kgv New Issue
2021-01-07 11:20 kgv Assigned To => kgv
2021-01-07 11:23 kgv Relationship added related to 0027750
2021-01-09 23:34 git Note Added: 0098022
2021-01-10 02:29 git Note Added: 0098032
2021-01-10 04:25 kgv Note Added: 0098036
2021-01-10 04:25 kgv Assigned To kgv => osa
2021-01-10 04:25 kgv Status new => resolved
2021-01-12 12:17 osa Note Added: 0098088
2021-01-12 12:17 osa Assigned To osa => bugmaster
2021-01-12 12:17 osa Status resolved => reviewed


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker