MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0032028Open CASCADE[OCCT] OCCT:Codingpublic2020-12-29 12:552021-01-16 14:12
Reporterkgv 
Assigned Tobugmaster 
PrioritynormalSeverityminor 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version[OCCT] 7.6.0* 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0032028: Coding Rules, StepFile - eliminate CLang warning -Wmisleading-indentation
DescriptionThere are new CLang compiler warnings since 0031756:
shared:INFO: (Emscripten: Running sanity checks)
C:\occt.git\src\StepFile\lex.step.cxx:954:13: warning: misleading indentation; statement is not part 
of the previous 'if' [-Wmisleading-indentation]
            if ( ! (yy_state_buf) )
            ^
C:\occt.git\src\StepFile\lex.step.cxx:952:9: note: previous statement is here
        if ( ! (yy_state_buf) )
        ^
C:\occt.git\src\StepFile\lex.step.cxx:1679:3: warning: misleading indentation; statement is not part 
of the previous 'if' [-Wmisleading-indentation]
                return yy_is_jam ? 0 : yy_current_state;
                ^
C:\occt.git\src\StepFile\lex.step.cxx:1676:2: note: previous statement is here
        if ( ! yy_is_jam )
        ^
2 warnings generated.


Compiler version:
c:\work\Develop\SDKs\emsdk\upstream\bin>clang.exe --version
clang version 12.0.0 (Cswircachegitchromium.googlesource.com-external-github.com-llvm-llvm--project f4c8b80318005ca61bfed9b40ee9e6039194159b)

Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: c:\work\Develop\SDKs\emsdk\upstream\bin
Steps To ReproduceNo test case ( the executable code has not been modified )
TagsNo tags attached.
Test case numberNot required
Attached Files

- Relationships
child of 0031756verifiedbugmaster Open CASCADE Data Exchange - broken parsing of STEP entity in case of missing last parameter 

-  Notes
(0097987)
git (administrator)
2020-12-30 12:23

Branch CR32028 has been created by dpasukhi.

SHA-1: e3294f3513d14fe07367acd3307d4e98be39aef3


Detailed log of new commits:

Author: dpasukhi
Date: Wed Dec 30 12:20:22 2020 +0300

    0032028: Coding Rules, StepFile - eliminate CLang warning -Wmisleading-indentation
    
    Fixed warning in clang version 10 and newer
(0098059)
git (administrator)
2021-01-11 13:55

Branch CR32028_1 has been created by dpasukhi.

SHA-1: c07366175a40dfb5231e640d53956619f699d6b9


Detailed log of new commits:

Author: dpasukhi
Date: Wed Dec 30 12:20:22 2020 +0300

    0032028: Coding Rules, StepFile - eliminate CLang warning -Wmisleading-indentation
    
    Regenerated the StepFile/lex.step.cxx using the latest version of WinFlexBison
    - Fixed [-Wmisleading-indentation] warning
    - Removed empty lines
(0098060)
git (administrator)
2021-01-11 14:05

Branch CR32028_1 has been updated forcibly by dpasukhi.

SHA-1: 62356acaf530506adae35b16b128a073b416976f
(0098074)
dpasukhi (developer)
2021-01-11 15:47

Dear kgv,
please review CR32028_1.
I generated step.lex.cxx with the new version of WinFlexBison.
It fixed the problems with incorrect syntax(tabs) and empty lines.
(0098075)
kgv (developer)
2021-01-11 15:51

Could you please add related fix / pull request in WinFlexBison project here as a comment?
(0098076)
kgv (developer)
2021-01-11 15:51

Dear bugmaster,

please check warnings on extended list of compilers.
(0098078)
dpasukhi (developer)
2021-01-11 16:24

Related pull request in WinFlexBison project:
https://github.com/lexxmark/winflexbison/pull/71 [^]

The pull request contains only syntax corrections, the main algorithm has not been modified.
(0098144)
bugmaster (administrator)
2021-01-16 13:29

Combination -
OCCT branch : IR-2021-01-15
master SHA - 6fab0b34288ef3f29ecf4eabc0283540460dbc31
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2021-01-15 SHA - a8521c25e41405ac279e65e1fcde5de75a344b0b
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17754.160000000134 / 17720.07000000011 [+0.19%]
Products
Total CPU difference: 12412.630000000105 / 12419.360000000095 [-0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 19336.3125 / 19330.015625 [+0.03%]
Products
Total CPU difference: 13740.03125 / 13831.828125 [-0.66%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

- Related Changesets
occt: master ab80de54
Timestamp: 2020-12-30 09:20:22
Author: dpasukhi
Committer: bugmaster
Details ] Diff ]
0032028: Coding Rules, StepFile - eliminate CLang warning -Wmisleading-indentation

Regenerated the StepFile/lex.step.cxx using the latest version of WinFlexBison
- Fixed [-Wmisleading-indentation] warning
- Removed empty lines
mod - src/StepFile/lex.step.cxx Diff ] File ]
mod - src/StepFile/step.lex Diff ] File ]

- Issue History
Date Modified Username Field Change
2020-12-29 12:55 kgv New Issue
2020-12-29 12:55 kgv Assigned To => dpasukhi
2020-12-29 12:55 kgv Relationship added child of 0031756
2020-12-29 12:57 kgv Relationship added related to 0031180
2020-12-30 12:23 git Note Added: 0097987
2021-01-11 13:55 git Note Added: 0098059
2021-01-11 14:05 git Note Added: 0098060
2021-01-11 15:47 dpasukhi Note Added: 0098074
2021-01-11 15:47 dpasukhi Assigned To dpasukhi => kgv
2021-01-11 15:47 dpasukhi Status new => resolved
2021-01-11 15:47 dpasukhi Steps to Reproduce Updated View Revisions
2021-01-11 15:51 kgv Note Added: 0098075
2021-01-11 15:51 kgv Note Added: 0098076
2021-01-11 15:51 kgv Assigned To kgv => bugmaster
2021-01-11 15:51 kgv Status resolved => feedback
2021-01-11 15:51 kgv Status feedback => reviewed
2021-01-11 16:24 dpasukhi Note Added: 0098078
2021-01-16 13:29 bugmaster Note Added: 0098144
2021-01-16 13:29 bugmaster Status reviewed => tested
2021-01-16 13:50 bugmaster Test case number => Not required
2021-01-16 14:12 bugmaster Changeset attached => occt master ab80de54
2021-01-16 14:12 bugmaster Status tested => verified
2021-01-16 14:12 bugmaster Resolution open => fixed


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker