MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0032008Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2020-12-18 13:552021-01-11 11:57
Reporterkgv 
Assigned Tokgv 
PrioritynormalSeverityminor 
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version[OCCT] 7.5.0 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0032008: Modeling Algorithms - disallow implicit copy of Extrema algorithms
DescriptionExtrema classes provides implicit copy constructors, however these tools look too heavy for such usage and better to be avoided.
TagsNo tags attached.
Test case number
Attached Files

- Relationships
related to 0032014newgka Data Exchange - large STEP file is read 2-3 times slower on msvc14 than on GCC and CLang 
related to 0032044verifiedbugmaster Foundation Classes - NCollection_Array2::Resize() does not allocate pointer array 

-  Notes
(0097710)
git (administrator)
2020-12-18 14:29

Branch CR32008 has been created by kgv.

SHA-1: f56afcbba711c2826f24d486a726c5293687e7db


Detailed log of new commits:

Author: kgv
Date: Fri Dec 18 14:29:59 2020 +0300

    0032008: Foundation Classes - NCollection_Array2::Resize() does not allocate pointer array
    
    NCollection_Array2::Resize() has been fixed to set myDeletable before calling Allocate().
    
    Extrema_GenExtPS now prefers resizing of Array2 tables instead of managing tables by extra handles.
    Removed unsafe casts to Adaptor3d_SurfacePtr/Adaptor3d_CurvePtr in Extrema classes.
(0097732)
git (administrator)
2020-12-18 22:11

Branch CR32008 has been updated forcibly by kgv.

SHA-1: a6e54da0c0a51ea4c126b19d6e0a95fa669bae48
(0097807)
git (administrator)
2020-12-19 16:02

Branch CR32008 has been updated forcibly by kgv.

SHA-1: acc3c3e62fd1610a17a170431f4adf63d68bda66
(0097810)
kgv (developer)
2020-12-19 22:14

Patch is ready for review
- OCCT branch: CR32008.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32008-master-KGV/ [^]
(0098026)
git (administrator)
2021-01-10 00:34

Branch CR32008_1 has been created by kgv.

SHA-1: 59254ea75a2acbf9a31ea7d0966d2c5c5938746f


Detailed log of new commits:

Author: kgv
Date: Fri Dec 18 14:29:59 2020 +0300

    0032008: Modeling Algorithms - disallow implicit copy of Extrema algorithms
    
    Extrema_GenExtPS now prefers resizing of Array2 tables instead of managing tables by extra handles.
    Removed unsafe casts to Adaptor3d_SurfacePtr/Adaptor3d_CurvePtr in Extrema classes.
    
    Extrema_GenExtPS, Extrema_GenExtSS, Extrema_ExtCS -
    copies by value are now disallowed;
    several unexpected places copying the object have been fixed.
    
    IntTools_Context - maps of void* have been replaced by typed maps.
(0098048)
msv (developer)
2021-01-11 11:57

Why didn't you get rid of void* for the type of curves in Extrema_ExtCC?
  Standard_Address myC[2];


+ myECC = Extrema_ECC (C1, C2),
...
+ myECC = Extrema_ECC (C1, C2, U1, U2, V1, V2),

(Use semicolon instead of comma at the end of statements.)
Avoid usage of these copy-ctors, as in Perform() the first thing is done is initialization of myECC.

+ NCollection_DataMap<Handle(Standard_Transient), GeomAPI_ProjectPointOnCurve*, TColStd_MapTransientHasher> myProjPTMap;

Please replace the key type Handle(Standard_Transient) with Handle(Geom_Curve).

- Issue History
Date Modified Username Field Change
2020-12-18 13:55 kgv New Issue
2020-12-18 13:55 kgv Assigned To => abv
2020-12-18 14:29 git Note Added: 0097710
2020-12-18 22:11 git Note Added: 0097732
2020-12-19 16:02 git Note Added: 0097807
2020-12-19 22:14 kgv Note Added: 0097810
2020-12-19 22:14 kgv Status new => resolved
2020-12-22 11:21 kgv Relationship added related to 0032014
2021-01-09 23:59 kgv Category OCCT:Foundation Classes => OCCT:Modeling Algorithms
2021-01-09 23:59 kgv Summary Foundation Classes - NCollection_Array2::Resize() does not allocate pointer array => Modeling Algorithms - disallow implicit copy of Extrema algorithms
2021-01-10 00:02 kgv Description Updated View Revisions
2021-01-10 00:34 git Note Added: 0098026
2021-01-10 00:36 kgv Relationship added related to 0032044
2021-01-10 03:44 kgv Assigned To abv => msv
2021-01-11 11:57 msv Note Added: 0098048
2021-01-11 11:57 msv Assigned To msv => kgv
2021-01-11 11:57 msv Status resolved => assigned


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker