View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031956 | Open CASCADE | OCCT:Visualization | public | 2020-11-24 10:04 | 2022-11-18 06:23 |
| Reporter | kgv | Assigned To | vpozdyayev | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | open | ||
| Product Version | 7.4.0 | ||||
| Target Version | 7.8.0 | ||||
| Summary | 0031956: Visualization - provide Image_AlienPixMap::Save() writing into a memory buffer instead of a file | ||||
| Description | Image_AlienPixMap::Load() provides overloads reading image from file path, memory buffer and std::istream. In contrast, Image_AlienPixMap::Save() is currently able to write only into the given file path, which restricts class usability. | ||||
| Steps To Reproduce | test v3d/bugs/bug31956 | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR31956 has been created by CheskoArt. SHA-1: fbf48c08439946f24061d1b7d2f6b0bb78ed656a Detailed log of new commits: Author: achesnok Date: Mon Sep 6 14:36:40 2021 +0300 0031956: Visualization - provide Image_AlienPixMap::Save() writing into a memory buffer instead of a file Added two new Image_AlienPixMap::Save() overloads, taking std::ostream or memory buffer arguments. |
|
|
Branch CR31956 has been updated forcibly by CheskoArt. SHA-1: 58887fde1aeca0408c1dc7f872b53386626370a0 |
|
|
Branch CR31956 has been updated forcibly by CheskoArt. SHA-1: c5594d863afbdf330ae4dae912be6ca5133d74b2 |
|
|
Please review the patch. Test results: http://jenkins-test-occt.nnov.opencascade.com/view/CR31956-master-achesnok/view/ALL/ |
|
|
+#ifdef HAVE_FREEIMAGE + Standard_EXPORT FIBITMAP* GetImageToDump (int theFormat); FIBITMAP* myLibImage; This breaks binary compatibility and should be reverted. HAVE_FREEIMAGE should not occur in .hxx header. |
|
|
Branch CR31956 has been updated forcibly by CheskoArt. SHA-1: 5303e6b270b86fbcd8a769b5fab4fa2e653c0604 |
|
|
Branch CR31956 has been updated forcibly by CheskoArt. SHA-1: db9b3fca3d8c457239a50b13e33c5ae5bf9dc868 |
|
|
Patch fixed |
|
|
Review request. |
|
|
-: myLibImage (NULL) +#ifdef HAVE_FREEIMAGE + : myLibImage (NULL) +#endif Won't this break ''Image_AlienPixMap::Clear''? This feature needs validation for all build types. + //! when theData isn't NULL used only to determine format What's "theData"? + //! @param theBuffer buffer pointer where to write What are the NULL buffer semantics here? + Standard_EXPORT bool Save (const TCollection_AsciiString& theFileName, + Standard_Byte* theBuffer = NULL, + Standard_Size theLength = 0); Of all the Save/Load functions here, this is the only one that does not take filename as the last argument. Let's not sacrifice API consistency to avoid adding one more function. |
|
|
Branch CR31956_1 has been created by mzernova. SHA-1: db9b3fca3d8c457239a50b13e33c5ae5bf9dc868 No new revisions were added by this update. |
|
|
Branch CR31956 has been updated forcibly by mzernova. SHA-1: 2307f70538bb6f13358f6e14f8cdc3ad63277f00 |
|
|
Branch CR31956 has been updated forcibly by mzernova. SHA-1: b49c83d4330962d7a20c3d0dc0f27f7b6c33b843 |
|
|
Branch CR31956_1 has been updated forcibly by mzernova. SHA-1: f327716896c5dddfb5c22d8f370598c16ace25dd |
|
|
http://jenkins-test-occt.nnov.opencascade.com/view/CR31956_1-master-mzernova/view/ALL/ |
|
|
OCCT branch: CR31956_1 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-11-24 10:04 | kgv | New Issue | |
| 2020-11-24 10:04 | kgv | Assigned To | => kgv |
| 2020-11-24 10:06 | kgv | Relationship added | related to 0030182 |
| 2020-11-24 10:06 | kgv | Relationship replaced | child of 0030182 |
| 2020-11-24 10:06 | kgv | Product Version | => 7.4.0 |
| 2020-11-24 10:06 | kgv | Relationship added | related to 0030549 |
| 2021-08-11 11:31 | age | Assigned To | kgv => CheskoArt |
| 2021-08-11 11:53 | CheskoArt | Status | new => assigned |
| 2021-09-14 14:12 | git | Note Added: 0104074 | |
| 2021-09-15 21:34 | git | Note Added: 0104104 | |
| 2021-09-15 22:04 | git | Note Added: 0104105 | |
| 2021-09-16 19:07 | CheskoArt | Note Added: 0104131 | |
| 2021-09-16 19:07 | CheskoArt | Assigned To | CheskoArt => kgv |
| 2021-09-16 19:07 | CheskoArt | Status | assigned => resolved |
| 2021-09-16 19:07 | CheskoArt | Steps to Reproduce Updated | |
| 2021-09-16 19:23 | kgv | Note Added: 0104132 | |
| 2021-09-16 21:05 | git | Note Added: 0104134 | |
| 2021-09-18 08:04 | CheskoArt | Assigned To | kgv => CheskoArt |
| 2021-09-18 08:04 | CheskoArt | Status | resolved => assigned |
| 2021-09-18 14:36 | git | Note Added: 0104215 | |
| 2021-09-18 17:37 | CheskoArt | Note Added: 0104217 | |
| 2021-09-18 17:37 | CheskoArt | Assigned To | CheskoArt => kgv |
| 2021-09-18 17:37 | CheskoArt | Status | assigned => resolved |
| 2021-09-18 17:37 | CheskoArt | Steps to Reproduce Updated | |
| 2021-09-19 10:01 | kgv | Target Version | 7.6.0 => 7.7.0 |
| 2022-10-04 16:52 | szy | Assigned To | kgv => vpozdyayev |
| 2022-10-04 16:52 | szy | Note Added: 0111388 | |
| 2022-10-10 11:35 | vpozdyayev | Note Added: 0111449 | |
| 2022-10-10 11:35 | vpozdyayev | Note Edited: 0111449 | |
| 2022-10-10 11:36 | vpozdyayev | Note Edited: 0111449 | |
| 2022-10-10 11:36 | vpozdyayev | Note Edited: 0111449 | |
| 2022-10-10 11:38 | vpozdyayev | Note Edited: 0111449 | |
| 2022-10-10 11:39 | vpozdyayev | Note Edited: 0111449 | |
| 2022-10-10 15:54 | vpozdyayev | Assigned To | vpozdyayev => mzernova |
| 2022-10-10 15:56 | vpozdyayev | Status | resolved => assigned |
| 2022-10-24 10:43 | szy | Target Version | 7.7.0 => 7.8.0 |
| 2022-11-17 10:16 | git | Note Added: 0112141 | |
| 2022-11-17 10:52 | git | Note Added: 0112143 | |
| 2022-11-17 11:02 | git | Note Added: 0112144 | |
| 2022-11-17 11:02 | git | Note Added: 0112145 | |
| 2022-11-18 06:21 | mzernova | Note Added: 0112161 | |
| 2022-11-18 06:22 | mzernova | Note Added: 0112162 | |
| 2022-11-18 06:23 | mzernova | Assigned To | mzernova => vpozdyayev |
| 2022-11-18 06:23 | mzernova | Status | assigned => resolved |
| 2022-11-18 06:23 | mzernova | Steps to Reproduce Updated |
