MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031842Community[OCCT] OCCT:Codingpublic2020-10-12 17:392020-10-24 12:42
Reportergalbramc 
Assigned Tobugmaster 
PrioritynormalSeveritymajor 
StatusverifiedResolutionfixed 
PlatformMacOSOSOS VersionX
Product Version[OCCT] 7.5.0 
Target Version[OCCT] 7.5.0Fixed in Version 
Summary0031842: Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer
Description
opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:128:36: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:128:36 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_4.cxx:220:38: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_4.cxx:220:38 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_5.cxx:281:38: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_5.cxx:281:38 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:1076:41: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:1076:41 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:311:38: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:311:38 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:487:33: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:487:33 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:1022:28: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:1022:28 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:256:41: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:256:41 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:713:41: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:713:41 
in
opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:148:35: runtime error: reference binding 
to null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:148:35 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_2.cxx:453:30: runtime error: reference binding to 
null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_2.cxx:453:30 
in
opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_3.cxx:435:30: runtime error: reference binding to 
null pointer of type 'const Message_ProgressScope'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_3.cxx:435:30 
in
Steps To ReproduceCompile OCCT 7.5.0 Beta with -fsanitize=undefined and run solid boolean operations without providing a progress scope.
TagsNo tags attached.
Test case numberNot required
Attached Files

- Relationships
child of 0025748verifiedabv Open CASCADE Foundation Classes - Parallel version of progress indicator 

-  Notes
(0095901)
git (administrator)
2020-10-12 17:57

Branch CR31842 has been created by kgv.

SHA-1: 3230eefb412d649d1e6294b07b68832ac6d6f90e


Detailed log of new commits:

Author: kgv
Date: Mon Oct 12 18:00:22 2020 +0300

    0031842: Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer
    
    Added NULL checks before Progress Scope pointer dereference.
(0095902)
galbramc (reporter)
2020-10-12 18:28

I grabbed the patch and this fix resolves the issue.
(0095903)
kgv (developer)
2020-10-12 19:16

Patch is ready for review
- OCCT branch: CR31842.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31842-master-KGV/ [^]
(0095906)
msv (developer)
2020-10-12 22:27

For integration:
occt - CR31842
products - none
(0096028)
bugmaster (administrator)
2020-10-17 13:21

Combination -
OCCT branch : IR-2020-10-16
master SHA - ae9f4b64cacf0df612944b3694a3bdfa5f1f29cf
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-10-16 SHA - fcb5abe005e152f7f923f4cf6c02acb07c027cdc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18027.820000000127 / 18057.130000000117 [-0.16%]
Products
Total CPU difference: 12174.330000000093 / 12182.170000000115 [-0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 19740.03125 / 19746.828125 [-0.03%]
Products
Total CPU difference: 13564.71875 / 13586.625 [-0.16%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0096230)
git (administrator)
2020-10-24 12:42

Branch CR31842 has been deleted by inv.

SHA-1: 3230eefb412d649d1e6294b07b68832ac6d6f90e

- Related Changesets
occt: master d9221495
Timestamp: 2020-10-12 15:00:22
Author: kgv
Committer: bugmaster
Details ] Diff ]
0031842: Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer

Added NULL checks before Progress Scope pointer dereference.
mod - src/BOPAlgo/BOPAlgo_BOP.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_Builder.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_Builder_2.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_Builder_3.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_CheckerSI.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_MakerVolume.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_PaveFiller_2.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_PaveFiller_4.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_PaveFiller_5.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx Diff ] File ]
mod - src/BOPAlgo/BOPAlgo_Splitter.cxx Diff ] File ]
mod - src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx Diff ] File ]
mod - src/BRepAlgoAPI/BRepAlgoAPI_Check.cxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2020-10-12 17:39 galbramc New Issue
2020-10-12 17:39 galbramc Assigned To => abv
2020-10-12 17:47 kgv Product Version => 7.5.0
2020-10-12 17:47 kgv Target Version => 7.5.0
2020-10-12 17:47 kgv Summary [OCCT] 7.5.0 Beta -fsanitize=undefined reference binding to null pointer => Coding Rules - eliminate CLang warning -fsanitize=undefined reference binding to null pointer, BRepAlgoAPI_BuilderAlgo
2020-10-12 17:47 kgv Relationship added child of 0025748
2020-10-12 17:47 kgv Description Updated View Revisions
2020-10-12 17:56 kgv Summary Coding Rules - eliminate CLang warning -fsanitize=undefined reference binding to null pointer, BRepAlgoAPI_BuilderAlgo => Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer
2020-10-12 17:57 git Note Added: 0095901
2020-10-12 18:28 galbramc Note Added: 0095902
2020-10-12 19:16 kgv Note Added: 0095903
2020-10-12 19:16 kgv Assigned To abv => msv
2020-10-12 19:16 kgv Status new => resolved
2020-10-12 22:27 msv Note Added: 0095906
2020-10-12 22:27 msv Assigned To msv => bugmaster
2020-10-12 22:27 msv Status resolved => reviewed
2020-10-17 13:21 bugmaster Note Added: 0096028
2020-10-17 13:21 bugmaster Status reviewed => tested
2020-10-17 13:25 bugmaster Test case number => Not required
2020-10-17 13:31 bugmaster Changeset attached => occt master d9221495
2020-10-17 13:31 bugmaster Status tested => verified
2020-10-17 13:31 bugmaster Resolution open => fixed
2020-10-24 12:42 git Note Added: 0096230


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker