View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031835CommunityOCCT:Modeling Algorithmspublic2020-10-10 13:092020-12-02 17:13
ReporterVico Liang Assigned Tobugmaster  
PrioritynormalSeverityblock 
Status closedResolutionfixed 
Product Version7.5.0 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031835: Modeling Algorithms - step by step Boolean common produces bad shape on given three cylinders
DescriptionThere are three cylinders with same size which are perpendicular with each other.
1. Load the given file three_cylinder.brep there are three cylinders: cylinder1, cylinder2, cylinder3.
2. do boolean common with any two shapes: common1 = cylinder1 x cylinder2
3. do bollean common between common1 and cylinder3.

The final shape is bad from the result view.

It maybe a modeling problem or meshing problem.

Test environment is occt 7.5.0 beta.

It works well in occt 7.4.0.
Steps To Reproduce
pload MODELING VISUALIZATION

# OK
#plane p1    0    0 -200 0 0 1
#plane p2 -200    0    0 1 0 0
#plane p3    0 -200    0 0 1 0
#pcylinder c_1 p1 100 400
#pcylinder c_2 p2 100 400
#pcylinder c_3 p3 100 400

# OK
pcylinder  c_1 100 400
ttranslate c_1 0 0 -200
pcylinder  c_2 100 400
trotate    c_2 0 0 0 1 0 0 90
ttranslate c_2 0 200 0
pcylinder  c_3 100 400
trotate    c_3 0 0 0 0 1 0 90
ttranslate c_3 -200 0 0

# KO
#restore three_cylinder.brep c
#explode c So

# KO
plane p1 -200 2.22044604925033e-14 12.6935294289015 1 -1.11022302462516e-16 0
pcylinder c_1 p1 100 400
plane p2 0 0 -187.306470571099 0 0 1
pcylinder c_2 p2 100 400
plane p3 0 200 12.6935294289015 0 -1 1.11022302462516e-16
pcylinder c_3 p3 100 400

bcommon r12 c_2 c_1
bcommon r123 r12 c_3
incmesh r123 0.1
vclear
vinit View1
vdefaults -autotriang 0
vdisplay -dispMode 1 r123
TagsNo tags attached.
Test case numberbugs/modalg_7/bug31835_1,bug31835_2

Attached Files

  • three_cylinder.brep (17,130 bytes)
  • three-cylinder.jpg (54,536 bytes)
  • two-cylinder-common.jpg (51,684 bytes)
  • three-cylinder-common.jpg (43,786 bytes)
  • Clipboard01.png (42,795 bytes)
  • Clipboard02.jpg (21,660 bytes)

Activities

Vico Liang

2020-10-10 13:09

developer  

three_cylinder.brep (17,130 bytes)

Vico Liang

2020-10-10 13:10

developer  

three-cylinder.jpg (54,536 bytes)

Vico Liang

2020-10-10 13:10

developer  

two-cylinder-common.jpg (51,684 bytes)

Vico Liang

2020-10-10 13:10

developer  

three-cylinder-common.jpg (43,786 bytes)

msv

2020-10-12 09:30

developer   ~0095882

Dear Vico, I checked this test on OCCT 7.4.0. It works the same as in 7.5.0beta. Here is the draw script:
restore three_cylinder.brep a
explode a
bcommon r1 a_1 a_2
puts [checkshape r1]
bcommon r r1 a_3
puts [checkshape r]
incmesh r 0.1
tricheck r


Here is the output:
This shape seems to be valid
This shape seems to be valid
cross face errors: {face1, node1, face2, node2, distance} {6 1 12 1 132.74946253594433} {7 1 12 1 106.25607663447413} {7 4 12 4 132.74946253594433} {10 1 12 1 106.25607663447413}
free nodes (in pairs: face / node):
{12 2} {12 3} {12 4} {12 5} {12 6} {12 7} {12 8} {12 9} {12 10} {12 11} {12 12} {12 13} {12 14} {12 15} {12 16} {12 17} {12 18} {12 19} {12 20} {12 21} {12 22} {12 23} {12 24} {12 25} {12 26} {12 27} {12 28} {12 29} {12 30} {12 31} {12 32} {12 33} {12 34} {12 35} {12 36}
Free_links 0 Cross_face_errors 4 Async_edges 0 Free_nodes 35 Small triangles 0


So, it is not a regression issue.

msv

2020-10-12 09:36

developer   ~0095883

The script gives no error in the version 7.3.0. However, the visual look of the result is incorrect, too. See the picture Clipboard01.png.

msv

2020-10-12 09:36

developer  

Clipboard01.png (42,795 bytes)

Vico Liang

2020-10-12 15:21

developer   ~0095888

The visual look of the result is correct in version 7.4.0, but incorrect in 7.5.0 beta. anyway, this is a bug, right?

msv

2020-10-12 15:28

developer   ~0095889

Yes, this is a bug. But on my computer (win64, msvc 2015) the bug is the same on 7.4.0. If it was a regression it would require its urgent fix before issuing the release 7.5.0.

msv

2020-10-12 15:31

developer  

Clipboard02.jpg (21,660 bytes)

msv

2020-10-12 15:32

developer   ~0095890

I have attached the picture Clipboard02.png with the visual result on 7.4.0.

msv

2020-10-13 09:46

developer   ~0095916

Dear Vico, on which platform it works well on 7.4.0?

Vico Liang

2020-10-13 11:10

developer   ~0095923

Dear msv, I'm running on my desktop with msvc 2017.

msv

2020-10-13 12:20

developer   ~0095926

Could you provide the extract of code that calls the operation?

git

2020-10-13 14:30

administrator   ~0095930

Branch CR31835 has been created by emv.

SHA-1: f7dbcf7512e2a3f4220b433913f2f96581219e1b


Detailed log of new commits:

Author: emv
Date: Tue Oct 13 14:31:27 2020 +0300

    0031835: Modeling Algorithms - step by step Boolean common produces bad shape on given three cylinders
    
    Fix inconsistency between IntAna_QuadQuadGeo(gp_Cylinder,gp_Cylinder) and AxeOperator::Coplanar().

emv

2020-10-13 14:35

developer   ~0095931

I've checked the result in OCCT 7.4.0 built with VS2017, it is similar to the one built with OCCT 7.5.0_beta. The case is not a regression.

git

2020-10-13 14:59

administrator   ~0095933

Branch CR31835 has been updated forcibly by emv.

SHA-1: c5779392f6d3138fa443695fd99cf4590b30b6a4

Vico Liang

2020-10-13 17:30

developer   ~0095940

Code snippet:
    BRepAlgoAPI_Common aCommonAlgoAPI;
    aCommonAlgoAPI.SetArguments(aArgumentShapes);
    aCommonAlgoAPI.SetTools(aToolShapes);
    aCommonAlgoAPI.SetFuzzyValue(1e-6);
    aCommonAlgoAPI.SetRunParallel(Standard_True);
    aCommonAlgoAPI.SetNonDestructive(Standard_True);
    aCommonAlgoAPI.SetToFillHistory(Standard_False);
    aCommonAlgoAPI.Build();

git

2020-10-13 21:35

administrator   ~0095945

Branch CR31835 has been updated forcibly by emv.

SHA-1: df4f95f132b3192eef399285f93b97b4a2044915

emv

2020-10-14 09:29

developer   ~0095949

Dear Mikhail, could you please review the git branch CR31835?
Test results - http://jenkins-test-12.nnov.opencascade.com/view/CR31835-master-emv/view/COMPARE/

msv

2020-10-14 10:48

developer   ~0095954

For integration:
occt - CR31835
products - none

bugmaster

2020-10-17 13:22

administrator   ~0096033

Combination -
OCCT branch : IR-2020-10-16
master SHA - ae9f4b64cacf0df612944b3694a3bdfa5f1f29cf
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-10-16 SHA - fcb5abe005e152f7f923f4cf6c02acb07c027cdc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18027.820000000127 / 18057.130000000117 [-0.16%]
Products
Total CPU difference: 12174.330000000093 / 12182.170000000115 [-0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 19740.03125 / 19746.828125 [-0.03%]
Products
Total CPU difference: 13564.71875 / 13586.625 [-0.16%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2020-10-24 12:41

administrator   ~0096225

Branch CR31835 has been deleted by inv.

SHA-1: df4f95f132b3192eef399285f93b97b4a2044915

Related Changesets

occt: master 135c2bd9

2020-10-13 11:31:27

emv


Committer: bugmaster Details Diff		 0031835: Modeling Algorithms - step by step Boolean common produces bad shape on given three cylinders

Fix inconsistency between IntAna_QuadQuadGeo(gp_Cylinder,gp_Cylinder) and AxeOperator::Coplanar().		 Affected Issues
0031835
mod - src/IntAna/IntAna_QuadQuadGeo.cxx Diff File
add - tests/bugs/modalg_7/bug31835_1 Diff File
add - tests/bugs/modalg_7/bug31835_2 Diff File

Issue History

Date Modified Username Field Change
2020-10-10 13:09 Vico Liang New Issue
2020-10-10 13:09 Vico Liang Assigned To => msv
2020-10-10 13:09 Vico Liang File Added: three_cylinder.brep
2020-10-10 13:10 Vico Liang File Added: three-cylinder.jpg
2020-10-10 13:10 Vico Liang File Added: two-cylinder-common.jpg
2020-10-10 13:10 Vico Liang File Added: three-cylinder-common.jpg
2020-10-10 13:13 Vico Liang Description Updated
2020-10-12 03:53 Vico Liang Severity minor => block
2020-10-12 03:53 Vico Liang Target Version 7.6.0 => 7.5.0
2020-10-12 03:53 Vico Liang Summary step by step boolean common produces bad shape on given three cylinders => regression issue: step by step boolean common produces bad shape on given three cylinders
2020-10-12 03:53 Vico Liang Description Updated
2020-10-12 09:30 msv Note Added: 0095882
2020-10-12 09:36 msv Note Added: 0095883
2020-10-12 09:36 msv File Added: Clipboard01.png
2020-10-12 15:21 Vico Liang Note Added: 0095888
2020-10-12 15:28 msv Note Added: 0095889
2020-10-12 15:31 msv File Added: Clipboard02.jpg
2020-10-12 15:32 msv Note Added: 0095890
2020-10-12 17:20 kgv Summary regression issue: step by step boolean common produces bad shape on given three cylinders => [REGRESSION] Modeling Algorithms - step by step Boolean common produces bad shape on given three cylinders
2020-10-12 17:41 kgv Steps to Reproduce Updated
2020-10-12 17:42 kgv Steps to Reproduce Updated
2020-10-13 09:46 msv Note Added: 0095916
2020-10-13 09:47 msv Assigned To msv => emv
2020-10-13 09:47 msv Status new => assigned
2020-10-13 11:10 Vico Liang Note Added: 0095923
2020-10-13 12:20 msv Note Added: 0095926
2020-10-13 14:30 git Note Added: 0095930
2020-10-13 14:35 emv Note Added: 0095931
2020-10-13 14:35 emv Summary [REGRESSION] Modeling Algorithms - step by step Boolean common produces bad shape on given three cylinders => Modeling Algorithms - step by step Boolean common produces bad shape on given three cylinders
2020-10-13 14:35 emv Steps to Reproduce Updated
2020-10-13 14:59 git Note Added: 0095933
2020-10-13 17:30 Vico Liang Note Added: 0095940
2020-10-13 21:35 git Note Added: 0095945
2020-10-14 09:29 emv Note Added: 0095949
2020-10-14 09:29 emv Assigned To emv => msv
2020-10-14 09:29 emv Status assigned => resolved
2020-10-14 10:48 msv Note Added: 0095954
2020-10-14 10:48 msv Assigned To msv => bugmaster
2020-10-14 10:48 msv Status resolved => reviewed
2020-10-17 13:22 bugmaster Note Added: 0096033
2020-10-17 13:22 bugmaster Status reviewed => tested
2020-10-17 13:29 bugmaster Test case number => bugs/modalg_7/bug31835_1,bug31835_2
2020-10-17 13:31 bugmaster Changeset attached => occt master 135c2bd9
2020-10-17 13:31 bugmaster Status tested => verified
2020-10-17 13:31 bugmaster Resolution open => fixed
2020-10-24 12:41 git Note Added: 0096225
2020-12-02 16:22 emo Fixed in Version => 7.5.0
2020-12-02 17:13 emo Status verified => closed