MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031705Open CASCADE[OCCT] OCCT:Visualizationpublic2020-08-11 09:422020-11-26 17:20
Reporterkgv 
Assigned Tomkrylova 
PrioritynormalSeverityintegration request 
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0031705: Visualization - move out construction of predefined markers from OpenGl_AspectsSprite to Graphic3d_MarkerImage
DescriptionCurrently, the logic defining standard marker images is built in into OpenGl_AspectsSprite. This is suboptimal location of this logic, as it prevents reusing definitions across different graphic drivers.

Therefore, it is proposed moving definition to Graphic3d_MarkerImage class (an interface to be defined).
Steps To ReproduceNot required
TagsNo tags attached.
Test case number
Attached Files

- Relationships
related to 0031704resolvedosa Visualization - add an interactive object AIS_LightSource representing a light source 
child of 0030631newkgv Visualization - Vulkan graphic driver prototype 

-  Notes
(0096595)
git (administrator)
2020-11-06 15:56

Branch CR31705_6 has been created by mkrylova.

SHA-1: 9df5ab1ed76a7ff0087e1fb687f123879d59e674


Detailed log of new commits:

Author: mkrylova
Date: Tue Sep 8 17:50:28 2020 +0300

    0031704: Visualization - add an interactive object AIS_LightSource representing a light source
    
    - Added new class AIS_LightSource - object representing a light source
    - Represented position, name, direction, Cut-off range and spot light source cone shape
    - Assigned Local Transformation to interactive object
    - Updated function vlight with opportunities of presentation via AIS_LightSource tools
    - Added ability to turn on/off light
    - Added Transformation-persistence mode
(0096613)
git (administrator)
2020-11-09 11:34

Branch CR31705_6 has been updated forcibly by mkrylova.

SHA-1: 25272fa4bd0288b8feca924ad7a75ca9124c4d02
(0096615)
git (administrator)
2020-11-09 11:57

Branch CR31705_6 has been deleted by mkrylova.

SHA-1: 25272fa4bd0288b8feca924ad7a75ca9124c4d02
(0096917)
git (administrator)
2020-11-20 15:09

Branch CR31705 has been created by mkrylova.

SHA-1: 70f5ceb85fda1cb5a5e3023767df61be6d0dcf06


Detailed log of new commits:

Author: mkrylova
Date: Fri Nov 20 15:10:23 2020 +0300

    0031705: Visualization - move out construction of predefined markers from OpenGl_AspectsSprite to Graphic3d_MarkerImage
    
    - moved default markers and functions GetTextureImage and GetMarkerBitMapParam from OpenGl_AspectsSprite to Graphic3d_MarkerImage
(0097070)
git (administrator)
2020-11-25 15:44

Branch CR31705 has been updated forcibly by mkrylova.

SHA-1: c4cb1181316844266c306f0e232660ee689926e8
(0097071)
git (administrator)
2020-11-25 15:45

Branch CR31705_1 has been created by mkrylova.

SHA-1: 915c6d7e1f1a6dcb47859e9199c87b0c5bc7bd75


Detailed log of new commits:

Author: mkrylova
Date: Fri Nov 20 15:10:23 2020 +0300

    0031705: Visualization - move out construction of predefined markers from OpenGl_AspectsSprite to Graphic3d_MarkerImage
    
    - moved default markers and functions GetTextureImage and GetMarkerBitMapParam from OpenGl_AspectsSprite to Graphic3d_MarkerImage
(0097076)
kgv (developer)
2020-11-25 17:52

Please make sure that the following test cases pass testing and show no image difference comparing to current master:
> testgrid bugs vis bug23654_MarkersRecompute,bug24131_markers_bitmap,bug24131_markers_core,bug24131_markers_glsl,bug24131_markers_sprites

+  Standard_EXPORT static Handle(Image_PixMap) MergeImages (
...
+  Standard_EXPORT static void GetMarkerBitMapParam (const Aspect_TypeOfMarker theMarkerType,

MergeImages() and GetMarkerBitMapParam() are internal details - there is no need making them public.

+  switch (theMarkerType)
+  {
+  case Aspect_TOM_O_POINT:
+  {

Please fix indentation - cases in switch should be indented.

+}
\ No newline at end of file

Please keep empty line at end of file.
(0097094)
git (administrator)
2020-11-26 14:00

Branch CR31705_1 has been updated by mkrylova.

SHA-1: 1fa975019b4dc861fff706a8b55482a9a9deca0a


Detailed log of new commits:

Author: mkrylova
Date: Thu Nov 26 14:02:20 2020 +0300

    kgv remarks:
    - fixed mistakes with BitMap values
    - fixed code style

(0097095)
git (administrator)
2020-11-26 14:37

Branch CR31705_1 has been updated by mkrylova.

SHA-1: 87025d4bc61f05bdbbbecda11caabf4cd9dcdf73


Detailed log of new commits:

Author: mkrylova
Date: Thu Nov 26 14:36:41 2020 +0300

    kgv remarks:
    - moved functions MergeImages and GetMarkerBitMapParam to anonymous namespace

(0097099)
git (administrator)
2020-11-26 17:18

Branch CR31705_1 has been updated by mkrylova.

SHA-1: a1cb5c72f7db818b615f5478034c1acf7f122898


Detailed log of new commits:

Author: mkrylova
Date: Thu Nov 26 16:44:06 2020 +0300

    - fixed displaying of complex textures

(0097100)
git (administrator)
2020-11-26 17:20

Branch CR31705_2 has been created by mkrylova.

SHA-1: 2bb615b9391e72fc0df6f5fa3a4c3462e9495ca8


Detailed log of new commits:

Author: mkrylova
Date: Fri Nov 20 15:10:23 2020 +0300

    0031705: Visualization - move out construction of predefined markers from OpenGl_AspectsSprite to Graphic3d_MarkerImage
    
    - moved default markers and functions GetTextureImage and GetMarkerBitMapParam from OpenGl_AspectsSprite to Graphic3d_MarkerImage

- Issue History
Date Modified Username Field Change
2020-08-11 09:42 kgv New Issue
2020-08-11 09:42 kgv Assigned To => kgv
2020-08-11 09:42 kgv Assigned To kgv => mkrylova
2020-08-11 09:42 kgv Status new => assigned
2020-08-11 09:42 kgv Relationship added related to 0031704
2020-08-11 09:43 kgv Relationship added child of 0030631
2020-09-21 17:42 kgv Target Version 7.5.0 => 7.6.0*
2020-11-06 15:56 git Note Added: 0096595
2020-11-09 11:34 git Note Added: 0096613
2020-11-09 11:57 git Note Added: 0096615
2020-11-20 15:09 git Note Added: 0096917
2020-11-25 15:44 git Note Added: 0097070
2020-11-25 15:45 git Note Added: 0097071
2020-11-25 15:46 mkrylova Assigned To mkrylova => osa
2020-11-25 15:46 mkrylova Status assigned => resolved
2020-11-25 15:46 mkrylova Steps to Reproduce Updated View Revisions
2020-11-25 17:52 kgv Note Added: 0097076
2020-11-25 17:52 kgv Assigned To osa => mkrylova
2020-11-25 17:52 kgv Status resolved => assigned
2020-11-26 14:00 git Note Added: 0097094
2020-11-26 14:37 git Note Added: 0097095
2020-11-26 17:18 git Note Added: 0097099
2020-11-26 17:20 git Note Added: 0097100


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker