MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031690Community[OCCT] OCCT:Application Frameworkpublic2020-07-27 11:432020-07-27 12:13
ReporterBenjaminBihler 
Assigned Toakaftasev 
PrioritynormalSeverityminor 
StatusassignedResolutionopen 
PlatformAOSLOS VersionL
Product Version 
Target Version[OCCT] 7.5.0*Fixed in Version 
Summary0031690: Application Framework - Default Arguments for Document Opening Lead to Segmentation Faults
DescriptionWith commit 6d8f9f4a49bbe113c47c9fff37d8984c5c516508 the signature of TDocStd_Application::Open(...) has changed. It takes now a handle to a Message_ProgressIndicator which is by default initialized to be a null handle.

I consider this a bad design, because BinLDrivers_DocumentRetrievalDriver::Read accesses this progress indicator without performing a null handle check. Old code that is not passing a valid progress indicator will therefore crash because of a segmentation fault.

My proposal would be to add null handle checks everywhere or remove the default argument.

(Please not that the same issue is most probably also true for the Save(...) methods.)
TagsNo tags attached.
Test case number
Attached Files

- Relationships
child of 0031353verifiedbugmaster Open CASCADE TDocStd_Application does not have api to set progress indicator. 

-  Notes
(0093371)
msv (developer)
2020-07-27 12:13

Andrey, please take care of this issue. I think it will be solved along with 25748.

- Issue History
Date Modified Username Field Change
2020-07-27 11:43 BenjaminBihler New Issue
2020-07-27 11:43 BenjaminBihler Assigned To => mpv
2020-07-27 11:43 BenjaminBihler Relationship added child of 0031353
2020-07-27 12:13 msv Note Added: 0093371
2020-07-27 12:13 msv Assigned To mpv => akaftasev
2020-07-27 12:13 msv Status new => assigned


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker