| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0031690 | Community | [OCCT] OCCT:Application Framework | public | 2020-07-27 11:43 | 2020-07-27 12:13 |
|
| Reporter | BenjaminBihler | |
| Assigned To | akaftasev | |
| Priority | normal | Severity | minor | |
| Status | assigned | Resolution | open | |
| Platform | A | OS | L | OS Version | L |
| Product Version | | |
| Target Version | [OCCT] 7.5.0* | Fixed in Version | | |
|
| Summary | 0031690: Application Framework - Default Arguments for Document Opening Lead to Segmentation Faults |
| Description | With commit 6d8f9f4a49bbe113c47c9fff37d8984c5c516508 the signature of TDocStd_Application::Open(...) has changed. It takes now a handle to a Message_ProgressIndicator which is by default initialized to be a null handle.
I consider this a bad design, because BinLDrivers_DocumentRetrievalDriver::Read accesses this progress indicator without performing a null handle check. Old code that is not passing a valid progress indicator will therefore crash because of a segmentation fault.
My proposal would be to add null handle checks everywhere or remove the default argument.
(Please not that the same issue is most probably also true for the Save(...) methods.) |
| Tags | No tags attached. |
|
| Test case number | |
|
| Attached Files | |
|
Relationships 
Relationships 