View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031690CommunityOCCT:Application Frameworkpublic2020-07-27 11:432020-12-02 17:13
ReporterBenjaminBihler Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031690: Application Framework - Default Arguments for Document Opening Lead to Segmentation Faults
DescriptionWith commit 6d8f9f4a49bbe113c47c9fff37d8984c5c516508 the signature of TDocStd_Application::Open(...) has changed. It takes now a handle to a Message_ProgressIndicator which is by default initialized to be a null handle.

I consider this a bad design, because BinLDrivers_DocumentRetrievalDriver::Read accesses this progress indicator without performing a null handle check. Old code that is not passing a valid progress indicator will therefore crash because of a segmentation fault.

My proposal would be to add null handle checks everywhere or remove the default argument.

(Please not that the same issue is most probably also true for the Save(...) methods.)
TagsNo tags attached.
Test case numberNot required

Relationships

child of 0031353 closedbugmaster Open CASCADE TDocStd_Application does not have api to set progress indicator. 

Activities

msv

2020-07-27 12:13

developer   ~0093371

Andrey, please take care of this issue. I think it will be solved along with 25748.

msv

2020-09-15 15:42

developer   ~0094845

This bug can be closed, as the patch for 0025748 has been integrated and it solves this issue.

Issue History

Date Modified Username Field Change
2020-07-27 11:43 BenjaminBihler New Issue
2020-07-27 11:43 BenjaminBihler Assigned To => mpv
2020-07-27 11:43 BenjaminBihler Relationship added child of 0031353
2020-07-27 12:13 msv Note Added: 0093371
2020-07-27 12:13 msv Assigned To mpv => akaftasev
2020-07-27 12:13 msv Status new => assigned
2020-09-11 15:32 utverdov Target Version 7.5.0 => 7.6.0
2020-09-15 15:42 msv Note Added: 0094845
2020-09-15 15:43 msv Assigned To akaftasev => bugmaster
2020-09-15 15:43 msv Status assigned => feedback
2020-09-15 15:43 msv Target Version 7.6.0 => 7.5.0
2020-09-15 15:57 bugmaster Status feedback => verified
2020-09-15 15:57 bugmaster Resolution open => fixed
2020-09-20 11:01 bugmaster Test case number => Not required
2020-12-02 16:43 emo Fixed in Version => 7.5.0
2020-12-02 17:13 emo Status verified => closed