View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031658Open CASCADEOCCT:Inspectorspublic2020-07-06 19:392020-12-02 17:13
Reporternds Assigned Tobugmaster  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031658: Inspector - using AIS_ViewController in View package
DescriptionReplace mouse actions processing by connection to AIS_ViewController.
TagsNo tags attached.
Test case numberNot required

Activities

git

2020-09-08 13:46

administrator   ~0094248

Branch CR31658 has been created by nds.

SHA-1: 2cca154b94141003006aeb7a36573cbc768e84f9


Detailed log of new commits:

Author: nds
Date: Mon Jul 6 19:41:36 2020 +0300

    0031658: Inspector - using AIS_ViewController in View package
    
    - View: using AIS_ViewController, AIS_ViewCube.

git

2020-09-08 16:49

administrator   ~0094258

Branch CR31658 has been updated forcibly by nds.

SHA-1: 7a83f533695fcad26d71fbe43e193eaaa998e8a3

nds

2020-09-08 17:51

developer   ~0094261

Dear Kirill

could you please check the patch.

Thank you a lot, Natalia

kgv

2020-09-09 20:55

developer   ~0094321 

+    myController->HandleViewEvents (myViewer->GetContext(), myViewer->GetView());
+    myController->FlushViewEvents (myViewer->GetContext(), myViewer->GetView(), Standard_True);

It looks strange calling HandleViewEvents() before FlushViewEvents() considering that FlushViewEvents() with flag TRUE calls HandleViewEvents() internally.
Is there some reason for that?

+private:
+  //! Converts Qt modifier key to Aspect key flag
+  //! \param theModifierId the event modifier
+  static Standard_EXPORT Aspect_VKeyFlags keyFlag (const int theModifierId);
+
+  //! Converts Qt button key to Aspect key mouse
+  //! \param theButtonId the event button
+  static Standard_EXPORT Aspect_VKeyMouse keyMouse (const int theButtonId);

Redundant Standard_EXPORT for private methods unused in header file.

   Handle(AIS_Trihedron) myDefaultTrihedron; //!< NULL presentation until the first display
+  Handle(AIS_ViewCube) myViewCube; //!< NULL presentation until the first display

Please consider making description of these two fields more meaningful.

git

2020-09-10 06:38

administrator   ~0094335

Branch CR31658 has been updated by nds.

SHA-1: bfb85e1a76b8e633a9faf010267b0991a5e66298


Detailed log of new commits:

Author: nds
Date: Thu Sep 10 06:41:26 2020 +0300

    remarks correction

git

2020-09-10 06:43

administrator   ~0094336

Branch CR31658_1 has been created by nds.

SHA-1: a69ad0f369a35cf4dffb28a9cf6ca821b8bcbd0b


Detailed log of new commits:

Author: nds
Date: Thu Sep 10 06:46:26 2020 +0300

    0031658: Inspector - using AIS_ViewController in View package
    
    - View: using AIS_ViewController, AIS_ViewCube.

nds

2020-09-10 09:41

developer   ~0094348

Dear Kirill,
could you please review it again.
Jenkins job: http://jenkins-test-12.nnov.opencascade.com/view/CR31658-master-nds/

Thank for your help, Natalia

kgv

2020-09-10 09:44

developer   ~0094349

Please raise the patch
- OCCT branch: CR31658_1.

bugmaster

2020-09-13 11:04

administrator   ~0094538

Combination -
OCCT branch : IR-2020-09-11
master SHA - d1b25684e9402d995dafec22fb98f83957d5fb76
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-09-11 SHA - a7e55a291cf6642cb4af945a999deeeb5f91272a
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17333.360000000142 / 17325.800000000123 [+0.04%]
Products
Total CPU difference: 12056.720000000096 / 12079.64000000011 [-0.19%]
Windows-64-VC14:
OCCT
Total CPU difference: 18817.921875 / 18792.46875 [+0.14%]
Products
Total CPU difference: 13294.09375 / 13274.75 [+0.15%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2020-09-13 11:45

administrator   ~0094579

Branch CR31658_1 has been deleted by inv.

SHA-1: a69ad0f369a35cf4dffb28a9cf6ca821b8bcbd0b

git

2020-09-13 11:46

administrator   ~0094580

Branch CR31658 has been deleted by inv.

SHA-1: bfb85e1a76b8e633a9faf010267b0991a5e66298

Related Changesets

occt: master ed753e10

2020-09-10 03:46:26

nds


Committer: bugmaster Details Diff		 0031658: Inspector - using AIS_ViewController in View package

- View: using AIS_ViewController, AIS_ViewCube.		 Affected Issues
0031658
mod - tools/DFBrowser/DFBrowser_Window.cxx Diff File
mod - tools/ShapeView/ShapeView_Window.cxx Diff File
rm - tools/View/icons/cursor_rotate.png Diff File
rm - tools/View/icons/cursor_zoom.png Diff File
add - tools/View/icons/view_cube.png Diff File
rm - tools/View/icons/view_fitarea.png Diff File
rm - tools/View/icons/view_pan.png Diff File
rm - tools/View/icons/view_rotate.png Diff File
rm - tools/View/icons/view_zoom.png Diff File
mod - tools/View/View.qrc Diff File
mod - tools/View/View_Displayer.cxx Diff File
mod - tools/View/View_Displayer.hxx Diff File
mod - tools/View/View_ToolActionType.hxx Diff File
mod - tools/View/View_ToolBar.cxx Diff File
mod - tools/View/View_ViewActionType.hxx Diff File
mod - tools/View/View_Widget.cxx Diff File
mod - tools/View/View_Widget.hxx Diff File
mod - tools/View/View_Window.cxx Diff File
mod - tools/View/View_Window.hxx Diff File
mod - tools/VInspector/VInspector_Window.cxx Diff File

Issue History

Date Modified Username Field Change
2020-07-06 19:39 nds New Issue
2020-07-06 19:39 nds Assigned To => nds
2020-09-08 13:46 git Note Added: 0094248
2020-09-08 16:49 git Note Added: 0094258
2020-09-08 17:51 nds Note Added: 0094261
2020-09-08 17:51 nds Assigned To nds => kgv
2020-09-08 17:51 nds Status new => resolved
2020-09-09 20:55 kgv Note Added: 0094321
2020-09-09 20:55 kgv Assigned To kgv => nds
2020-09-09 20:55 kgv Status resolved => assigned
2020-09-10 06:38 git Note Added: 0094335
2020-09-10 06:43 git Note Added: 0094336
2020-09-10 09:41 nds Note Added: 0094348
2020-09-10 09:41 nds Assigned To nds => kgv
2020-09-10 09:41 nds Status assigned => resolved
2020-09-10 09:44 kgv Note Added: 0094349
2020-09-10 09:44 kgv Assigned To kgv => bugmaster
2020-09-10 09:44 kgv Status resolved => reviewed
2020-09-13 11:04 bugmaster Note Added: 0094538
2020-09-13 11:04 bugmaster Status reviewed => tested
2020-09-13 11:13 bugmaster Test case number => Not required
2020-09-13 11:24 bugmaster Changeset attached => occt master ed753e10
2020-09-13 11:24 bugmaster Status tested => verified
2020-09-13 11:24 bugmaster Resolution open => fixed
2020-09-13 11:45 git Note Added: 0094579
2020-09-13 11:46 git Note Added: 0094580
2020-12-02 16:43 emo Fixed in Version => 7.5.0
2020-12-02 17:13 emo Status verified => closed