MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031644Open CASCADE[OCCT] OCCT:Visualizationpublic2020-07-02 10:292020-10-28 08:10
Reporterkgv 
Assigned Tokgv 
PrioritynormalSeverityfeature 
StatusfeedbackResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0031644: Visualization - flat skin for AIS_Manipulator presentation
DescriptionCurrently AIS_Manipulator supports only one presentation with thick arrows.
In some applications another skin might be preferred - with thin arrow-less axes.
Steps To ReproduceNot required
TagsNo tags attached.
Test case number
Attached Filespng file icon cadrays_manipulator.png (317,844 bytes) 2020-07-02 10:29
png file icon cadass_manipulator.png (67,016 bytes) 2020-07-02 10:31
png file icon cadrays_manipulator_rotate.png (240,940 bytes) 2020-09-30 10:36
png file icon manipulator.PNG (12,162 bytes) 2020-10-23 16:17

- Relationships

-  Notes
(0095460)
git (administrator)
2020-09-29 12:15

Branch CR31644 has been created by mzernova.

SHA-1: 5ecd8d958fb4c5c50ef8bd35a40e0b61faef7297


Detailed log of new commits:

Author: mzernova
Date: Fri Sep 25 17:53:09 2020 +0300

    0031644: Visualization - flat skin for AIS_Manipulator presentation
    
    Created flat skin for AIS_Manipulator presentation
    Added "-flat" option to vmanipulator command
    
    v3d/manipulator/flat: test case added
(0095465)
git (administrator)
2020-09-29 15:34

Branch CR31644 has been updated by mzernova.

SHA-1: 31a81e4a2b9dc3fd51a8c0607c57521e550457ea


Detailed log of new commits:

Author: mzernova
Date: Tue Sep 29 15:36:04 2020 +0300

    remarks from kgv

(0095466)
git (administrator)
2020-09-29 15:34

Branch CR31644_1 has been created by mzernova.

SHA-1: 616cb48acd855f171fab2786d410b67b74a2a558


Detailed log of new commits:

Author: mzernova
Date: Fri Sep 25 17:53:09 2020 +0300

    0031644: Visualization - flat skin for AIS_Manipulator presentation
    
    Created flat skin for AIS_Manipulator presentation
    Added "-flat" option to vmanipulator command
    
    v3d/manipulator/flat: test case added
(0095467)
mzernova (developer)
2020-09-29 15:35

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31644-master-mzernova/ [^]
(0095468)
mzernova (developer)
2020-09-29 15:35

The patch CR31644_1 is ready to review
(0095469)
kgv (developer)
2020-09-29 15:45

 
+  enum AIS_SkinMode
+  {
+    AIS_SM_Shaded,
+    AIS_SM_Flat
+  };

Please don't shortcut names in enum values and remove AIS_ prefix for enumeration declared in scope of a class.
ManipulatorSkin_Shaded, ManipulatorSkin_Flat.

+               const AIS_SkinMode theSkinMode = AIS_SM_Shaded,

I'm not sure it makes sense defining a default value for an internal class method.

+++ b/tests/v3d/manipulator/flat

Please attach screenshots to the bug.
(0095481)
git (administrator)
2020-09-30 10:19

Branch CR31644 has been updated by mzernova.

SHA-1: c7271c940349c6d62d225271ce30ec30dce9caa8


Detailed log of new commits:

Author: mzernova
Date: Wed Sep 30 10:21:41 2020 +0300

    remarks from kgv

(0095482)
git (administrator)
2020-09-30 10:20

Branch CR31644_1 has been updated forcibly by mzernova.

SHA-1: 9d77b286a4cde2b915a107d8a4bc278f5c4e770f
(0095483)
kgv (developer)
2020-09-30 10:36

I also don't see a "flat" skin for rotation mode of manipulator on screenshots.
(0096174)
git (administrator)
2020-10-23 15:25

Branch CR31644 has been updated forcibly by mzernova.

SHA-1: 9cc4eb28e6671f1a9afc42cb71d47d9ee28bbc71
(0096175)
git (administrator)
2020-10-23 15:25

Branch CR31644_1 has been updated forcibly by mzernova.

SHA-1: 3fb7f6481652d3b3be15ab9972f979fabf75f232
(0096322)
kgv (developer)
2020-10-28 08:10

Marina, could you please put a description of this issue to Bugtracker?

- A textual description of new skin - presentation and interaction aspects implemented by the patch;
- A list of the features present in referred CADRays application but not (yet) implemented;
- Mechanics implemented in the patch for handling camera rotation-dependent updates.

- Issue History
Date Modified Username Field Change
2020-07-02 10:29 kgv New Issue
2020-07-02 10:29 kgv Assigned To => kgv
2020-07-02 10:29 kgv File Added: cadrays_manipulator.png
2020-07-02 10:29 kgv Relationship added child of 0030002
2020-07-02 10:30 kgv Assigned To kgv => mzernova
2020-07-02 10:30 kgv Status new => assigned
2020-07-02 10:30 kgv Summary Visualization - provide flat skip for AIS_Manipulator presentation => Visualization - flat skin for AIS_Manipulator presentation
2020-07-02 10:31 kgv File Added: cadass_manipulator.png
2020-09-21 17:42 kgv Target Version 7.5.0 => 7.6.0*
2020-09-29 12:15 git Note Added: 0095460
2020-09-29 15:34 git Note Added: 0095465
2020-09-29 15:34 git Note Added: 0095466
2020-09-29 15:35 mzernova Note Added: 0095467
2020-09-29 15:35 mzernova Note Added: 0095468
2020-09-29 15:35 mzernova Assigned To mzernova => kgv
2020-09-29 15:35 mzernova Status assigned => resolved
2020-09-29 15:35 mzernova Steps to Reproduce Updated View Revisions
2020-09-29 15:45 kgv Note Added: 0095469
2020-09-29 15:46 kgv Assigned To kgv => mzernova
2020-09-29 15:46 kgv Status resolved => assigned
2020-09-29 16:01 mzernova File Added: flat_1.png
2020-09-29 16:01 mzernova File Added: flat_2.png
2020-09-29 16:02 mzernova File Added: flat_3.png
2020-09-29 16:02 mzernova File Added: flat.png
2020-09-30 10:19 git Note Added: 0095481
2020-09-30 10:20 git Note Added: 0095482
2020-09-30 10:36 kgv File Added: cadrays_manipulator_rotate.png
2020-09-30 10:36 kgv Note Added: 0095483
2020-10-23 15:25 git Note Added: 0096174
2020-10-23 15:25 git Note Added: 0096175
2020-10-23 15:48 mzernova Assigned To mzernova => kgv
2020-10-23 15:48 mzernova Status assigned => feedback
2020-10-23 16:17 mzernova File Added: manipulator.PNG
2020-10-23 16:17 mzernova File Deleted: flat.png
2020-10-23 16:17 mzernova File Deleted: flat_1.png
2020-10-23 16:17 mzernova File Deleted: flat_2.png
2020-10-23 16:17 mzernova File Deleted: flat_3.png
2020-10-28 08:10 kgv Note Added: 0096322


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker