View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031622Open CASCADEOCCT:Samplespublic2020-06-20 22:532020-12-02 17:13
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version7.4.0 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031622: Samples - update MFC Animation sample with proper frame updates
DescriptionMFC Animation sample in current state demonstrates broken animation logic - it ignores real elapsed time and blocks 3D viewer interactions.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot required

Relationships

related to 0028087 newbugmaster OCCT Samples Redesign 
child of 0030507 closedbugmaster Visualization - introduce AIS_ViewController 
child of 0027764 closedapn Visualization - add functionality for animation of 3D camera and interactive objects 

Activities

git

2020-06-20 22:58

administrator   ~0092627

Branch CR31622 has been created by kgv.

SHA-1: b6492c7e11614682e5b832577ed71c1b4e1de731


Detailed log of new commits:

Author: kgv
Date: Sat Jun 20 23:00:17 2020 +0300

    0031622: Samples - update MFC Animation sample with proper frame updates
    
    Animation sample has been updated to:
    - use reuse AIS_ViewController for general viewer manipulations;
    - update animation using elapsed time;
    - do not block camera manipilations;
    - get rid of redundant controls.

kgv

2020-06-20 23:32

developer   ~0092628

Patch is ready for review in OCCT branch CR31622.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31622-master-KGV/view/SAMPLES/

nds

2020-06-22 14:24

developer   ~0092652

Please, avoid adding additional levels in code:

void CAnimationView3D::update3dView()
{
  if (!myView.IsNull())
  {
    if (++myUpdateRequests == 1)
    {
      Invalidate (FALSE);
      UpdateWindow();
    }
  }
}

git

2020-06-22 15:29

administrator   ~0092659

Branch CR31622 has been updated forcibly by kgv.

SHA-1: 933ddb06b00874056c5bb400a2eb9cf5d876c0d7

kgv

2020-06-22 15:29

developer   ~0092660

Remark has been applied.

bugmaster

2020-06-28 11:28

administrator   ~0092793

Combination -
OCCT branch : IR-2020-06-26
master SHA - 832a6f4412321ca784bbb36916dc740d04a05c0c
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-06-26 SHA - 180ab3ca4e501bda3da57c99a8ac8b220db33df3
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17164.36000000016 / 17160.400000000114 [+0.02%]
Products
Total CPU difference: 11173.720000000081 / 11197.400000000112 [-0.21%]
Windows-64-VC14:
OCCT
Total CPU difference: 18707.65625 / 18650.578125 [+0.31%]
Products
Total CPU difference: 13062.6875 / 13012.71875 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2020-06-28 12:48

administrator   ~0092807

Branch CR31622 has been deleted by inv.

SHA-1: 933ddb06b00874056c5bb400a2eb9cf5d876c0d7

Related Changesets

occt: master 64f128c1

2020-06-20 20:00:17

kgv


Committer: bugmaster Details Diff		 0031622: Samples - update MFC Animation sample with proper frame updates

Animation sample has been updated to:
- use reuse AIS_ViewController for general viewer manipulations;
- update animation using elapsed time;
- do not block camera manipilations;
- get rid of redundant controls.		 Affected Issues
0031622
mod - samples/mfc/standard/09_Animation/adm/win/vc10/Animation.vcxproj Diff File
mod - samples/mfc/standard/09_Animation/adm/win/vc10/Animation.vcxproj.filters Diff File
mod - samples/mfc/standard/09_Animation/CMakeLists.txt Diff File
mod - samples/mfc/standard/09_Animation/res/Animation.rc Diff File
mod - samples/mfc/standard/09_Animation/src/AnimationDoc.cpp Diff File
mod - samples/mfc/standard/09_Animation/src/AnimationDoc.h Diff File
mod - samples/mfc/standard/09_Animation/src/AnimationView3D.cpp Diff File
mod - samples/mfc/standard/09_Animation/src/AnimationView3D.h Diff File
rm - samples/mfc/standard/09_Animation/src/Sensitivity.cpp Diff File
rm - samples/mfc/standard/09_Animation/src/Sensitivity.h Diff File
rm - samples/mfc/standard/09_Animation/src/Tune.cpp Diff File
rm - samples/mfc/standard/09_Animation/src/Tune.h Diff File

Issue History

Date Modified Username Field Change
2020-06-20 22:53 kgv New Issue
2020-06-20 22:53 kgv Assigned To => kgv
2020-06-20 22:53 kgv Severity feature => minor
2020-06-20 22:53 kgv Product Version => 7.4.0
2020-06-20 22:58 git Note Added: 0092627
2020-06-20 23:00 kgv Relationship added child of 0030507
2020-06-20 23:01 kgv Relationship added child of 0027764
2020-06-20 23:32 kgv Note Added: 0092628
2020-06-20 23:32 kgv Assigned To kgv => nds
2020-06-20 23:32 kgv Status new => resolved
2020-06-22 14:24 nds Note Added: 0092652
2020-06-22 14:24 nds Assigned To nds => kgv
2020-06-22 14:24 nds Status resolved => assigned
2020-06-22 15:29 git Note Added: 0092659
2020-06-22 15:29 kgv Note Added: 0092660
2020-06-22 15:29 kgv Assigned To kgv => nds
2020-06-22 15:29 kgv Status assigned => resolved
2020-06-22 16:04 nds Assigned To nds => bugmaster
2020-06-22 16:04 nds Status resolved => reviewed
2020-06-25 22:43 kgv Relationship added related to 0028087
2020-06-28 11:28 bugmaster Note Added: 0092793
2020-06-28 11:28 bugmaster Status reviewed => tested
2020-06-28 11:34 bugmaster Test case number => Not required
2020-06-28 12:35 bugmaster Changeset attached => occt master 64f128c1
2020-06-28 12:35 bugmaster Status tested => verified
2020-06-28 12:35 bugmaster Resolution open => fixed
2020-06-28 12:48 git Note Added: 0092807
2020-12-02 16:43 emo Fixed in Version => 7.5.0
2020-12-02 17:13 emo Status verified => closed