View Issue Details

IDProjectCategoryView StatusLast Update
0031502Open CASCADEOCCT:Codingpublic2020-12-02 17:12
Reporterbugmaster Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformALL 
Product Version7.5.0 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031502: Coding - New warnings after integration fix for 0031456
DescriptionJenkins warning parser did not take into account "Warning." case.
So warnings touched with moving includes from AIS to PrsDim package without changing prefix AIS_ was not caught.

-- Warning. C:/builds/WEEK-15/Windows-64-VC14-opt/OCCT/inc/AIS_AngleDimension.hxx is not present in the sources and will be removed from C:/builds/WEEK-15/Windows-64-VC14-opt/OCCT/inc
-- Warning. C:/builds/WEEK-15/Windows-64-VC14-opt/OCCT/inc/AIS_Chamf2dDimension.hxx is not present in the sources and will be removed from C:/builds/WEEK-15/Windows-64-VC14-opt/OCCT/inc
-- Warning. C:/builds/WEEK-15/Windows-64-VC14-opt/OCCT/inc/AIS_Chamf3dDimension.hxx is not present in the sources and will be removed from C:/builds/WEEK-15/Windows-64-VC14-opt/OCCT/inc
......
TagsNo tags attached.
Test case numberNot required

Relationships

child of 0031456 closedbugmaster Visualization - move out Dimensions and Relations from package AIS to PrsDims 

Activities

bugmaster

2020-04-16 12:56

administrator   ~0091588

It it normal?

kgv

2020-04-16 13:04

developer   ~0091589

Last edited: 2020-04-16 13:05

I guess it is because of 0031456 puts into PrsDim package AIS headers-aliases for smooth porting of existing code.

Normally, such headers should lie in AIS package, but due to enormous amount of them, I've decided putting them into PrsDim package to clean up AIS from confusing stuff.

genproj.tcl checks the whole list of headers within osutils:collectinc tool, so that it doesn't remove such headers.
CMake script COLLECT_AND_INSTALL_OCCT_HEADER_FILES within occt_resources.cmake is different - it weeds out Package name from header file and checks that header file lies exactly within FILE of the same Package. Which is "smarter", but leads to this issue.

So there are two possibilities:
- Change COLLECT_AND_INSTALL_OCCT_HEADER_FILES to follow genproj.tcl behavior.
- Move AIS headers from PrsDim to AIS.

Although existing CMake approach looks smarter, I'm not sure there is necessity to keep it.

abv

2020-04-16 16:43

manager   ~0091597

I propose moving the offending headers back to AIS, to keep the rule of putting each header in the same-named package

git

2020-04-16 16:50

administrator   ~0091598

Branch CR31502 has been created by kgv.

SHA-1: bfb1fd616a9eefc28679c841df5385105e887256


Detailed log of new commits:

Author: kgv
Date: Thu Apr 16 16:51:31 2020 +0300

    0031502: Coding - New warnings after integration fix for 0031456
    
    Deprecated AIS class aliases have been moved from PrsDim to AIS package.

kgv

2020-04-16 16:51

developer   ~0091599

Please check for warnings patch in OCCT branch CR31502.

bugmaster

2020-04-17 14:09

administrator   ~0091640

http://jenkins-test-12.nnov.opencascade.com/view/CR31502-master-inv/view/COMPARE/

There are no more warnings above

kgv

2020-04-17 14:26

developer   ~0091642

Please integrate.

git

2020-04-18 15:28

administrator   ~0091649

Branch CR31502 has been deleted by inv.

SHA-1: bfb1fd616a9eefc28679c841df5385105e887256

Related Changesets

occt: master b8a00b41

2020-04-16 13:51:31

kgv


Committer: bugmaster Details Diff
0031502: Coding - New warnings after integration fix for 0031456

Deprecated AIS class aliases have been moved from PrsDim to AIS package.
Affected Issues
0031502
mod - src/AIS/FILES Diff File
mod - src/PrsDim/FILES Diff File

Issue History

Date Modified Username Field Change
2020-04-16 12:38 bugmaster New Issue
2020-04-16 12:38 bugmaster Assigned To => bugmaster
2020-04-16 12:40 bugmaster Description Updated
2020-04-16 12:41 kgv Relationship added child of 0031456
2020-04-16 12:42 kgv Product Version => 7.5.0
2020-04-16 12:47 bugmaster Description Updated
2020-04-16 12:54 bugmaster Description Updated
2020-04-16 12:54 bugmaster Assigned To bugmaster => kgv
2020-04-16 12:56 bugmaster Note Added: 0091588
2020-04-16 13:04 kgv Note Added: 0091589
2020-04-16 13:04 kgv Note Edited: 0091589
2020-04-16 13:04 kgv Note Edited: 0091589
2020-04-16 13:05 kgv Note Edited: 0091589
2020-04-16 13:05 kgv Note Edited: 0091589
2020-04-16 16:43 abv Note Added: 0091597
2020-04-16 16:50 git Note Added: 0091598
2020-04-16 16:51 kgv Note Added: 0091599
2020-04-16 16:51 kgv Assigned To kgv => bugmaster
2020-04-16 16:51 kgv Status new => feedback
2020-04-17 14:08 bugmaster Assigned To bugmaster => kgv
2020-04-17 14:08 bugmaster Status feedback => resolved
2020-04-17 14:08 bugmaster Steps to Reproduce Updated
2020-04-17 14:08 bugmaster Steps to Reproduce Updated
2020-04-17 14:09 bugmaster Note Added: 0091640
2020-04-17 14:26 kgv Note Added: 0091642
2020-04-17 14:26 kgv Assigned To kgv => bugmaster
2020-04-17 14:26 kgv Status resolved => reviewed
2020-04-18 15:09 bugmaster Test case number => Not required
2020-04-18 15:10 bugmaster Status reviewed => tested
2020-04-18 15:13 bugmaster Changeset attached => occt master b8a00b41
2020-04-18 15:13 bugmaster Status tested => verified
2020-04-18 15:13 bugmaster Resolution open => fixed
2020-04-18 15:28 git Note Added: 0091649
2020-12-02 16:43 emo Fixed in Version => 7.5.0
2020-12-02 17:12 emo Status verified => closed