View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031457 | Open CASCADE | OCCT:Visualization | public | 2020-03-21 20:12 | 2024-01-12 21:49 |
| Reporter | nds | Assigned To | |||
| Priority | normal | Severity | integration request | ||
| Status | assigned | Resolution | open | ||
| Target Version | Unscheduled | ||||
| Summary | 0031457: Visualization, TKOpenGl - interface to find an active frame buffer | ||||
| Description | OpenGl_FrameBuffer has a functionality to bind/unbind itself into context. If we have some buffer in the context before Bind and want to restore it after Unbind, we need to get it. It's proposed to add this interface into OpenGl_Context. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR31457 has been created by nds. SHA-1: 4d21b76dbad8c16dd0b4c51da09bd7b0cb45df79 Detailed log of new commits: Author: nds Date: Sat Mar 21 20:13:55 2020 +0300 0031457: Visualization - interface to find an active frame buffer |
|
|
Branch CR31457 has been updated forcibly by nds. SHA-1: 2b0f19182b04dcb37a749a33ad472a4eab900bf0 |
|
|
Dear Kirill, could you please review. Jenkins job is: http://jenkins-test-12.nnov.opencascade.com/view/CR31457-master-nds/ Thank you in advance, Natalia |
|
|
It is expected introduced API to be used in existing occurrences using GL_FRAMEBUFFER_BINDING as work-around - e.g. VolumeRender and PrsPointCloud packages (OCC Products), which apart from removing workaround would allow testing new patch.+ Standard_EXPORT void SetActiveFrameBuffer (const Handle(OpenGl_FrameBuffer)& theFbo) Redundant Standard_EXPORT.
--- a/src/OpenGl/OpenGl_FrameBuffer.cxx
+++ b/src/OpenGl/OpenGl_FrameBuffer.cxx
@@ -692,6 +692,8 @@ void OpenGl_FrameBuffer::BindBuffer (const Handle(OpenGl_Context)& theGlCtx)
{
theGlCtx->arbFBO->glBindFramebuffer (GL_FRAMEBUFFER, myGlFBufferId);
theGlCtx->SetFrameBufferSRGB (true);
+
+ theGlCtx->SetActiveFrameBuffer (this)
This doesn't handle BindDrawBuffer(), BindReadBuffer() and > aCtx->arbFBO->glBindFramebuffer(GL_DRAW_FRAMEBUFFER, OpenGl_FrameBuffer::NO_FRAMEBUFFER); used in OCCT. |
|
|
Branch CR31457 has been updated forcibly by nds. SHA-1: bf5b2a475323b2c14043fcaa11f56599fb35136e |
|
|
Branch CR31457_1 has been created by nds. SHA-1: 1f7f051ed48a1d2bae9f2b77ac8df898f4b97e8e Detailed log of new commits: Author: nds Date: Mon Sep 7 20:47:21 2020 +0300 0031457: Visualization - interface to find an active frame buffer |
|
|
Dear Kirill, I've tried to implement patch on OCCT and product as recommended. But tests have failed. Could you please have a look at proposed patch (on both) and lead what's wrong from your point of view. I've prepared two jobs on jenkins(sorry for confusing names) (<OCCT> to <Products> branches): - job for 'CR31457_1' to 'CR31457_1': http://jenkins-test-12.nnov.opencascade.com/view/CR31457-master-nds/ - job for 'CR31457_1' to 'master': http://jenkins-test-12.nnov.opencascade.com/view/CR31457_1-master-nds/ As you see, the first job(required) has failed. If this patch needs to be enriched a lot, isn't it worth to postpone it to 7.6? Thank you for help, Natalia |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-03-21 20:12 | nds | New Issue | |
| 2020-03-21 20:12 | nds | Assigned To | => nds |
| 2020-03-27 09:31 | kgv | Summary | Visualization - interface to find an active frame buffer => Visualization, OpenGl_Context - interface to find an active frame buffer |
| 2020-03-27 09:31 | kgv | Summary | Visualization, OpenGl_Context - interface to find an active frame buffer => Visualization, TKOpenGl - interface to find an active frame buffer |
| 2020-04-11 10:16 | git | Note Added: 0091507 | |
| 2020-09-04 09:24 | git | Note Added: 0094007 | |
| 2020-09-04 11:43 | nds | Assigned To | nds => kgv |
| 2020-09-04 11:43 | nds | Severity | minor => integration request |
| 2020-09-04 11:43 | nds | Status | new => resolved |
| 2020-09-05 09:24 | nds | Note Added: 0094041 | |
| 2020-09-06 12:09 | kgv | Note Added: 0094167 | |
| 2020-09-06 12:09 | kgv | Assigned To | kgv => nds |
| 2020-09-06 12:09 | kgv | Status | resolved => assigned |
| 2020-09-07 20:42 | git | Note Added: 0094212 | |
| 2020-09-07 20:44 | git | Note Added: 0094213 | |
| 2020-09-08 12:56 | nds | Note Added: 0094243 | |
| 2020-09-08 12:56 | nds | Assigned To | nds => kgv |
| 2020-09-21 17:46 | kgv | Target Version | 7.5.0 => 7.6.0 |
| 2021-08-24 14:26 | kgv | Target Version | 7.6.0 => 7.7.0 |
| 2022-08-17 11:55 | kgv | Target Version | 7.7.0 => 7.8.0 |
| 2022-10-19 15:49 |
|
Assigned To | kgv => vpozdyayev |
| 2023-08-01 15:09 | dpasukhi | Target Version | 7.8.0 => Unscheduled |
