View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031411 | Open CASCADE | OCCT:Application Framework | public | 2020-03-05 19:58 | 2020-05-04 09:18 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | major | ||
| Status | closed | Resolution | unable to reproduce | ||
| Product Version | 7.4.0 | ||||
| Target Version | 7.5.0 | ||||
| Summary | 0031411: Application Framework - Undo buffer is limitless in TDocStd_Document | ||||
| Description | If one sets the limit for the undo buffer of TDocStd_Document object via calling TDocStd_Document::SetUndoLimit() method the passed value is not taken into account and the undo buffer stays limitless. It is because the line myUndos.RemoveFirst(); in TDocStd_Document::CommitTransaction() method is disabled from the compilation by the macro SRN_DELTA_COMPACT that is simply defined at the beginning of TDocStd_Document.cxx source file. | ||||
| Steps To Reproduce | This issue is not reproducible. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
I can not reproduce this problem. SetUndoLimit works correctly and TDocStd_Document::CommitTransaction() works fine. The following test script in Draw may be used to check it: pload ALL NewDocument D BinOcaf UndoLimit D 3 NewCommand D Label D 0:1 SetReal D 0:1 1.1 NewCommand D SetReal D 0:1 2.2 NewCommand D SetReal D 0:1 3.3 NewCommand D SetReal D 0:1 4.4 NewCommand D SetReal D 0:1 5.5 CommitCommand D Undo D Undo D Undo D Undo D =====> Undo not done GetReal D 0:1 =====> 2.2000000000000002 Also, I found that RemoveFirst does not disabled in the CommitTransaction: ... #ifdef SRN_DELTA_COMPACT Handle(TDF_Delta) aDelta = myUndos.First(); #endif myUndos.RemoveFirst(); #ifdef SRN_DELTA_COMPACT if(myFromUndo == aDelta) { ... Dear tizmaylo, could you describe how do you reproduce the problem? |
|
|
I'm sorry, this issue is not relevant to OCCT, it was the internal problem in our project. This issue should be closed. |
|
|
Dear Bugmaster, please close this issue. Nothing to do with it. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-03-05 19:58 |
|
New Issue | |
| 2020-03-05 19:58 |
|
Assigned To | => mpv |
| 2020-03-05 20:00 |
|
Summary | Undo buffer is limitless in TDocStd_Document => Application Framework - Undo buffer is limitless in TDocStd_Document |
| 2020-03-05 20:01 |
|
Description Updated | |
| 2020-04-21 16:29 |
|
Note Added: 0091706 | |
| 2020-04-21 16:30 |
|
Assigned To | mpv => tizmaylo |
| 2020-04-21 16:31 |
|
Status | new => feedback |
| 2020-04-21 18:59 |
|
Note Added: 0091707 | |
| 2020-04-21 19:01 |
|
Assigned To | tizmaylo => mpv |
| 2020-04-21 19:01 |
|
Status | feedback => resolved |
| 2020-04-21 19:01 |
|
Steps to Reproduce Updated | |
| 2020-04-22 09:14 |
|
Assigned To | mpv => bugmaster |
| 2020-04-22 09:15 |
|
Note Added: 0091710 | |
| 2020-05-04 09:18 |
|
Status | resolved => closed |
| 2020-05-04 09:18 |
|
Resolution | open => unable to reproduce |
