MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031362Open CASCADE[OCCT] OCCT:Inspectorspublic2020-02-09 10:212021-05-14 20:41
Reporternds 
Assigned Tobugmaster 
PrioritynormalSeverityfeature 
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.6.0*Fixed in Version 
Summary0031362: Inspectors - MessageView plugin for message alerts
DescriptionImplement plugin in Inspector to visualize content of Message_Report.
TagsNo tags attached.
Test case number
Attached Files

- Relationships
related to 0029451closedbugmaster Open CASCADE Information Message Alert to debug an algorithm or object functionality 

-  Notes
(0100476)
git (administrator)
2021-04-20 13:03

Branch CR31362_1 has been created by nds.

SHA-1: d733e9f919ed3dd145640f222d80a4013a6d42ba


Detailed log of new commits:

Author: nds
Date: Tue Apr 20 13:03:15 2021 +0300

    dfbrowser: dumpjson possibility by state

Author: nds
Date: Tue Oct 27 19:24:59 2020 +0300

    0031362: Inspectors - MessageView plugin for message alerts
    
    - OSD_Timer in message alert,
    - DumpJson correction,
    - Selection owner should be dumped in selector. Sensitive entities might be used in the same owner, that leads to lots of the same dump in the result stream.
    - Inspector tools improvements
    - 0031959: Inspectors - Statistics by name,
    - 0032068: Inspectors - Last command don't have the time value
    
    (cherry picked from commit 0728c3d864a4a8c22d2c4f11238c21b0f3c27580)
    (cherry picked from commit 4aeded6f5b770ea3c2e5c673e9127220624bde03)
(0100478)
git (administrator)
2021-04-20 13:32

Branch CR31362_1 has been deleted by nds.

SHA-1: d733e9f919ed3dd145640f222d80a4013a6d42ba
(0100632)
git (administrator)
2021-04-28 10:32

Branch CR31362_2 has been created by nds.

SHA-1: f1a9967fc1f27e52a08f2c5cc02d210a013b2952


Detailed log of new commits:

Author: nds
Date: Mon Apr 26 18:01:38 2021 +0300

    0031362: Inspectors - MessageView plugin for message alerts
    
    - append new MessageView plugin to display content of Message_Report;
    
    - correct DumpJson of TDataStd array attributes to print Lower/Upper values;
    - correct remove level of Message_Report to store stop time during removing all levels;
    - append DumpJson for TFunction, TPrsStd attributes;
    - correct DumpJson of XCAFDoc tools due to simplify performance of it;
    - move AttributeInfo into public method to call it outside;
    - remove obsolete pane classes in DFBrowser plugin, now we may use DumpJSon panel to visualize this content of attributes;
    - add new property panel in DFBrowser (synchronized with the same in other plugins);
    - add button to switch ON DumpJson in DFBrowser(OFF by default, for better performance), also there is a context menu item in tree view;
    - rename in DFBrowser "Property Panel" into "Property Panel (custom)";
    - implement ViewControl_ColorSeletor and setting color in TreeModel_ItemProperties. Use only for light in VInspector now;
    - implement setting false for all created AIS_Shape presentation to don't modify source TopoDS_Shape;
    - remove not use VInspector_CallBack. It's possible using Message_Report/MessageView to track commands way;
    - remove History panel in VInspector as not used, MessageView will be better solution for this;
    - implement item and actions in VInspector for setting Lights in the view.
(0100633)
nds (developer)
2021-04-28 10:34

Dear Kirill,

could you please, review.

Best regards, Natalia
(0100653)
git (administrator)
2021-04-29 11:01

Branch CR31362_2 has been updated forcibly by nds.

SHA-1: 3be1ba6131d3dbf8630ecb0ee6ca62df0e449b19
(0100665)
kgv (developer)
2021-04-29 14:25

+    di << anInfo.ToCString();
...
+      anInfo += TCollection_AsciiString (" ==> ") + ref.ToCString();
...
+    anInfo += TCollection_AsciiString ( myCentroid.X() ).ToCString();

Redundant .ToCString() in several places within this function.

+      anInfo += TCollection_AsciiString ( "," );

These TCollection_AsciiString() looks redundant too, but I guess they are used for consistency.

+  Standard_EXPORT static TCollection_AsciiString AttributeInfo (Handle(TDF_Attribute) att);

const Handle(TDF_Attribute)& theAtt

+  Standard_EXPORT static void CreatePresentation (const Handle(Geom_Line)& theLine,
+    NCollection_List<Handle(Standard_Transient)>& thePresentations);

Is it intended design, or maybe replacing NCollection_List<Handle(Standard_Transient)> with NCollection_List<Handle(AIS_InteractiveObject)>?

+  //! \param thePresentations container to collect new presentation/s

Misprint in "presentation/s".

--- /dev/null
+++ b/tools/VInspector/VInspector_PresentationLight.hxx

If this tool is really necessary (e.g. AIS_LightSource is not suitable for some reason), could you please move this feature to a dedicated patch?
And it would be helpful to document the difference from AIS class in VInspector_PresentationLight description to avoid confusion.

--- a/tools/TKDFBrowser/EXTERNLIB
+++ b/tools/TKDFBrowser/EXTERNLIB
@@ -24,4 +24,5 @@ TKV3d
 TKTInspectorAPI
 TKTreeModel
 TKShapeView
+TKXDEDRAW

This might be fine, but introducing DFBrowser dependency from Draw Harness might imply undesired side effects (like crashes somewhere in tcl.dll on application exit reported by some users) in applications not initializing Tcl interpretor, but depending on TKDraw/tcl libraries with their global variables.
It might be reasonable moving XDEDRAW::AttributeInfo() to some location not in Draw Harness.
(0100925)
git (administrator)
2021-05-12 21:19

Branch CR31362_2 has been updated by nds.

SHA-1: 371330aa97a4f6a787216f9033c76b24580da176


Detailed log of new commits:

Author: nds
Date: Wed May 12 21:20:33 2021 +0300

    fix for warnings on Debian

Author: nds
Date: Wed May 12 21:15:16 2021 +0300

    moving AttributeInfo from XDEDRAW to XCAFDoc.

Author: nds
Date: Wed May 12 19:57:20 2021 +0300

    fix for remarks

(0100926)
git (administrator)
2021-05-12 21:24

Branch CR31362_2 has been updated forcibly by nds.

SHA-1: a37e2cb670c551ad17d541b8162f42e10cb2bd84
(0100927)
git (administrator)
2021-05-12 21:38

Branch CR31362_3 has been created by nds.

SHA-1: d5a5516c4e528cdceedebebae8835386de9f1dea


Detailed log of new commits:

Author: nds
Date: Mon Apr 26 18:01:38 2021 +0300

    0031362: Inspectors - MessageView plugin for message alerts
    
    - append new MessageView plugin to display content of Message_Report;
    
    - correct DumpJson of TDataStd array attributes to print Lower/Upper values;
    - correct remove level of Message_Report to store stop time during removing all levels;
    - append DumpJson for TFunction, TPrsStd attributes;
    - correct DumpJson of XCAFDoc tools due to simplify performance of it;
    - move AttributeInfo functionality from XDEDRAW into a static public method of XCAFDoc to call it outside;
    - remove obsolete pane classes in DFBrowser plugin, now we may use DumpJSon panel to visualize this content of attributes;
    - add new property panel in DFBrowser (synchronized with the same in other plugins);
    - add button to switch ON DumpJson in DFBrowser(OFF by default, for better performance), also there is a context menu item in tree view;
    - rename in DFBrowser "Property Panel" into "Property Panel (custom)";
    - implement ViewControl_ColorSeletor and setting color in TreeModel_ItemProperties. Use only for light in VInspector now;
    - implement setting false for all created AIS_Shape presentation to don't modify source TopoDS_Shape;
    - remove not use VInspector_CallBack. It's possible using Message_Report/MessageView to track commands way;
    - remove History panel in VInspector as not used, MessageView will be better solution for this;
    - implement item and actions in VInspector for setting Lights in the view.
(0100929)
git (administrator)
2021-05-13 10:12

Branch CR31362_3 has been updated forcibly by nds.

SHA-1: 9cdd1c996abda61a3515406b7ed8a7ee1aa3357f
(0100930)
nds (developer)
2021-05-13 10:26

Dear Kirill,
remarks are corrected. Additional information:
- implementation of 'AttributeInfo' is moved into XCAFDoc (so, we needn't link in TKDFBrowser to TKDraw;
- 'Is it intended design... using Standard_Transient, not AIS_InteractiveObject'? Yes, firstly, it allows to avoid depending on uplevel V3d library (in TreeModel), secondly, any other Handle might be placed in Standard_Transient and later covered by e.g. AIS_InteractiveObject. It might be for example Convert_TransientShape, that covers TopoDS_Shape.
- modifications related to VInspector_PresentationLight is removed. AIS_LightSource also is not used now in Inspector.

Please, review it once again,
Jenkins job is: http://jenkins-test-occt.nnov.opencascade.com/view/CR31362-master-nds/view/ALL/ [^]

Thank you for help, Natalia
(0101006)
bugmaster (administrator)
2021-05-14 20:41

Assigning to NDS. Get results of compilation

- Issue History
Date Modified Username Field Change
2020-02-09 10:21 nds New Issue
2020-02-09 10:21 nds Assigned To => nds
2020-02-09 10:24 nds Relationship added related to 0029451
2020-09-25 02:02 nds Target Version 7.5.0 => 7.6.0*
2020-11-25 15:45 sshutina Relationship added related to 0031959
2021-04-20 13:03 git Note Added: 0100476
2021-04-20 13:32 git Note Added: 0100478
2021-04-23 17:05 nds File Added: light_positional_1.png
2021-04-23 17:05 nds File Added: light_positional_2.png
2021-04-23 17:06 nds File Added: light_draw_script_1.png
2021-04-23 17:06 nds File Added: light_draw_script_2.png
2021-04-23 17:07 nds File Added: light_draw_script_3.png
2021-04-23 17:07 nds File Deleted: light_positional_2.png
2021-04-23 17:07 nds File Deleted: light_positional_1.png
2021-04-23 17:07 nds File Deleted: light_draw_script_1.png
2021-04-23 17:07 nds File Deleted: light_draw_script_2.png
2021-04-23 17:07 nds File Deleted: light_draw_script_3.png
2021-04-28 10:32 git Note Added: 0100632
2021-04-28 10:34 nds Note Added: 0100633
2021-04-28 10:34 nds Assigned To nds => kgv
2021-04-28 10:34 nds Status new => resolved
2021-04-29 11:01 git Note Added: 0100653
2021-04-29 14:25 kgv Note Added: 0100665
2021-04-29 14:25 kgv Assigned To kgv => nds
2021-04-29 14:25 kgv Status resolved => assigned
2021-05-12 21:19 git Note Added: 0100925
2021-05-12 21:24 git Note Added: 0100926
2021-05-12 21:38 git Note Added: 0100927
2021-05-13 10:12 git Note Added: 0100929
2021-05-13 10:26 nds Note Added: 0100930
2021-05-13 10:26 nds Assigned To nds => kgv
2021-05-13 10:26 nds Status assigned => resolved
2021-05-13 20:56 kgv Assigned To kgv => bugmaster
2021-05-13 20:56 kgv Status resolved => reviewed
2021-05-14 20:41 bugmaster Note Added: 0101006
2021-05-14 20:41 bugmaster Status reviewed => assigned


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker