MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031322Open CASCADE[OCCT] OCCT:Visualizationpublic2020-01-28 07:532020-02-01 21:50
Reporternds 
Assigned Tobugmaster 
PrioritynormalSeverityminor 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version[OCCT] 6.9.0 
Target Version[OCCT] 7.5.0*Fixed in Version 
Summary0031322: Visualization, Select3D_SensitiveEntity - method NbSubElements() should be const
DescriptionIt's proposed to add key 'const' into NbSubElements() of the class as should not change fields of the instance, just get.
TagsNo tags attached.
Test case numberNot required
Attached Files

- Relationships
child of 0031313verifiedbugmaster Foundation Classes - Dump improvement for classes 
child of 0024623closedbugmaster Visualization - improve selection mechanism 

-  Notes
(0090095)
git (administrator)
2020-01-28 12:26

Branch CR31322 has been created by nds.

SHA-1: 4a70ba62b48574ad80bb0310b8f3d3c8c47e88b0


Detailed log of new commits:

Author: nds
Date: Tue Jan 28 12:23:13 2020 +0300

    0031322: Visualization - Select3D_SensitiveEntity set const for NbSubElements
    
    Set constant state for the method NbSubElement to be able to call it from other constant methods (e.g. DumpJson of Select3D_SensitiveEntity)
(0090175)
git (administrator)
2020-01-30 01:54

Branch CR31322_1 has been created by nds.

SHA-1: 6f2991a7ed25867613ad3ebbb0edb6783507e48a


Detailed log of new commits:

Author: nds
Date: Tue Jan 28 12:23:13 2020 +0300

    0031322: Visualization - Select3D_SensitiveEntity set const for NbSubElements
    
    Set constant state for the method NbSubElement to be able to call it from other constant methods (e.g. DumpJson of Select3D_SensitiveEntity)
(0090189)
git (administrator)
2020-01-30 08:46

Branch CR31322 has been deleted by nds.

SHA-1: 4a70ba62b48574ad80bb0310b8f3d3c8c47e88b0
(0090192)
nds (developer)
2020-01-30 09:34

Dear Kirill,

could you please review patch.
Jenkins job: http://jenkins-test-12.nnov.opencascade.com/view/CR31322-master-NDS/ [^]
please, note that patch is based on fix for 31313.

Thank you in advance, Natalia
(0090195)
git (administrator)
2020-01-30 10:52

Branch CR31322_2 has been created by kgv.

SHA-1: 4fe717a08604de146322e2e61c55b2f23d13975e


Detailed log of new commits:

Author: nds
Date: Thu Jan 30 10:47:55 2020 +0300

    0031322: Visualization, Select3D_SensitiveEntity - method NbSubElements() should be const
    
    Set constant state for the method NbSubElement to be able to call it from other constant methods (e.g. DumpJson of Select3D_SensitiveEntity).
(0090196)
kgv (developer)
2020-01-30 10:53

Please raise the patch.
(0090241)
bugmaster (administrator)
2020-01-31 17:47

Combination -
OCCT branch : CR30904_3
master SHA - 858b15f93f68d9e8605b2940f9b200691f438cf1
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : master SHA - 78d1418219e11e1effe871d7f2886b736d7b8bdf
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17054.310000000023 / 17032.770000000073 [+0.13%]
Products
Total CPU difference: 12142.140000000081 / 12148.700000000104 [-0.05%]
Windows-64-VC14:
OCCT
---
Products
Total CPU difference: 14190.84375 / 14126.28125 [+0.46%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0090260)
git (administrator)
2020-02-01 21:47

Branch CR31322_2 has been deleted by inv.

SHA-1: 4fe717a08604de146322e2e61c55b2f23d13975e
(0090261)
git (administrator)
2020-02-01 21:47

Branch CR31322_1 has been deleted by inv.

SHA-1: 6f2991a7ed25867613ad3ebbb0edb6783507e48a

- Related Changesets
occt: master fe758dbe
Timestamp: 2020-01-30 07:47:55
Author: nds
Committer: bugmaster
Details ] Diff ]
0031322: Visualization, Select3D_SensitiveEntity - method NbSubElements() should be const

Set constant state for the method NbSubElement to be able to call it from other constant methods (e.g. DumpJson of Select3D_SensitiveEntity).
mod - dox/dev_guides/upgrade/upgrade.md Diff ] File ]
mod - src/MeshVS/MeshVS_CommonSensitiveEntity.cxx Diff ] File ]
mod - src/MeshVS/MeshVS_CommonSensitiveEntity.hxx Diff ] File ]
mod - src/MeshVS/MeshVS_DummySensitiveEntity.cxx Diff ] File ]
mod - src/MeshVS/MeshVS_DummySensitiveEntity.hxx Diff ] File ]
mod - src/MeshVS/MeshVS_SensitiveMesh.cxx Diff ] File ]
mod - src/MeshVS/MeshVS_SensitiveMesh.hxx Diff ] File ]
mod - src/MeshVS/MeshVS_SensitivePolyhedron.cxx Diff ] File ]
mod - src/MeshVS/MeshVS_SensitivePolyhedron.hxx Diff ] File ]
mod - src/MeshVS/MeshVS_SensitiveQuad.hxx Diff ] File ]
mod - src/Select3D/Select3D_InteriorSensitivePointSet.cxx Diff ] File ]
mod - src/Select3D/Select3D_InteriorSensitivePointSet.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveBox.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveBox.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveEntity.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveFace.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveFace.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveGroup.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveGroup.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitivePoint.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitivePoint.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitivePoly.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitivePoly.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitivePrimitiveArray.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveSegment.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveSegment.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveTriangle.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveTriangulation.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveTriangulation.hxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveWire.cxx Diff ] File ]
mod - src/Select3D/Select3D_SensitiveWire.hxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2020-01-28 07:53 nds New Issue
2020-01-28 07:53 nds Assigned To => kgv
2020-01-28 10:16 nds Assigned To kgv => nds
2020-01-28 10:19 nds Relationship added child of 0031313
2020-01-28 12:26 git Note Added: 0090095
2020-01-30 01:54 git Note Added: 0090175
2020-01-30 08:46 git Note Added: 0090189
2020-01-30 09:34 nds Note Added: 0090192
2020-01-30 09:34 nds Assigned To nds => kgv
2020-01-30 09:34 nds Status new => resolved
2020-01-30 10:45 kgv Product Version => 7.4.0
2020-01-30 10:45 kgv Summary Visualization - Select3D_SensitiveEntity set const for NbSubElements => Visualization, Select3D_SensitiveEntity - method NbSubElements() should be const
2020-01-30 10:46 kgv Relationship added child of 0024623
2020-01-30 10:46 kgv Product Version 7.4.0 => 6.9.0
2020-01-30 10:52 git Note Added: 0090195
2020-01-30 10:53 kgv Note Added: 0090196
2020-01-30 10:53 kgv Assigned To kgv => bugmaster
2020-01-30 10:53 kgv Status resolved => reviewed
2020-01-30 12:55 nds Note Added: 0090199
2020-01-30 12:59 nds Note Deleted: 0090199
2020-01-30 19:08 bugmaster Test case number => Not required
2020-01-31 17:47 bugmaster Note Added: 0090241
2020-01-31 17:47 bugmaster Status reviewed => tested
2020-02-01 21:28 bugmaster Changeset attached => occt master fe758dbe
2020-02-01 21:28 bugmaster Status tested => verified
2020-02-01 21:28 bugmaster Resolution open => fixed
2020-02-01 21:47 git Note Added: 0090260
2020-02-01 21:47 git Note Added: 0090261


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker