View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031226Open CASCADEOCCT:Foundation Classespublic2019-12-06 12:152020-12-26 14:52
ReportertizmayloAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version6.3.1 
Target Version7.6.0Fixed in Version7.6.0 
Summary0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
DescriptionThe method TCollection_AsciiString::IsRealValue() of the TCollection_AsciiString class returns true if a string contains a non-real value (e.g. "9999a9").
Steps To ReproduceNot required
TagsNo tags attached.
Test case numberNot required

Relationships

related to 0030623 closedbugmaster Draw Harness - support hex color codes within ViewerTest::ParseColor() 

Activities

abv

2019-12-13 07:10

manager   ~0089486

This is historic implementation of method TCollection_AsciiString::IsRealValue() - it always returned true if the string was started with some characters that can be interpreted as integer or real value. I propose we can document this in the comment to the method, but it is better not to change behavior as it can break some existig code. Perhaps additional Boolean argument can be added indicating the need for a strict check.

git

2020-12-14 15:18

administrator   ~0097574

Branch CR31226 has been created by mkrylova.

SHA-1: ae6b512bc2eb4cd7ec7b6fcd5273976e9a2572d9


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict check

kgv

2020-12-16 17:51

developer   ~0097647 

+  //! theToCheckFull - argument indicating the need for a strict check is the AsciiString a real value.

Please use @param syntax for documenting arguments.
> argument indicating the need for a strict check is the AsciiString a real value.
when TRUE, checks if entire string defines a real value;
otherwise checks if string starts with a real value

git

2020-12-17 13:19

administrator   ~0097674

Branch CR31226 has been updated by mkrylova.

SHA-1: 9fc09618f4b9f5debf4bc85e8775449a4ddfe8d7


Detailed log of new commits:

Author: mkrylova
Date: Thu Dec 17 13:21:18 2020 +0300

    kgv remarks:
    - changed description of TCollection_AsciiString::IsRealValue

git

2020-12-17 13:21

administrator   ~0097677

Branch CR31226_1 has been created by mkrylova.

SHA-1: f604e77134f18414cdc58a20233ddf19c63bc35f


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict check

git

2020-12-17 14:12

administrator   ~0097679

Branch CR31226_1 has been updated by mkrylova.

SHA-1: 2307a213a06b461b8a1b95742e4e606977282cfe


Detailed log of new commits:

Author: mkrylova
Date: Thu Dec 17 14:14:18 2020 +0300

    # fixed code style

git

2020-12-17 14:13

administrator   ~0097680

Branch CR31226_2 has been created by mkrylova.

SHA-1: 9af5fa9d337d43863964a57abc55b0804f3bd5fd


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict check

kgv

2020-12-17 16:07

developer   ~0097692

Last edited: 2020-12-17 16:14

 Please update existing places of IsRealValue() usage in ViewerTest to use new flag and add a test case.

kgv

2020-12-17 16:14

developer   ~0097693

There is OCC11758 command in QABugs_19.cxx which can be extended to verify IsRealValue() in unit-test alike style.

git

2020-12-18 14:24

administrator   ~0097708

Branch CR31226_2 has been updated by mkrylova.

SHA-1: e7095d340a4207acf79de9eafb6ad98a0b2ba4f2


Detailed log of new commits:

Author: mkrylova
Date: Fri Dec 18 14:26:35 2020 +0300

    # kgv remarks
     - Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
     - Updated existing places of IsRealValue() usage in ViewerTest to use new flag

git

2020-12-18 14:25

administrator   ~0097709

Branch CR31226_3 has been created by mkrylova.

SHA-1: b7305d518aed2100967240c67549d935e705749d


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict
    - Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
    - Updated existing places of IsRealValue() usage in ViewerTest to use new flag

kgv

2020-12-18 15:35

developer   ~0097715

Please fix compiler warnings:

/dn62/builds/CR31226_3-master-KGV/OCCT_SRC/src/TCollection/TCollection_AsciiString.cxx: In member function 'Standard_Boolean TCollection_AsciiString::IsRealValue(Standard_Boolean) const':
/dn62/builds/CR31226_3-master-KGV/OCCT_SRC/src/TCollection/TCollection_AsciiString.cxx:772:23: warning: NULL used in arithmetic [-Wpointer-arith]
[  2%] Building CXX object src/TKernel/CMakeFiles/TKernel.dir/__/Message/Message_Messenger.cxx.o

git

2020-12-18 16:52

administrator   ~0097723

Branch CR31226_3 has been updated by mkrylova.

SHA-1: a639c52f2d5bd3017b97db7622c53b85a3abe113


Detailed log of new commits:

Author: mkrylova
Date: Fri Dec 18 16:53:58 2020 +0300

    # replaced NULL by '\0'

git

2020-12-18 16:53

administrator   ~0097724

Branch CR31226_4 has been created by mkrylova.

SHA-1: 5f2599af2d18b1191c2d08bc8675f3ae8ddf3b73


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict
    - Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
    - Updated existing places of IsRealValue() usage in ViewerTest to use new flag

git

2020-12-18 22:13

administrator   ~0097733

Branch CR31226_4 has been updated by kgv.

SHA-1: e8d9d28a97295977d5d0f8ffe8683b48b18c68de


Detailed log of new commits:

Author: kgv
Date: Fri Dec 18 22:14:28 2020 +0300

    # fix misprint in test case

kgv

2020-12-19 03:05

developer   ~0097734

Please raise the patch
- OCCT branch: CR31226_4.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31226_4-master-KGV/

bugmaster

2020-12-26 12:14

administrator   ~0097909

Combination -
OCCT branch : WEEK-52
master SHA - 41046145c4a15f5cedf5f3c5877952ee00d568b4
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : WEEK-52 SHA - 290e5c74e8fef71947cadf90acb8e43c81ed10a1
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17722.770000000193 / 17710.950000000055 [+0.07%]
Products
Total CPU difference: 12416.490000000109 / 12412.520000000126 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19321.5625 / 19274.6875 [+0.24%]
Products
Total CPU difference: 13844.421875 / 13853.046875 [-0.06%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2020-12-26 14:52

administrator   ~0097931

Branch CR31226 has been deleted by inv.

SHA-1: 9fc09618f4b9f5debf4bc85e8775449a4ddfe8d7

git

2020-12-26 14:52

administrator   ~0097932

Branch CR31226_1 has been deleted by inv.

SHA-1: 2307a213a06b461b8a1b95742e4e606977282cfe

git

2020-12-26 14:52

administrator   ~0097933

Branch CR31226_2 has been deleted by inv.

SHA-1: e7095d340a4207acf79de9eafb6ad98a0b2ba4f2

git

2020-12-26 14:52

administrator   ~0097934

Branch CR31226_3 has been deleted by inv.

SHA-1: a639c52f2d5bd3017b97db7622c53b85a3abe113

git

2020-12-26 14:52

administrator   ~0097935

Branch CR31226_4 has been deleted by inv.

SHA-1: e8d9d28a97295977d5d0f8ffe8683b48b18c68de

Related Changesets

occt: master d45edf24

2020-12-14 12:18:43

mkrylova


Committer: bugmaster Details Diff		 0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value

- Added comment to the method
- Added Boolean argument indicating the need for a strict
- Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
- Updated existing places of IsRealValue() usage in ViewerTest to use new flag		 Affected Issues
0031226
mod - src/QABugs/QABugs_19.cxx Diff File
mod - src/TCollection/TCollection_AsciiString.cxx Diff File
mod - src/TCollection/TCollection_AsciiString.hxx Diff File
mod - src/ViewerTest/ViewerTest.cxx Diff File
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff File
mod - src/ViewerTest/ViewerTest_RelationCommands.cxx Diff File
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File
mod - tests/bugs/mesh/bug26382 Diff File

Issue History

Date Modified Username Field Change
2019-12-06 12:15 tizmaylo New Issue
2019-12-06 12:15 tizmaylo Assigned To => abv
2019-12-13 07:10 abv Note Added: 0089486
2020-09-11 16:13 utverdov Target Version 7.5.0 => 7.6.0
2020-12-14 12:43 kgv Assigned To abv => mkrylova
2020-12-14 12:43 kgv Status new => assigned
2020-12-14 15:18 git Note Added: 0097574
2020-12-16 17:23 mkrylova Assigned To mkrylova => kgv
2020-12-16 17:23 mkrylova Status assigned => resolved
2020-12-16 17:23 mkrylova Steps to Reproduce Updated
2020-12-16 17:51 kgv Note Added: 0097647
2020-12-16 17:51 kgv Assigned To kgv => mkrylova
2020-12-16 17:51 kgv Status resolved => assigned
2020-12-16 17:51 kgv Product Version => 6.3.1
2020-12-17 13:19 git Note Added: 0097674
2020-12-17 13:21 git Note Added: 0097677
2020-12-17 14:12 git Note Added: 0097679
2020-12-17 14:13 git Note Added: 0097680
2020-12-17 15:55 mkrylova Assigned To mkrylova => kgv
2020-12-17 15:55 mkrylova Status assigned => resolved
2020-12-17 16:04 kgv Relationship added related to 0030623
2020-12-17 16:07 kgv Note Added: 0097692
2020-12-17 16:07 kgv Assigned To kgv => mkrylova
2020-12-17 16:07 kgv Status resolved => assigned
2020-12-17 16:14 kgv Note Added: 0097693
2020-12-17 16:14 kgv Note Edited: 0097692
2020-12-18 14:24 git Note Added: 0097708
2020-12-18 14:25 git Note Added: 0097709
2020-12-18 14:25 mkrylova Assigned To mkrylova => kgv
2020-12-18 14:25 mkrylova Status assigned => resolved
2020-12-18 15:35 kgv Note Added: 0097715
2020-12-18 15:35 kgv Assigned To kgv => mkrylova
2020-12-18 15:35 kgv Status resolved => assigned
2020-12-18 16:52 git Note Added: 0097723
2020-12-18 16:53 git Note Added: 0097724
2020-12-18 16:54 mkrylova Assigned To mkrylova => kgv
2020-12-18 16:54 mkrylova Status assigned => resolved
2020-12-18 22:13 git Note Added: 0097733
2020-12-19 03:05 kgv Note Added: 0097734
2020-12-19 03:05 kgv Assigned To kgv => bugmaster
2020-12-19 03:05 kgv Status resolved => reviewed
2020-12-26 12:14 bugmaster Note Added: 0097909
2020-12-26 12:14 bugmaster Status reviewed => tested
2020-12-26 12:17 bugmaster Test case number => Not required
2020-12-26 14:40 bugmaster Changeset attached => occt master d45edf24
2020-12-26 14:40 bugmaster Status tested => verified
2020-12-26 14:40 bugmaster Resolution open => fixed
2020-12-26 14:52 git Note Added: 0097931
2020-12-26 14:52 git Note Added: 0097932
2020-12-26 14:52 git Note Added: 0097933
2020-12-26 14:52 git Note Added: 0097934
2020-12-26 14:52 git Note Added: 0097935