View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031219Open CASCADEOCCT:Application Frameworkpublic2019-12-04 17:092020-12-02 17:12
Reporteroan Assigned Tobugmaster  
PrioritynormalSeveritytweak 
Status closedResolutionfixed 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031219: Application Framework - TObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString
DescriptionTObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString instead of direct conversion to TCollection_HExtendedString to avoid possible problems with Unicode symbols.
Steps To ReproduceThere is not possible reproduce from Test Harness
TagsNo tags attached.
Test case numberNot required

Activities

gka

2020-09-11 15:53

developer   ~0094470

Results of tests can be found by path:
http://jenkins-test-12.nnov.opencascade.com/view/CR31452_1-master-gka/view/COMPARE/

mpv

2020-09-11 18:30

developer   ~0094506

Please, improve the creation of Handles in two last SetName methods in TObj_Object class. The first two methods take references to Handles (like the first : const Handle(TCollection_HAsciiString)& theName), so, creation of Handles "on the fly" for this argument could produce warnings or invalid memory management on some systems.

git

2020-09-11 20:50

administrator   ~0094521

Branch CR31219_1 has been created by gka.

SHA-1: 7a8ccaaa83c87dcb1ef49ba68d7a1448313bad9a


Detailed log of new commits:

Author: gka
Date: Fri Sep 11 20:52:42 2020 +0300

    0031219: TObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString
    
    In the method TObj_Object::TObj_Object::SetName(const Standard_CString theName) conversion to the HAsciiString was used instead of the conversion to the TCollection_HExtendedString.

Author: gka
Date: Mon Dec 9 14:43:47 2019 +0300

    0031219: TObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString
    
    In the method TObj_Object::TObj_Object::SetName(const Standard_CString theName) conversion to the HAsciiString was used instead of the conversion to the TCollection_HExtendedString.

git

2020-09-14 10:37

administrator   ~0094696

Branch CR31219_1 has been updated forcibly by gka.

SHA-1: f7b5e6e59d1adcd46baf58aff19725f329bfd5f8

abv

2020-09-14 11:19

manager   ~0094703

Mikhail, can you please provide example of warnings you mentioned in 0031219:0094506?

mpv

2020-09-14 11:30

developer   ~0094706

It is the same for VC9, VC10 or VC11:
Message : opencascade::handle<T>::operator opencascade::handle<T> &: Passing non-const reference to handle of base type in function is unsafe; use variable of exact type

gka

2020-09-14 13:24

developer   ~0094717

Please see results of tests by path:
http://jenkins-test-12.nnov.opencascade.com/view/CR31219_1-master-gka/view/COMPARE/

gka

2020-09-14 13:26

developer   ~0094718

Branch CR31219_1 is ready to be reviewed.

mpv

2020-09-14 15:51

developer   ~0094740

Reviewed
OCCT branch: CR31219_1
Products branch: NOTHING

git

2020-09-14 17:25

administrator   ~0094762

Branch CR31219_1 has been updated forcibly by gka.

SHA-1: 8750b000185a102a9df10cecfdf01730e3117129

gka

2020-09-14 17:30

developer   ~0094763

Branch CR31219_1 is ready to be reviewed

mpv

2020-09-14 17:50

developer   ~0094764

Reviewed

bugmaster

2020-09-19 17:24

administrator   ~0095093

Combination -
OCCT branch : IR-2020-09-18
master SHA - b0b766826118f74b9857a932b8cec8c52a25c492
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-09-18 SHA - a6486d839da1ba1383ef6cc1a1a446a172f494c7
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17528.97000000011 / 17378.390000000145 [+0.87%]
Products
Total CPU difference: 12127.32000000009 / 12079.540000000095 [+0.40%]
Windows-64-VC14:
OCCT
Total CPU difference: 18862.703125 / 18898.921875 [-0.19%]
Products
Total CPU difference: 13314.828125 / 13329.21875 [-0.11%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2020-09-20 11:14

administrator   ~0095126

Branch CR31219_1 has been deleted by inv.

SHA-1: 8750b000185a102a9df10cecfdf01730e3117129

Related Changesets

occt: master 8b77b2fc

2019-12-09 11:43:47

gka


Committer: bugmaster Details Diff		 0031219: Application Framework - TObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString

In the method TObj_Object::TObj_Object::SetName(const Standard_CString theName) conversion to the HAsciiString was used instead of the conversion to the TCollection_HExtendedString. -		 Affected Issues
0031219
mod - src/TObj/TObj_Object.cxx Diff File

Issue History

Date Modified Username Field Change
2019-12-04 17:09 oan New Issue
2019-12-04 17:09 oan Assigned To => mpv
2019-12-06 11:43 mpv Assigned To mpv => gka
2019-12-09 15:12 gka Status new => assigned
2020-09-11 15:32 utverdov Target Version 7.5.0 => 7.6.0
2020-09-11 15:53 gka Note Added: 0094470
2020-09-11 15:58 gka Assigned To gka => mpv
2020-09-11 15:58 gka Status assigned => resolved
2020-09-11 15:58 gka Steps to Reproduce Updated
2020-09-11 16:08 utverdov Target Version 7.6.0 => 7.5.0
2020-09-11 18:30 mpv Note Added: 0094506
2020-09-11 18:30 mpv Assigned To mpv => gka
2020-09-11 18:30 mpv Status resolved => assigned
2020-09-11 19:26 gka Target Version 7.5.0 => 7.6.0
2020-09-11 20:50 git Note Added: 0094521
2020-09-14 10:37 git Note Added: 0094696
2020-09-14 11:19 abv Note Added: 0094703
2020-09-14 11:30 mpv Note Added: 0094706
2020-09-14 13:24 gka Note Added: 0094717
2020-09-14 13:26 gka Note Added: 0094718
2020-09-14 13:26 gka Assigned To gka => mpv
2020-09-14 13:26 gka Status assigned => resolved
2020-09-14 15:51 mpv Note Added: 0094740
2020-09-14 15:51 mpv Assigned To mpv => bugmaster
2020-09-14 15:51 mpv Status resolved => reviewed
2020-09-14 17:25 git Note Added: 0094762
2020-09-14 17:30 gka Note Added: 0094763
2020-09-14 17:50 mpv Note Added: 0094764
2020-09-15 17:25 bugmaster Target Version 7.6.0 => 7.5.0
2020-09-18 17:42 bugmaster Summary TObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString => Application Framework - TObj_Object::SetName(const Standard_CString theName) should use conversion to TCollection_HAsciiString
2020-09-19 15:54 bugmaster Test case number => Not required
2020-09-19 17:24 bugmaster Note Added: 0095093
2020-09-19 17:24 bugmaster Status reviewed => tested
2020-09-20 10:55 bugmaster Changeset attached => occt master 8b77b2fc
2020-09-20 10:55 bugmaster Status tested => verified
2020-09-20 10:55 bugmaster Resolution open => fixed
2020-09-20 11:14 git Note Added: 0095126
2020-12-02 16:41 emo Fixed in Version => 7.5.0
2020-12-02 17:12 emo Status verified => closed