Anonymous | Login | 2019-12-07 07:07 MSK | ![]() |
My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
0031213 | Open CASCADE | [OCCT] OCCT:Coding | public | 2019-12-03 12:19 | 2019-12-06 19:15 | ||||||||
Reporter | kgv | ||||||||||||
Assigned To | bugmaster | ||||||||||||
Priority | normal | Severity | trivial | ||||||||||
Status | reviewed | Resolution | open | ||||||||||
Platform | OS | OS Version | |||||||||||
Product Version | [OCCT] 7.5.0* | ||||||||||||
Target Version | [OCCT] 7.5.0* | Fixed in Version | |||||||||||
Summary | 0031213: Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global object | ||||||||||||
Description | Variable THE_BUFFER introduced by 0030964 has wrong name as it is not constant / global:--- a/src/RWStl/RWStl_Reader.cxx +++ b/src/RWStl/RWStl_Reader.cxx + // Buffer to read + Standard_ReadLineBuffer THE_BUFFER (THE_BUFFER_SIZE); | ||||||||||||
Steps To Reproduce | Not required | ||||||||||||
Tags | No tags attached. | ||||||||||||
Test case number | Not required | ||||||||||||
Attached Files | |||||||||||||
![]() |
||||||
|
![]() |
|
(0089358) git (administrator) 2019-12-03 13:56 |
Branch CR31213 has been created by mzernova. SHA-1: 90c466dd242a4117240ed35ee00a6de3cbc89343 Detailed log of new commits: Author: mzernova Date: Tue Dec 3 13:51:02 2019 +0300 0031213: Coding Rules, RWStl_Reader - misnamed variable THE_BUFFER Renamed THE_BUFFER variable. |
(0089359) mzernova (developer) 2019-12-03 13:57 |
The patch CR31213 is ready to review |
(0089360) kgv (developer) 2019-12-03 14:46 |
36 namespace 37 { 46 // Buffer to read 47 Standard_ReadLineBuffer RWStl_myBuffer (THE_BUFFER_SIZE); This buffer should not be put into a global variable! |
(0089378) git (administrator) 2019-12-04 15:55 |
Branch CR31213 has been updated by mzernova. SHA-1: b58002c6ddb1d256924c698870a629dedf08b866 Detailed log of new commits: Author: mzernova Date: Wed Dec 4 15:48:19 2019 +0300 remarks from kgv |
(0089379) git (administrator) 2019-12-04 15:56 |
Branch CR31213_1 has been created by mzernova. SHA-1: 10e12d458a1b441e77cea3e4836201ed19a055a1 Detailed log of new commits: Author: mzernova Date: Tue Dec 3 13:51:02 2019 +0300 0031213: Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global object Variable THE_BUFFER has been renamed and moved. |
(0089380) mzernova (developer) 2019-12-04 15:57 |
The patch CR31213 is ready to review |
![]() |
|||
Date Modified | Username | Field | Change |
2019-12-03 12:19 | kgv | New Issue | |
2019-12-03 12:19 | kgv | Assigned To | => mzernova |
2019-12-03 12:19 | kgv | Relationship added | child of 0030964 |
2019-12-03 12:19 | kgv | Status | new => assigned |
2019-12-03 13:56 | git | Note Added: 0089358 | |
2019-12-03 13:57 | mzernova | Note Added: 0089359 | |
2019-12-03 13:57 | mzernova | Assigned To | mzernova => kgv |
2019-12-03 13:57 | mzernova | Status | assigned => resolved |
2019-12-03 13:57 | mzernova | Steps to Reproduce Updated | View Revisions |
2019-12-03 14:46 | kgv | Note Added: 0089360 | |
2019-12-03 14:46 | kgv | Assigned To | kgv => mzernova |
2019-12-03 14:46 | kgv | Status | resolved => assigned |
2019-12-03 15:19 | kgv | Summary | Coding Rules, RWStl_Reader - misnamed variable THE_BUFFER => Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global variable |
2019-12-03 15:19 | kgv | Summary | Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global variable => Coding Rules, RWStl_Reader - THE_BUFFER should NOT be a global object |
2019-12-04 15:55 | git | Note Added: 0089378 | |
2019-12-04 15:56 | git | Note Added: 0089379 | |
2019-12-04 15:57 | mzernova | Note Added: 0089380 | |
2019-12-04 15:57 | mzernova | Assigned To | mzernova => kgv |
2019-12-04 15:57 | mzernova | Status | assigned => resolved |
2019-12-04 16:55 | kgv | Assigned To | kgv => bugmaster |
2019-12-04 16:55 | kgv | Status | resolved => reviewed |
2019-12-06 19:15 | bugmaster | Test case number | => Not required |
Copyright © 2000 - 2019 MantisBT Team |