View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031135 | Open CASCADE | OCCT:Visualization | public | 2019-11-06 16:56 | 2020-12-02 17:12 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 7.5.0 | ||||
| Target Version | 7.5.0 | Fixed in Version | 7.5.0 | ||
| Summary | 0031135: Visualization, TKOpenGl - texture sRGB -> linear conversion is applied twice by Path Tracer | ||||
| Description | Path Tracing GLSL program has sRGB -> linear conversion code which has not been removed in scope of 0029528. | ||||
| Steps To Reproduce | test v3d raytrace sample_ball_alpha 1 vtexture ball 11 vfps | ||||
| Tags | No tags attached. | ||||
| Test case number | v3d/raytrace/sample_ball_wood | ||||
|
|
ball_wood_master_KO.png (224,187 bytes) |
|
|
ball_wood_740_OK.png (244,679 bytes) |
|
|
ball_wood_patch_OK.png (245,629 bytes) |
|
|
Branch CR31135 has been created by kgv. SHA-1: 3d6c7458d4a5a83b4f5782fa38039b0696ea37bb Detailed log of new commits: Author: kgv Date: Wed Nov 6 16:59:27 2019 +0300 0031135: Visualization, TKOpenGl - texture sRGB -> linear conversion is applied twice by Path Tracer Removed from PathtraceBase.fs redundant gamma correction applied to texture. |
|
|
Please raise the patch. |
|
|
Tested in framework of WEEK-45 Combination - OCCT branch : WEEK-45 master SHA - a1a9b249523438cf9b3d510fb4ff74bd4a5675b6 5f5b1aed1c6e139bbd34314eca77ae7abcd8895c Products branch : WEEK-45 SHA - f88bc93e3637c4c42f3c154c0b0e167d4e297ae6 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 16844.70000000007 / 16848.430000000117 [-0.02%] Products Total CPU difference: 10837.970000000065 / 10873.690000000062 [-0.33%] Windows-64-VC14: OCCT Total CPU difference: 18366.671875 / 18319.515625 [+0.26%] Products Total CPU difference: 12848.578125 / 12848.859375 [-0.00%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR31135 has been deleted by inv. SHA-1: 3d6c7458d4a5a83b4f5782fa38039b0696ea37bb |
|
occt: master a1a9b249 2019-11-06 13:59:27 Committer: bugmaster Details Diff |
0031135: Visualization, TKOpenGl - texture sRGB -> linear conversion is applied twice by Path Tracer Removed from PathtraceBase.fs redundant gamma correction applied to texture. |
Affected Issues 0031135 |
|
| mod - src/Shaders/PathtraceBase.fs | Diff File | ||
| mod - src/Shaders/Shaders_PathtraceBase_fs.pxx | Diff File | ||
| add - tests/v3d/raytrace/sample_ball_wood | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-11-06 16:56 | kgv | New Issue | |
| 2019-11-06 16:56 | kgv | Assigned To | => kgv |
| 2019-11-06 16:56 | kgv | File Added: ball_wood_master_KO.png | |
| 2019-11-06 16:57 | kgv | File Added: ball_wood_740_OK.png | |
| 2019-11-06 16:57 | kgv | File Added: ball_wood_patch_OK.png | |
| 2019-11-06 17:00 | git | Note Added: 0088753 | |
| 2019-11-06 17:02 | kgv | Relationship added | child of 0029528 |
| 2019-11-06 18:28 | kgv | Note Added: 0088755 | |
| 2019-11-06 18:28 | kgv | Assigned To | kgv => bugmaster |
| 2019-11-06 18:28 | kgv | Severity | minor => trivial |
| 2019-11-06 18:28 | kgv | Status | new => resolved |
| 2019-11-06 18:28 | kgv | Status | resolved => reviewed |
| 2019-11-07 10:48 | bugmaster | Note Added: 0088770 | |
| 2019-11-07 10:48 | bugmaster | Status | reviewed => tested |
| 2019-11-07 10:48 | bugmaster | Test case number | => v3d/raytrace/sample_ball_wood |
| 2019-11-10 11:18 | bugmaster | Changeset attached | => occt master a1a9b249 |
| 2019-11-10 11:18 | bugmaster | Status | tested => verified |
| 2019-11-10 11:18 | bugmaster | Resolution | open => fixed |
| 2019-11-10 11:41 | git | Note Added: 0088835 | |
| 2020-12-02 16:40 |
|
Fixed in Version | => 7.5.0 |
| 2020-12-02 17:12 |
|
Status | verified => closed |
