MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031096Open CASCADE[OCCT] OCCT:Visualizationpublic2019-10-23 12:242019-12-02 15:05
Reporterkgv 
Assigned Tobugmaster 
PrioritynormalSeverityfeature 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.5.0*Fixed in Version 
Summary0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping
Description0030700 introduced metallic-roughness shading model, but these material coefficients can be defined only for entire object. It is desired supporting metallic-roughness texture map.
Steps To Reproducetest de_mesh gltf_read helmet 1
TagsNo tags attached.
Test case numberNot required
Attached Filespng file icon helmet_pbr.png (118,978 bytes) 2019-11-29 17:13
png file icon helmet_pt.png (146,395 bytes) 2019-11-29 17:13
png file icon flight_helmet_occlusion_OFF.png (330,103 bytes) 2019-11-29 17:17
png file icon flight_helmet_occlusion_ON.png (336,492 bytes) 2019-11-29 17:17
png file icon flight_helmet_normal_map_OFF.png (482,223 bytes) 2019-11-29 17:19
png file icon flight_helmet_normal_map_ON.png (520,315 bytes) 2019-11-29 17:19

- Relationships
related to 0031097feedbackbugmaster Open CASCADE Visualization, TKOpenGl - support Occlusion texture mapping 
related to 0031098feedbackbugmaster Open CASCADE Visualization, TKOpenGl - support Normal texture map 
child of 0030700verifiedapn Open CASCADE Visualization, TKOpenGl - support PBR Metallic-Roughness shading model 
child of 0028912closedbugmaster Open CASCADE Visualization, TKOpenGl - multi-texture support 

-  Notes
(0088779)
git (administrator)
2019-11-07 16:56

Branch CR31096 has been created by iko.

SHA-1: a076872879a22d9b78c13c1107968b8723a21d2b


Detailed log of new commits:

Author: iko
Date: Thu Nov 7 16:52:53 2019 +0300

    # work in progress
(0088780)
git (administrator)
2019-11-07 17:23

Branch CR31096 has been updated forcibly by iko.

SHA-1: 9488c1a8d438e6f696c1eec5af644df381016c33
(0088788)
git (administrator)
2019-11-08 11:42

Branch CR31096 has been updated forcibly by iko.

SHA-1: 33936868f411c9ad8340bddd14dac16fbd098a09
(0088890)
git (administrator)
2019-11-11 13:24

Branch CR31096 has been updated forcibly by iko.

SHA-1: 0d54a65db2a4b77896e488fd16669df1ad1e7c58
(0089075)
git (administrator)
2019-11-19 17:12

Branch CR31096 has been updated forcibly by iko.

SHA-1: 2454033700c86256edfb6573ce14ac52ab30b1ab
(0089079)
git (administrator)
2019-11-19 17:26

Branch CR31096 has been updated forcibly by iko.

SHA-1: c137d1a3177d64439941aa7767e3c56d46e84b8a
(0089227)
git (administrator)
2019-11-27 19:11

Branch CR31096_1 has been created by kgv.

SHA-1: 8aa37978c0951ff7d69e3f7687b512b3b8f74cca


Detailed log of new commits:

Author: iko
Date: Thu Nov 7 16:52:53 2019 +0300

    0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping
    
    Metallic-roughness and emissive textures map have been integrated to PBR.
    Mock texture maps manager (OpenGl_PBRMockTextures) has been implemented.
    
    Normal maps has been integrated to PBR.
    Occlusion texture maps has been integrated to PBR.
(0089228)
git (administrator)
2019-11-28 07:51

Branch CR31096_2 has been created by kgv.

SHA-1: 5d9b9a1bdab3c48e33fa6bf65ccf920f0069cc41


Detailed log of new commits:

Author: iko
Date: Thu Nov 7 16:52:53 2019 +0300

    0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping
    
    Metallic-roughness and emissive textures map have been integrated to PBR.
    Mock texture maps manager (OpenGl_PBRMockTextures) has been implemented.
    
    Normal maps has been integrated to PBR.
    Occlusion texture maps has been integrated to PBR.
(0089241)
git (administrator)
2019-11-28 13:34

Branch CR31096_3 has been created by kgv.

SHA-1: b751ac6a74ed33661f2062f4a7815058b1954378


Detailed log of new commits:

Author: iko
Date: Thu Nov 7 16:52:53 2019 +0300

    0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping
    
    Metallic-roughness and emissive textures map have been integrated to PBR.
    Mock texture maps manager (OpenGl_PBRMockTextures) has been implemented.
    
    Normal maps has been integrated to PBR.
    Occlusion texture maps has been integrated to PBR.
(0089243)
git (administrator)
2019-11-28 15:08

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: adf3cc847f4841de85963dc865f6639b294a577b
(0089244)
git (administrator)
2019-11-28 15:19

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: e9f318304e7115bfc647c451d70d0afb7595fad1
(0089250)
git (administrator)
2019-11-28 17:21

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: f08ef61b16fc31711d7b209a7d601fb18d580ea6
(0089257)
git (administrator)
2019-11-28 19:05

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: 30b4424f574c73463705e87a59ad69223397841a
(0089258)
git (administrator)
2019-11-28 20:17

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: a9f263e5d833a49b2dc45fa81c76214c3767ad00
(0089260)
git (administrator)
2019-11-28 21:13

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: 8ebb07eeec24b2c252aff3e99f10bbbc46a723a4
(0089262)
git (administrator)
2019-11-28 21:38

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: 474a46c7acbb27ac2de5db46407291de8dc3366f
(0089265)
git (administrator)
2019-11-28 23:24

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: cb034ee93268bdd4f87eedef560177917d63eb4a
(0089266)
git (administrator)
2019-11-28 23:53

Branch CR31096_3 has been updated forcibly by kgv.

SHA-1: 40ac6ad7b2b0fe273320bf792ba311dca66bc357
(0089276)
git (administrator)
2019-11-29 11:10

Branch CR31096_4 has been created by kgv.

SHA-1: ffff0635b1d51e2206a696d7abc9f4c36d908043


Detailed log of new commits:

Author: iko
Date: Thu Nov 7 16:52:53 2019 +0300

    0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping
    
    OpenGl_ShaderManager - metallic-roughness, emissive, occlusion
    and normal texture maps are now supported by PBR.
    Emissive, occlusion and normal texture maps are now supported by Phong shading model.
    
    Graphic3d_TextureUnit enumeration has been extended by
    new values corresponding to supported texture maps.
    
    OpenGl_TextureSet and OpenGl_ShaderProgram have been extended with
    bitmask Graphic3d_TextureSetBits identifying texture slots read from GLSL Program
    and slots defined within Texture Set to avoid undefined behavior by binding mock textures.
    
    OpenGl_TextureSet now duplicates texture unit information to handle
    textures shared across multiple slots (like Occlusion [R] + Metallic-Roughness [GB]).
    
    OpenGl_Context::BindTextures() has been extended with active GLSL program paramter
    to set mock textures to texture units used by program but undefined by texture set.
    OpenGl_Workspace::ApplyAspects() has been extended with parameter to avoid bining texture set.
(0089279)
git (administrator)
2019-11-29 13:35

Branch CR31096_5 has been created by kgv.

SHA-1: 77c7fd4a0d06512d73fb0a0b95289ab8e06bf26c


Detailed log of new commits:

Author: iko
Date: Thu Nov 7 16:52:53 2019 +0300

    0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping
    
    OpenGl_ShaderManager - metallic-roughness, emissive, occlusion
    and normal texture maps are now supported by PBR.
    Emissive, occlusion and normal texture maps are now supported by Phong shading model.
    Path-Tracing now handles metallic-roughness texture maps.
    
    Graphic3d_TextureUnit enumeration has been extended by
    new values corresponding to supported texture maps.
    
    OpenGl_TextureSet and OpenGl_ShaderProgram have been extended with
    bitmask Graphic3d_TextureSetBits identifying texture slots read from GLSL Program
    and slots defined within Texture Set to avoid undefined behavior by binding mock textures.
    
    OpenGl_TextureSet now duplicates texture unit information to handle
    textures shared across multiple slots (like Occlusion [R] + Metallic-Roughness [GB]).
    
    OpenGl_Context::BindTextures() has been extended with active GLSL program paramter
    to set mock textures to texture units used by program but undefined by texture set.
    OpenGl_Workspace::ApplyAspects() has been extended with parameter to avoid bining texture set.
(0089280)
git (administrator)
2019-11-29 14:00

Branch CR31096_5 has been updated forcibly by kgv.

SHA-1: e68aadac73d27b4ab5751714cb2a8f7830d8eab0
(0089283)
git (administrator)
2019-11-29 14:46

Branch CR31096_5 has been updated forcibly by kgv.

SHA-1: ac09cbe173d40b408e57fd6aace2917e6b54982b
(0089310)
bugmaster (administrator)
2019-12-01 12:21

Combination -
OCCT branch : IR-2019-11-29
master SHA - 72f6dc612c43748a2c8862fe64c845d72be684d9
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : IR-2019-11-29 SHA - aff67a24109b329e80e8ffbd905de67b6637cbae
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16902.370000000145 / 16848.370000000145 [+0.32%]
Products
Total CPU difference: 10823.520000000082 / 10787.150000000072 [+0.34%]
Windows-64-VC14:
OCCT
Total CPU difference: 18406.375 / 18305.59375 [+0.55%]
Products
Total CPU difference: 1321.28125 / 1322.4375 [-0.09%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0089316)
git (administrator)
2019-12-01 12:49

Branch CR31096_5 has been deleted by inv.

SHA-1: ac09cbe173d40b408e57fd6aace2917e6b54982b
(0089317)
git (administrator)
2019-12-01 12:49

Branch CR31096_4 has been deleted by inv.

SHA-1: ffff0635b1d51e2206a696d7abc9f4c36d908043
(0089318)
git (administrator)
2019-12-01 12:49

Branch CR31096_3 has been deleted by inv.

SHA-1: 40ac6ad7b2b0fe273320bf792ba311dca66bc357
(0089321)
git (administrator)
2019-12-01 12:49

Branch CR31096_2 has been deleted by inv.

SHA-1: 5d9b9a1bdab3c48e33fa6bf65ccf920f0069cc41
(0089322)
git (administrator)
2019-12-01 12:49

Branch CR31096_1 has been deleted by inv.

SHA-1: 8aa37978c0951ff7d69e3f7687b512b3b8f74cca
(0089329)
git (administrator)
2019-12-01 12:49

Branch CR31096 has been deleted by inv.

SHA-1: c137d1a3177d64439941aa7767e3c56d46e84b8a

- Related Changesets
occt: master 72f6dc61
Timestamp: 2019-11-07 13:52:53
Author: iko
Committer: bugmaster
Details ] Diff ]
0031096: Visualization, TKOpenGl - support metallic-roughness texture mapping

OpenGl_ShaderManager - metallic-roughness, emissive, occlusion
and normal texture maps are now supported by PBR.
Emissive, occlusion and normal texture maps are now supported by Phong shading model.
Path-Tracing now handles metallic-roughness and emissive texture maps.

Graphic3d_TextureUnit enumeration has been extended by
new values corresponding to supported texture maps.

OpenGl_TextureSet and OpenGl_ShaderProgram have been extended with
bitmask Graphic3d_TextureSetBits identifying texture slots read from GLSL Program
and slots defined within Texture Set to avoid undefined behavior by binding mock textures.

OpenGl_TextureSet now duplicates texture unit information to handle
textures shared across multiple slots (like Occlusion [R] + Metallic-Roughness [GB]).

OpenGl_Context::BindTextures() has been extended with active GLSL program paramter
to set mock textures to texture units used by program but undefined by texture set.
OpenGl_Workspace::ApplyAspects() has been extended with parameter to avoid bining texture set.
mod - src/Graphic3d/FILES Diff ] File ]
mod - src/Graphic3d/Graphic3d_BSDF.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ShaderProgram.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ShaderProgram.hxx Diff ] File ]
add - src/Graphic3d/Graphic3d_TextureSetBits.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_TextureUnit.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_AspectsTextureSet.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Context.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Context.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_LayerList.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_PrimitiveArray.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_SetOfShaderPrograms.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_ShaderManager.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_ShaderManager.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_ShaderProgram.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_ShaderProgram.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_Structure.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Text.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Texture.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_TextureSet.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_TextureSet.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_View.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_View_Raytrace.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_View_Redraw.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Workspace.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_Workspace.hxx Diff ] File ]
mod - src/Shaders/Declarations.glsl Diff ] File ]
mod - src/Shaders/DeclarationsImpl.glsl Diff ] File ]
mod - src/Shaders/PathtraceBase.fs Diff ] File ]
mod - src/Shaders/Shaders_DeclarationsImpl_glsl.pxx Diff ] File ]
mod - src/Shaders/Shaders_Declarations_glsl.pxx Diff ] File ]
mod - src/Shaders/Shaders_PathtraceBase_fs.pxx Diff ] File ]
mod - src/XCAFDoc/XCAFDoc_VisMaterial.cxx Diff ] File ]
mod - src/XCAFPrs/XCAFPrs_Texture.cxx Diff ] File ]
add - tests/v3d/raytrace/helmet Diff ] File ]

- Issue History
Date Modified Username Field Change
2019-10-23 12:24 kgv New Issue
2019-10-23 12:24 kgv Assigned To => iko
2019-10-23 12:24 kgv Relationship added child of 0030700
2019-10-23 12:24 kgv Status new => assigned
2019-11-07 16:56 git Note Added: 0088779
2019-11-07 17:23 git Note Added: 0088780
2019-11-08 11:42 git Note Added: 0088788
2019-11-11 13:24 git Note Added: 0088890
2019-11-19 17:12 git Note Added: 0089075
2019-11-19 17:26 git Note Added: 0089079
2019-11-27 19:11 git Note Added: 0089227
2019-11-28 07:51 git Note Added: 0089228
2019-11-28 13:34 git Note Added: 0089241
2019-11-28 15:08 git Note Added: 0089243
2019-11-28 15:19 git Note Added: 0089244
2019-11-28 17:21 git Note Added: 0089250
2019-11-28 19:05 git Note Added: 0089257
2019-11-28 20:17 git Note Added: 0089258
2019-11-28 21:13 git Note Added: 0089260
2019-11-28 21:38 git Note Added: 0089262
2019-11-28 23:24 git Note Added: 0089265
2019-11-28 23:53 git Note Added: 0089266
2019-11-29 11:10 git Note Added: 0089276
2019-11-29 13:35 git Note Added: 0089279
2019-11-29 14:00 git Note Added: 0089280
2019-11-29 14:46 git Note Added: 0089283
2019-11-29 15:23 kgv Steps to Reproduce Updated View Revisions
2019-11-29 15:23 kgv Assigned To iko => bugmaster
2019-11-29 15:23 kgv Status assigned => resolved
2019-11-29 15:23 kgv Status resolved => reviewed
2019-11-29 17:13 kgv File Added: helmet_pbr.png
2019-11-29 17:13 kgv File Added: helmet_pt.png
2019-11-29 17:14 kgv File Added: flight_helmet_normal_map.png
2019-11-29 17:17 kgv File Added: flight_helmet_occlusion_OFF.png
2019-11-29 17:17 kgv File Added: flight_helmet_occlusion_ON.png
2019-11-29 17:18 kgv File Deleted: flight_helmet_normal_map.png
2019-11-29 17:19 kgv File Added: flight_helmet_normal_map_OFF.png
2019-11-29 17:19 kgv File Added: flight_helmet_normal_map_ON.png
2019-11-29 18:13 kgv Relationship added related to 0031146
2019-11-29 20:15 kgv Relationship added child of 0028912
2019-12-01 12:21 bugmaster Note Added: 0089310
2019-12-01 12:21 bugmaster Status reviewed => tested
2019-12-01 12:21 bugmaster Test case number => Not required
2019-12-01 12:22 bugmaster Changeset attached => occt master 72f6dc61
2019-12-01 12:22 bugmaster Status tested => verified
2019-12-01 12:22 bugmaster Resolution open => fixed
2019-12-01 12:26 kgv Relationship added related to 0031097
2019-12-01 12:26 kgv Relationship added related to 0031098
2019-12-01 12:49 git Note Added: 0089316
2019-12-01 12:49 git Note Added: 0089317
2019-12-01 12:49 git Note Added: 0089318
2019-12-01 12:49 git Note Added: 0089321
2019-12-01 12:49 git Note Added: 0089322
2019-12-01 12:49 git Note Added: 0089329


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker