View Issue Details

IDProjectCategoryView StatusLast Update
0031073Open CASCADEOCCT:Codingpublic2021-08-24 14:59
Reporterabv Assigned Tokgv  
PrioritynormalSeverityminor 
Status newResolutionopen 
Target Version7.7.0 
Summary0031073: Coding - Image_PixMapData shall have data fields private
DescriptionImplementation of the class Image_PixMapData is unsafe: its fields that characterize internal structure of data (SizeBPP, SizeX, SizeY, SizeRowBytes, TopToDown) are public and can be changed arbitrarily, thus the class does not guarantee integrity of its internal state. I propose that these fields should be private, and relevant methods added to access them (read-only).

Field TopToDown should not be accessible as is (i.e. with value either 1 or UINT_MAX) but as Boolean flag. Method Image_PixMap::TopDownInc() is confusing (documented to return either +1 or -1 but returns unsigned) and does not seem useful, better shall be removed.
TagsNo tags attached.
Test case number

Relationships

child of 0031048 closedabv Visualization - runtime error reported by Clang undefined behavior sanitizer in Image_AlienPixMap::Save() 

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-10-17 05:48 abv New Issue
2019-10-17 05:48 abv Assigned To => kgv
2019-10-17 05:48 abv Relationship added child of 0031048
2020-08-28 14:28 kgv Target Version 7.5.0 => 7.6.0
2021-08-24 14:59 kgv Target Version 7.6.0 => 7.7.0