View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031073 | Open CASCADE | OCCT:Coding | public | 2019-10-17 05:48 | 2021-08-24 14:59 |
| Reporter | abv | Assigned To | kgv | ||
| Priority | normal | Severity | minor | ||
| Status | new | Resolution | open | ||
| Target Version | 7.7.0 | ||||
| Summary | 0031073: Coding - Image_PixMapData shall have data fields private | ||||
| Description | Implementation of the class Image_PixMapData is unsafe: its fields that characterize internal structure of data (SizeBPP, SizeX, SizeY, SizeRowBytes, TopToDown) are public and can be changed arbitrarily, thus the class does not guarantee integrity of its internal state. I propose that these fields should be private, and relevant methods added to access them (read-only). Field TopToDown should not be accessible as is (i.e. with value either 1 or UINT_MAX) but as Boolean flag. Method Image_PixMap::TopDownInc() is confusing (documented to return either +1 or -1 but returns unsigned) and does not seem useful, better shall be removed. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
