| |
| Anonymous | Login | 2021-01-18 08:24 MSK |  |
| My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
| 0031073 | Open CASCADE | [OCCT] OCCT:Coding | public | 2019-10-17 05:48 | 2020-08-28 14:28 | ||||||||
| Reporter | abv | ||||||||||||
| Assigned To | kgv | ||||||||||||
| Priority | normal | Severity | minor | ||||||||||
| Status | new | Resolution | open | ||||||||||
| Platform | OS | OS Version | |||||||||||
| Product Version | |||||||||||||
| Target Version | [OCCT] 7.6.0* | Fixed in Version | |||||||||||
| Summary | 0031073: Coding - Image_PixMapData shall have data fields private | ||||||||||||
| Description | Implementation of the class Image_PixMapData is unsafe: its fields that characterize internal structure of data (SizeBPP, SizeX, SizeY, SizeRowBytes, TopToDown) are public and can be changed arbitrarily, thus the class does not guarantee integrity of its internal state. I propose that these fields should be private, and relevant methods added to access them (read-only). Field TopToDown should not be accessible as is (i.e. with value either 1 or UINT_MAX) but as Boolean flag. Method Image_PixMap::TopDownInc() is confusing (documented to return either +1 or -1 but returns unsigned) and does not seem useful, better shall be removed. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Test case number | |||||||||||||
| Attached Files | |||||||||||||
 Relationships |
||||||
|
||||||
 Relationships |
|
Notes |
|
| There are no notes attached to this issue. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-10-17 05:48 | abv | New Issue | |
| 2019-10-17 05:48 | abv | Assigned To | => kgv |
| 2019-10-17 05:48 | abv | Relationship added | child of 0031048 |
| 2020-08-28 14:28 | kgv | Target Version | 7.5.0 => 7.6.0* |
|
Issue History |
| Copyright © 2000 - 2021 MantisBT Team |
 |