View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0031039 | Open CASCADE | OCCT:Visualization | public | 2019-10-06 11:10 | 2021-12-13 14:56 |
| Reporter | kgv | Assigned To | kgv | ||
| Priority | normal | Severity | feature | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.6.0 | Fixed in Version | 7.6.0 | ||
| Summary | 0031039: Visualization - add elliptical gradient background style | ||||
| Description | Elliptical gradient background might be a nice-looking alternative to linear gradient. | ||||
| Steps To Reproduce | not required | ||||
| Tags | No tags attached. | ||||
| Test case number | tests/opengl/background/elliptical | ||||
| related to | 0032579 | closed | Draw Harness, ViewerTest - extend vbackground -cubemap syntax to configure sRGB flag |
|
|
background_circle.png (222,758 bytes) |
|
|
Branch CR31039 has been created by CheskoArt. SHA-1: 433cf3fbd358d213314274679c99073604dc66ac Detailed log of new commits: Author: achesnok Date: Tue Sep 21 18:42:21 2021 +0300 0031039: Visualization - add elliptical gradient background style Added new elliptical gradient fill method and updated vbackground command. |
|
2021-09-21 21:50 developer |
result.png (48,474 bytes) |
|
|
Please review the patch. Tests' result: http://jenkins-test-12.nnov.opencascade.com/view/CR31039-master-achesnok/view/ALL/ |
|
|
- short myDrawMode; + mutable short myDrawMode; myDrawMode should remain persistent. + myDrawMode = GL_TRIANGLE_FAN; Please define array using common GL_TRIANGLE_STRIP format or indexed triangulation. According to Vulkan specifications, this primitive type might not be supported by some implementations; although it should be implemented by all OpenGL drivers, it doesn't worth complicating further porting: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#drawing-triangle-fans + // the central vertex is colored in differen way differen -> different. Aspect_GFM_CORNER1, -Aspect_GFM_CORNER4 +Aspect_GFM_CORNER4, +Aspect_GFM_ELLIP Please document new value - describe appearance and in which order first/second colors are used. It would be great documenting all other enumeration values as well in scope of this patch. Please also rename enum values with Aspect_GradientFillMethod_ prefix and defined old values as aliases (see Graphic3d_TypeOfLightSource.hxx as example). Enumeration values should not be truncated and named in CamelCase style (e.g. Aspect_GradientFillMethod_Elliptical). |
|
|
Please also rebase patch on top of CR32579 (0032579), which modified vbackground command implementation. |
|
|
Branch CR31039_2 has been created by CheskoArt. SHA-1: 0f41dd25f62fba46f91649774b84b7dd936ca4fe Detailed log of new commits: Author: achesnok Date: Tue Sep 21 18:42:21 2021 +0300 0031039: Visualization - add elliptical gradient background style Added new elliptical gradient fill method and updated vbackground command. Renamed enum values of Aspect_GradientFillMethod and defined aliases for old ones. |
|
|
Branch CR31039_2 has been updated forcibly by CheskoArt. SHA-1: bcbcd515583f3483c75ff33c57338fcf14942601 |
|
|
Branch CR31039_2 has been updated forcibly by CheskoArt. SHA-1: 95731f8cf48fd520cd030dcfce5acb965e209662 |
|
|
Artem, please switch to RESOLVED when current remarks will be processed. While renaming Aspect_GFM values, please also update existing appearances of old names with fully-qualified ones. |
|
|
Branch CR31039_2 has been updated forcibly by CheskoArt. SHA-1: 642ece27d25a5bc4874da524991c66e2675cc417 |
|
|
Renamed all occurrences. |
|
|
Branch CR31039_2 has been updated forcibly by kgv. SHA-1: 9af0d66b849ddce139dad856da170ce53db7b1e2 |
|
|
Please raise the patch - OCCT: branch CR31039_2. |
|
|
|
|
|
Combination - OCCT branch : IR-2021-10-01 master SHA - 0f05f21194a6711251182a118643efc9eb6c322b 49e51745631c52b6c452c65adae4d6dfa21a1b1e Products branch : IR-2021-10-01 SHA - a7a409985492330e4f25011465bc659dfe7d7562 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 17464.590000000462 / 17476.150000000354 [-0.07%] Products Total CPU difference: 11405.930000000111 / 11390.180000000097 [+0.14%] Windows-64-VC14: OCCT Total CPU difference: 19332.171875 / 19335.34375 [-0.02%] Products Total CPU difference: 12772.859375 / 12782.828125 [-0.08%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR31039 has been deleted by kgv. SHA-1: 433cf3fbd358d213314274679c99073604dc66ac |
|
|
Branch CR31039_2 has been deleted by kgv. SHA-1: 9af0d66b849ddce139dad856da170ce53db7b1e2 |
|
occt: master 9af0d66b 2021-09-21 15:42:21 achesnok Committer: kgv Details Diff |
0031039: Visualization - add elliptical gradient background style Added new elliptical gradient fill method and updated vbackground command. Renamed enum values of Aspect_GradientFillMethod and defined aliases for old ones. Changed draw mode in OpenGl_BackgroundArray from triangle-strip to GL_TRIANGLES. |
Affected Issues 0031039 |
|
| mod - src/Aspect/Aspect_GradientBackground.cxx | Diff File | ||
| mod - src/Aspect/Aspect_GradientBackground.hxx | Diff File | ||
| mod - src/Aspect/Aspect_GradientFillMethod.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_BackgroundArray.cxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View.cxx | Diff File | ||
| mod - src/V3d/V3d_View.hxx | Diff File | ||
| mod - src/V3d/V3d_Viewer.hxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_OpenGlCommands.cxx | Diff File | ||
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| mod - tests/opengl/data/background/bug25775 | Diff File | ||
| add - tests/opengl/data/background/elliptical | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-10-06 11:10 | kgv | New Issue | |
| 2019-10-06 11:10 | kgv | Assigned To | => kgv |
| 2019-10-06 11:10 | kgv | File Added: background_circle.png | |
| 2020-08-28 14:29 | kgv | Target Version | 7.5.0 => 7.6.0 |
| 2021-08-24 14:13 | kgv | Target Version | 7.6.0 => 7.7.0 |
| 2021-09-14 14:49 |
|
Assigned To | kgv => CheskoArt |
| 2021-09-14 19:19 |
|
Status | new => assigned |
| 2021-09-21 21:45 | git | Note Added: 0104278 | |
| 2021-09-21 21:50 |
|
File Added: result.png | |
| 2021-09-21 23:53 |
|
Note Added: 0104280 | |
| 2021-09-21 23:53 |
|
Assigned To | CheskoArt => age |
| 2021-09-21 23:53 |
|
Status | assigned => resolved |
| 2021-09-21 23:53 |
|
Steps to Reproduce Updated | |
| 2021-09-22 08:48 | kgv | Note Added: 0104284 | |
| 2021-09-22 08:48 | kgv | Note Edited: 0104284 | |
| 2021-09-22 14:19 | kgv | Note Added: 0104289 | |
| 2021-09-22 14:19 | kgv | Relationship added | related to 0032579 |
| 2021-09-24 14:46 | git | Note Added: 0104329 | |
| 2021-09-24 16:35 | git | Note Added: 0104335 | |
| 2021-09-24 16:37 | git | Note Added: 0104336 | |
| 2021-09-24 19:47 | kgv | Note Added: 0104341 | |
| 2021-09-24 19:47 | kgv | Assigned To | age => CheskoArt |
| 2021-09-24 19:47 | kgv | Status | resolved => assigned |
| 2021-09-24 21:48 | git | Note Added: 0104344 | |
| 2021-09-24 21:49 |
|
Note Added: 0104345 | |
| 2021-09-24 21:49 |
|
Assigned To | CheskoArt => kgv |
| 2021-09-24 21:49 |
|
Status | assigned => resolved |
| 2021-09-26 11:18 | git | Note Added: 0104377 | |
| 2021-09-26 17:16 | kgv | Test case number | => tests/opengl/background/elliptical |
| 2021-09-26 17:16 | kgv | Note Added: 0104381 | |
| 2021-09-26 17:16 | kgv | Assigned To | kgv => bugmaster |
| 2021-09-26 17:16 | kgv | Status | resolved => reviewed |
| 2021-09-26 17:16 | kgv | Target Version | 7.7.0 => 7.6.0 |
| 2021-09-29 17:40 | kgv | Note Added: 0104432 | |
| 2021-10-02 10:34 |
|
Note Added: 0104481 | |
| 2021-10-02 10:34 |
|
Status | reviewed => tested |
| 2021-10-02 11:32 | kgv | Changeset attached | => occt master 9af0d66b |
| 2021-10-02 11:32 | kgv | Assigned To | bugmaster => kgv |
| 2021-10-02 11:32 | kgv | Status | tested => verified |
| 2021-10-02 11:32 | kgv | Resolution | open => fixed |
| 2021-12-13 14:56 | git | Note Added: 0105853 | |
| 2021-12-13 14:56 | git | Note Added: 0105854 |
