View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0031020CommunityOCCT:Codingpublic2019-10-01 19:212020-12-02 17:12
Reportersraymond Assigned Toapn  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
Product Version7.4.0 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031020: Coding - invalid inline usage in BRepBlend_AppSurface
DescriptionIn file BRepBlend_AppSurface.cxx

the implementation uses the keyword inline:

inline void BRepBlend_AppSurface::TolReached (Standard_Real& Tol3d,
                     Standard_Real& Tol2d) const
{
  Tol3d = approx.MaxErrorOnSurf();
  Tol2d = 0;
  for (Standard_Integer ii=1; ii<=approx.NbCurves2d(); ii++) {
    Tol2d = Max(Tol2d, approx.Max2dError(ii));
  }
}

Causing undefined symbol import error

I guess it comes from copy/paste error form BRepBlend_AppSurface.lxx

Please consider removing inline declaration or move back the method BRepBlend_AppSurface::TolReached back to BRepBlend_AppSurface.lxx
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed

Activities

git

2019-10-01 23:07

administrator   ~0087675

Branch CR31020 has been created by msv.

SHA-1: ed5e72c58e4ae0f773474c8710b02e7da2a92f7b


Detailed log of new commits:

Author: msv
Date: Tue Oct 1 23:06:35 2019 +0300

    0031020: invalid inline usage in BRepBlend_AppSurface
    
    BRepBlend_AppSurface and some other classes have been corrected to avoid inlining member functions in .cxx code.

msv

2019-10-01 23:11

developer   ~0087676

Please review.

http://jenkins-test-12.nnov.opencascade.com/view/CR31020-MSV/view/COMPARE/

kgv

2019-10-01 23:13

developer   ~0087677 

-  inline void Nullify ();
+  inline void Nullify ()

"inline" looks redundant here.

git

2019-10-01 23:17

administrator   ~0087678

Branch CR31020 has been updated forcibly by kgv.

SHA-1: bb9fce1dd28876170a0150708303801748eadbbd

apn

2019-10-04 20:25

administrator   ~0087844

Combination -
OCCT branch : CR31020
master SHA - ed5e72c58e4ae0f773474c8710b02e7da2a92f7b
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : master SHA - 83df4cb7aa05ca0b1f190a68462fc970ee162d17
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16811.49999999996 / 16862.21000000009 [-0.30%]
Products
Total CPU difference: 10514.920000000038 / 10559.290000000046 [-0.42%]
Windows-64-VC14:
OCCT
Total CPU difference: 18323.109375 / 18333.171875 [-0.05%]
Products
Total CPU difference: 12505.421875 / 12537.390625 [-0.25%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2019-10-23 11:51

administrator   ~0088472

Branch CR31020 has been deleted by kgv.

SHA-1: bb9fce1dd28876170a0150708303801748eadbbd

Related Changesets

occt: master 746cb7c3

2019-10-01 20:06:35

msv


Committer: apn Details Diff		 0031020: Coding - invalid inline usage in BRepBlend_AppSurface

BRepBlend_AppSurface and some other classes have been corrected to avoid inlining member functions in .cxx code.		 Affected Issues
0031020
mod - src/BRepBlend/BRepBlend_AppSurface.cxx Diff File
mod - src/BRepMesh/BRepMesh_Delaun.cxx Diff File
mod - src/MeshVS/MeshVS_DummySensitiveEntity.cxx Diff File
mod - src/NCollection/NCollection_BaseSequence.cxx Diff File
mod - src/NCollection/NCollection_BaseSequence.hxx Diff File
mod - src/ShapeFix/ShapeFix_Edge.cxx Diff File

Issue History

Date Modified Username Field Change
2019-10-01 19:21 sraymond New Issue
2019-10-01 19:21 sraymond Assigned To => msv
2019-10-01 23:07 git Note Added: 0087675
2019-10-01 23:07 msv Status new => assigned
2019-10-01 23:11 msv Note Added: 0087676
2019-10-01 23:11 msv Assigned To msv => kgv
2019-10-01 23:11 msv Status assigned => resolved
2019-10-01 23:11 msv Steps to Reproduce Updated
2019-10-01 23:13 kgv Note Added: 0087677
2019-10-01 23:14 kgv Category OCCT:Modeling Algorithms => OCCT:Coding
2019-10-01 23:14 kgv Summary invalid inline usage in BRepBlend_AppSurface => Coding - invalid inline usage in BRepBlend_AppSurface
2019-10-01 23:17 git Note Added: 0087678
2019-10-01 23:17 kgv Assigned To kgv => bugmaster
2019-10-01 23:17 kgv Status resolved => reviewed
2019-10-04 20:25 apn Test case number => Not needed
2019-10-04 20:25 apn Note Added: 0087844
2019-10-04 20:25 apn Status reviewed => tested
2019-10-23 01:07 apn Changeset attached => occt master 746cb7c3
2019-10-23 01:07 apn Assigned To bugmaster => apn
2019-10-23 01:07 apn Status tested => verified
2019-10-23 01:07 apn Resolution open => fixed
2019-10-23 11:51 git Note Added: 0088472
2020-12-02 16:40 emo Fixed in Version => 7.5.0
2020-12-02 17:12 emo Status verified => closed