MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0031007Open CASCADE[OCCT] OCCT:Codingpublic2019-09-27 15:032019-12-01 12:49
Reportertizmaylo 
Assigned Tobugmaster 
PrioritynormalSeverityminor 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version[OCCT] 7.3.0 
Target Version[OCCT] 7.5.0*Fixed in Version 
Summary0031007: Coding - eliminate warnings issued while compiling with -pedantic flag
DescriptionWhile compiling current OCCT master branch using -pedantic compiler flag, some warnings about extra semicolons are issued. E.g., look at the attached files mingw-8.1.0-build-pedantic.log and clang-8.0.0-build-pedantic.log.
TagsNo tags attached.
Test case number
Attached Fileslog file icon mingw-8.1.0-build-pedantic.log (36,729 bytes) 2019-09-27 15:03
log file icon clang-8.0.0-build-pedantic.log (29,166 bytes) 2019-09-27 15:03

- Relationships
related to 0027092closedabv Community Coding - src/BRep/BRep_Tool.hxx extra semicolon triggers annoying warnings on Clang 
child of 0027105closedabv Community Make code ISO-compliant [-Wpedantic fixes] 

-  Notes
(0089156)
git (administrator)
2019-11-22 17:04

Branch CR31007 has been created by kgv.

SHA-1: 0dd179c8649bf57bb6f5f3f7d17aa5ff7bfce21b


Detailed log of new commits:

Author: kgv
Date: Fri Nov 22 17:02:12 2019 +0300

    0031007: Coding - eliminate warnings issued while compiling with -pedantic flag
    
    Removed duplicating semicolons ;;.
    Removed redundant semicolon at namespace closure.
(0089157)
kgv (developer)
2019-11-22 18:35

Trivial patch is ready for review.
(0089161)
abv (manager)
2019-11-24 11:02

No remarks, please integrate
(0089222)
bugmaster (administrator)
2019-11-27 16:45

Combination -
OCCT branch : WEEK-48
master SHA - 2b5a58a33cf42ab3d995e63dde8c1ff7278cb4d0
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : WEEK-48 SHA - 3b604b9355eb7932637676d9f7a2146a78ba7df1
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16796.860000000055 / 16848.370000000145 [-0.31%]
Products
Total CPU difference: 10878.57000000006 / 10787.150000000072 [+0.85%]
Windows-64-VC14:
OCCT
Total CPU difference: 18298.9375 / 18305.59375 [-0.04%]
Products
Total CPU difference: 10772.90625 / 12768.0625 [-15.63%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0089327)
git (administrator)
2019-12-01 12:49

Branch CR31007 has been deleted by inv.

SHA-1: 0dd179c8649bf57bb6f5f3f7d17aa5ff7bfce21b

- Related Changesets
occt: master 8c2d3314
Timestamp: 2019-11-22 14:02:12
Author: kgv
Committer: bugmaster
Details ] Diff ]
0031007: Coding - eliminate warnings issued while compiling with -pedantic flag

Removed duplicating semicolons ;;.
Removed redundant semicolon at namespace closure.
mod - src/Adaptor2d/Adaptor2d_OffsetCurve.cxx Diff ] File ]
mod - src/Adaptor3d/Adaptor3d_TopolTool.cxx Diff ] File ]
mod - src/AIS/AIS_Circle.cxx Diff ] File ]
mod - src/AIS/AIS_FixRelation.cxx Diff ] File ]
mod - src/AIS/AIS_GraphicTool.cxx Diff ] File ]
mod - src/AIS/AIS_IdenticRelation.cxx Diff ] File ]
mod - src/AIS/AIS_Manipulator.hxx Diff ] File ]
mod - src/AIS/AIS_OffsetDimension.cxx Diff ] File ]
mod - src/AppBlend/AppBlend_AppSurf.gxx Diff ] File ]
mod - src/AppCont/AppCont_LeastSquare.cxx Diff ] File ]
mod - src/AppParCurves/AppParCurves.cxx Diff ] File ]
mod - src/AppParCurves/AppParCurves_LeastSquare.gxx Diff ] File ]
mod - src/Approx/Approx_SameParameter.cxx Diff ] File ]
mod - src/BinTools/BinTools.cxx Diff ] File ]
mod - src/Bisector/Bisector_Bisec.cxx Diff ] File ]
mod - src/Bisector/Bisector_BisecCC.cxx Diff ] File ]
mod - src/Bisector/Bisector_BisecPC.cxx Diff ] File ]
mod - src/BiTgte/BiTgte_Blend.cxx Diff ] File ]
mod - src/Blend/Blend_Walking_4.gxx Diff ] File ]
mod - src/BlendFunc/BlendFunc_ConstThroatInv.cxx Diff ] File ]
mod - src/BlendFunc/BlendFunc_ConstThroatWithPenetrationInv.cxx Diff ] File ]
mod - src/BlendFunc/BlendFunc_CSCircular.cxx Diff ] File ]
mod - src/BlendFunc/BlendFunc_CSConstRad.cxx Diff ] File ]
mod - src/BOPTools/BOPTools_AlgoTools_1.cxx Diff ] File ]
mod - src/BRepAlgo/BRepAlgo_FaceRestrictor.cxx Diff ] File ]
mod - src/BRepAlgoAPI/BRepAlgoAPI_BooleanOperation.cxx Diff ] File ]
mod - src/BRepBlend/BRepBlend_SurfRstConstRad.cxx Diff ] File ]
mod - src/BRepBlend/BRepBlend_SurfRstEvolRad.cxx Diff ] File ]
mod - src/BRepBndLib/BRepBndLib.cxx Diff ] File ]
mod - src/BRepFeat/BRepFeat.cxx Diff ] File ]
mod - src/BRepFill/BRepFill_Pipe.cxx Diff ] File ]
mod - src/BRepFill/BRepFill_Sweep.cxx Diff ] File ]
mod - src/BRepLib/BRepLib_MakeFace.cxx Diff ] File ]
mod - src/BRepMesh/BRepMesh_Delaun.cxx Diff ] File ]
mod - src/BRepOffset/BRepOffset_Inter3d.cxx Diff ] File ]
mod - src/BRepTest/BRepTest_SweepCommands.cxx Diff ] File ]
mod - src/CDM/CDM_Document.hxx Diff ] File ]
mod - src/ChFi3d/ChFi3d_Builder_0.cxx Diff ] File ]
mod - src/ChFi3d/ChFi3d_Builder_C1.cxx Diff ] File ]
mod - src/ChFi3d/ChFi3d_ChBuilder.cxx Diff ] File ]
mod - src/ChFi3d/ChFi3d_FilBuilder.cxx Diff ] File ]
mod - src/DDataStd/DDataStd_BasicCommands.cxx Diff ] File ]
mod - src/Draw/Draw_Viewer.cxx Diff ] File ]
mod - src/Draw/Draw_Window.cxx Diff ] File ]
mod - src/Expr/Expr_Sum.cxx Diff ] File ]
mod - src/Expr/Expr_UnaryFunction.cxx Diff ] File ]
mod - src/FilletSurf/FilletSurf_InternalBuilder.cxx Diff ] File ]
mod - src/Font/Font_FontMgr.cxx Diff ] File ]
mod - src/GccAna/GccAna_Circ2d2TanRad_1.cxx Diff ] File ]
mod - src/Geom2dGcc/Geom2dGcc_Circ2d2TanOnIter.cxx Diff ] File ]
mod - src/GeomFill/GeomFill_NSections.cxx Diff ] File ]
mod - src/GeomFill/GeomFill_Sweep.cxx Diff ] File ]
mod - src/GeomPlate/GeomPlate_BuildPlateSurface.cxx Diff ] File ]
mod - src/GeomToIGES/GeomToIGES_GeomCurve.cxx Diff ] File ]
mod - src/IGESAppli/IGESAppli_ToolNodalDisplAndRot.cxx Diff ] File ]
mod - src/IGESData/IGESData_IGESReaderTool.cxx Diff ] File ]
mod - src/IGESDraw/IGESDraw_Protocol.cxx Diff ] File ]
mod - src/IGESGeom/IGESGeom_Protocol.cxx Diff ] File ]
mod - src/IGESGeom/IGESGeom_ToolSplineCurve.cxx Diff ] File ]
mod - src/IGESGraph/IGESGraph_Protocol.cxx Diff ] File ]
mod - src/IGESSolid/IGESSolid_Protocol.cxx Diff ] File ]
mod - src/IGESSolid/IGESSolid_ToolShell.cxx Diff ] File ]
mod - src/IntCurveSurface/IntCurveSurface_Polyhedron.gxx Diff ] File ]
mod - src/IntPatch/IntPatch_InterferencePolyhedron.cxx Diff ] File ]
mod - src/IntPatch/IntPatch_Polyhedron.cxx Diff ] File ]
mod - src/IntPolyh/IntPolyh_Triangle.cxx Diff ] File ]
mod - src/IntWalk/IntWalk_IWalking_2.gxx Diff ] File ]
mod - src/LocOpe/LocOpe_SplitDrafts.cxx Diff ] File ]
mod - src/math/math_BFGS.cxx Diff ] File ]
mod - src/math/math_TrigonometricFunctionRoots.cxx Diff ] File ]
mod - src/OSD/OSD_FileNode.cxx Diff ] File ]
mod - src/PLib/PLib.cxx Diff ] File ]
mod - src/QABugs/QABugs_16.cxx Diff ] File ]
mod - src/QABugs/QABugs_19.cxx Diff ] File ]
mod - src/QABugs/QABugs_20.cxx Diff ] File ]
mod - src/ShapeCustom/ShapeCustom_BSplineRestriction.cxx Diff ] File ]
mod - src/ShapeFix/ShapeFix.cxx Diff ] File ]
mod - src/ShapeFix/ShapeFix_ComposeShell.cxx Diff ] File ]
mod - src/ShapeFix/ShapeFix_Wire.cxx Diff ] File ]
mod - src/ShapeUpgrade/ShapeUpgrade_SplitSurfaceContinuity.cxx Diff ] File ]
mod - src/STEPConstruct/STEPConstruct_ValidationProps.cxx Diff ] File ]
mod - src/StepVisual/StepVisual_CoordinatesList.hxx Diff ] File ]
mod - src/StepVisual/StepVisual_TessellatedCurveSet.hxx Diff ] File ]
mod - src/StepVisual/StepVisual_TessellatedItem.hxx Diff ] File ]
mod - src/SWDRAW/SWDRAW_ShapeFix.cxx Diff ] File ]
mod - src/TDF/TDF_Delta.cxx Diff ] File ]
mod - src/TopOpeBRep/TopOpeBRep_FacesIntersector.cxx Diff ] File ]
mod - src/TopOpeBRepBuild/TopOpeBRepBuild_Builder1_1.cxx Diff ] File ]
mod - src/TopOpeBRepBuild/TopOpeBRepBuild_Section.cxx Diff ] File ]
mod - src/TopOpeBRepDS/TopOpeBRepDS_Check.cxx Diff ] File ]
mod - src/TopOpeBRepTool/TopOpeBRepTool_PURGE.cxx Diff ] File ]
mod - src/TopOpeBRepTool/TopOpeBRepTool_TOPOLOGY.cxx Diff ] File ]
mod - src/TPrsStd/TPrsStd_ConstraintTools.cxx Diff ] File ]
mod - src/Units/Units_UnitsDictionary.lxx Diff ] File ]
mod - src/XCAFDimTolObjects/XCAFDimTolObjects_GeomToleranceObject.hxx Diff ] File ]
mod - src/XCAFDoc/XCAFDoc_AssemblyItemRef.hxx Diff ] File ]
mod - src/XSControl/XSControl_Functions.cxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2019-09-27 15:03 tizmaylo New Issue
2019-09-27 15:03 tizmaylo Assigned To => kgv
2019-09-27 15:03 tizmaylo File Added: mingw-8.1.0-build-pedantic.log
2019-09-27 15:03 tizmaylo File Added: clang-8.0.0-build-pedantic.log
2019-09-27 15:03 tizmaylo Summary 0030609: Coding - eliminate warnings issued while compiling with -pedantic flag => Coding - eliminate warnings issued while compiling with -pedantic flag
2019-11-22 17:04 git Note Added: 0089156
2019-11-22 18:35 kgv Note Added: 0089157
2019-11-22 18:35 kgv Assigned To kgv => abv
2019-11-22 18:35 kgv Status new => resolved
2019-11-22 18:36 kgv Relationship added related to 0027092
2019-11-22 18:36 kgv Relationship added child of 0027105
2019-11-24 11:02 abv Note Added: 0089161
2019-11-24 11:02 abv Assigned To abv => bugmaster
2019-11-24 11:02 abv Status resolved => reviewed
2019-11-27 16:45 bugmaster Note Added: 0089222
2019-11-27 16:45 bugmaster Status reviewed => tested
2019-12-01 12:22 bugmaster Changeset attached => occt master 8c2d3314
2019-12-01 12:22 bugmaster Status tested => verified
2019-12-01 12:22 bugmaster Resolution open => fixed
2019-12-01 12:49 git Note Added: 0089327


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker