View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0030906Open CASCADEOCCT:Visualizationpublic2019-08-20 14:312019-09-02 17:52
Reporterkgv Assigned Toapn  
PrioritynormalSeveritymajor 
Status closedResolutionfixed 
Product Version7.4.0 
Target Version7.4.0Fixed in Version7.4.0 
Summary0030906: Visualization, SelectMgr_ViewerSelector - Object clipping planes overrides View clipping plane for next objects
DescriptionWhen object having View clipping planes overriding comes before normal objects, the following objects also ignore View clipping planes.
Steps To Reproduce
pload MODELING VISUALIZATION
box b1 1 1 0 1 2 3
box b2 3 0 0 1 2 3
vclear
vinit View1
vdisplay -dispMode 1 -highMode 1 b1 b2
vfit
vzbufftrihedron
vpoint p0 0 0 0
vclipplane c1 -equation 0 1 0  1 -setOverrideGlobal b1
vclipplane c2 -equation 0 1 0 -1 -set
vmoveto 200 200
if { [vreadpixel 250 200 -rgb -name] != "DARKGOLDENROD3" } { puts "Error: selection of clipped object" }
if { [vreadpixel 150 200 -rgb -name] != "DARKTURQUOISE"  } { puts "Error: object is not selected" }
TagsNo tags attached.
Test case numberbugs vis bug30906

Relationships

related to 0030863 closedbugmaster Open CASCADE Visualization, SelectMgr_ViewerSelector - disabling of View clipping planes is ignored for transformed objects 

Activities

git

2019-08-20 16:31

administrator   ~0086373

Branch CR30906 has been created by kgv.

SHA-1: 8f7be7ea6d5aac331da1b0d1a1e16f6c95fdee39


Detailed log of new commits:

Author: kgv
Date: Tue Aug 20 16:28:33 2019 +0300

    0030906: Visualization, SelectMgr_ViewerSelector - Object clipping planes overrides View clipping plane for next objects
    
    Clipping range has been moved from SelectMgr_RectangularFrustum to SelectMgr_SelectingVolumeManager
    and passed to frustum as an argument to Overlap() methods.
    This fixes an issue when Clipping is customized per-object within SelectMgr_ViewerSelector::traverseObject()
    in case when shallow copy of SelectMgr_SelectingVolumeManager is created
    (frustums are copied from global frustum manager by Handle).

kgv

2019-08-20 19:19

developer   ~0086376

Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30906-master-KGV

san

2019-08-21 19:43

developer   ~0086389

Branch CR30906 reviewed without remarks.

apn

2019-08-22 20:34

administrator   ~0086421

Combination -
OCCT branch : CR30906
master SHA - 8f7be7ea6d5aac331da1b0d1a1e16f6c95fdee39
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : master SHA - 32e882a7b3145a66baa739f965d275c822c0bd8a
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16099.150000000005 / 16105.290000000065 [-0.04%]
Products
Total CPU difference: 10499.940000000048 / 10484.700000000048 [+0.15%]
Windows-64-VC14:
OCCT
Total CPU difference: 18186.234375 / 18149.296875 [+0.20%]
Products
Total CPU difference: 12131.78125 / 12045.34375 [+0.72%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2019-09-02 17:52

administrator   ~0086627

Branch CR30906 has been deleted by mnt.

SHA-1: 8f7be7ea6d5aac331da1b0d1a1e16f6c95fdee39

Related Changesets

occt: master d7fa57a7

2019-08-20 13:28:33

kgv


Committer: apn Details Diff		 0030906: Visualization, SelectMgr_ViewerSelector - Object clipping planes overrides View clipping plane for next objects

Clipping range has been moved from SelectMgr_RectangularFrustum to SelectMgr_SelectingVolumeManager
and passed to frustum as an argument to Overlap() methods.
This fixes an issue when Clipping is customized per-object within SelectMgr_ViewerSelector::traverseObject()
in case when shallow copy of SelectMgr_SelectingVolumeManager is created
(frustums are copied from global frustum manager by Handle).		 Affected Issues
0030906
mod - src/SelectMgr/FILES Diff File
mod - src/SelectMgr/SelectMgr_BaseFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_BaseFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_RectangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_RectangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.cxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.hxx Diff File
add - src/SelectMgr/SelectMgr_ViewClipRange.cxx Diff File
mod - src/SelectMgr/SelectMgr_ViewClipRange.hxx Diff File
mod - src/SelectMgr/SelectMgr_ViewerSelector.cxx Diff File
add - tests/bugs/vis/bug30906 Diff File

Issue History

Date Modified Username Field Change
2019-08-20 14:31 kgv New Issue
2019-08-20 14:31 kgv Assigned To => kgv
2019-08-20 14:31 kgv Relationship added related to 0030863
2019-08-20 16:26 kgv Steps to Reproduce Updated
2019-08-20 16:31 git Note Added: 0086373
2019-08-20 19:19 kgv Note Added: 0086376
2019-08-20 19:19 kgv Assigned To kgv => san
2019-08-20 19:19 kgv Severity minor => major
2019-08-20 19:19 kgv Status new => resolved
2019-08-21 19:43 san Note Added: 0086389
2019-08-21 19:43 san Assigned To san => bugmaster
2019-08-21 19:43 san Status resolved => reviewed
2019-08-22 20:32 apn Test case number => bugs vis bug30906
2019-08-22 20:34 apn Note Added: 0086421
2019-08-22 20:34 apn Status reviewed => tested
2019-08-24 16:56 apn Changeset attached => occt master d7fa57a7
2019-08-24 16:56 apn Assigned To bugmaster => apn
2019-08-24 16:56 apn Status tested => verified
2019-08-24 16:56 apn Resolution open => fixed
2019-09-02 17:52 git Note Added: 0086627