View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0030846 | Community | OCCT:Foundation Classes | public | 2019-07-17 11:55 | 2019-09-07 16:26 |
| Reporter | BenjaminBihler | Assigned To | bugmaster | ||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.1 | ||||
| Target Version | 7.4.0 | Fixed in Version | 7.4.0 | ||
| Summary | 0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule | ||||
| Description | When building with link-time optimization (-flto), g++ warns that the struct StorageInfo is defined both in OSD_MAllocHook.cxx:250 and in NCollection_BaseAllocator.cxx:72. This violates the C++ One Definition Rule. Therefore the structures should be merged or renamed. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR30846 has been created by kgv. SHA-1: 34d19c2485b56b359f5d3f75c621b3ce8b3d159f Detailed log of new commits: Author: kgv Date: Wed Sep 4 18:42:42 2019 +0300 0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule Local definitions have been put into anonymouse namespace within files OSD_MAllocHook.cxx and NCollection_BaseAllocator.cxx. |
|
|
Patch is ready for review. http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30846-master-KGV/ |
|
|
No remarks, please integrate |
|
|
Combination - OCCT branch : CR30846 master SHA - 34d19c2485b56b359f5d3f75c621b3ce8b3d159f 5f5b1aed1c6e139bbd34314eca77ae7abcd8895c Products branch : master SHA - 34e9bf11c6b525830b5dee35839707da81e7d1ab was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 16200.500000000076 / 16167.270000000033 [+0.21%] Products Total CPU difference: 10489.310000000056 / 10484.930000000048 [+0.04%] Windows-64-VC14: OCCT Total CPU difference: 18288.9375 / 18256.515625 [+0.18%] Products Total CPU difference: 12130.375 / 12168.265625 [-0.31%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR30846 has been deleted by inv. SHA-1: 34d19c2485b56b359f5d3f75c621b3ce8b3d159f |
|
occt: master 9eefb360 2019-09-04 15:42:42 Committer: bugmaster Details Diff |
0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule Local definitions have been put into anonymouse namespace within files OSD_MAllocHook.cxx and NCollection_BaseAllocator.cxx. |
Affected Issues 0030846 |
|
| mod - src/NCollection/NCollection_BaseAllocator.cxx | Diff File | ||
| mod - src/OSD/OSD_MAllocHook.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-07-17 11:55 | BenjaminBihler | New Issue | |
| 2019-07-17 11:55 | BenjaminBihler | Assigned To | => abv |
| 2019-09-04 18:45 | git | Note Added: 0086751 | |
| 2019-09-04 23:06 | kgv | Note Added: 0086759 | |
| 2019-09-04 23:06 | kgv | Severity | minor => trivial |
| 2019-09-04 23:06 | kgv | Status | new => resolved |
| 2019-09-04 23:06 | kgv | Product Version | => 6.5.1 |
| 2019-09-05 04:44 |
|
Note Added: 0086763 | |
| 2019-09-05 04:44 |
|
Assigned To | abv => bugmaster |
| 2019-09-05 04:44 |
|
Status | resolved => reviewed |
| 2019-09-05 18:15 | bugmaster | Test case number | => Not required |
| 2019-09-05 18:17 | bugmaster | Note Added: 0086811 | |
| 2019-09-05 18:17 | bugmaster | Status | reviewed => tested |
| 2019-09-07 11:38 | bugmaster | Changeset attached | => occt master 9eefb360 |
| 2019-09-07 11:38 | bugmaster | Status | tested => verified |
| 2019-09-07 11:38 | bugmaster | Resolution | open => fixed |
| 2019-09-07 16:26 | git | Note Added: 0086934 |
