MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030831Open CASCADE[OCCT] OCCT:Shape Healingpublic2019-07-03 19:532019-07-04 11:43
Reporteragv 
Assigned Togka 
PrioritynormalSeverityminor 
StatusresolvedResolutionopen 
PlatformWindowsOSVC++ 2015OS Version64 bit
Product Version[OCCT] 7.2.0 
Target Version[OCCT] 7.4.0*Fixed in Version 
Summary0030831: Shape Healing - ShapeFix algorithm (creation of seam edge) takes too long time with thin faces
DescriptionAttached file "faces.bin" contains two faces from a large STEP assembly obtained with the conversion of units from mm to m (everything scaled down 1000 times). As the result these cylindrical faces have the height ~2e-8, and the algorithm considers them as both U-closed and V-closed. Hence incorrect result and too long processing.
Steps To Reproducebinrestore faces.bin ff
explode ff
chrono cc start
fixshape rr_1 ff_1
chrono cc show
>> CPU user time: 426.2415323 seconds
fixshape rr_2 ff_2
chrono cc show
>> CPU user time: 671.2879031 seconds
TagsNo tags attached.
Test case number
Attached Files? file icon faces.bin (1,768 bytes) 2019-07-03 19:53

- Relationships

-  Notes
(0085414)
git (administrator)
2019-07-03 20:06

Branch CR30831 has been created by agv.

SHA-1: 532383ee8db8f825a5d0b927ccc0a9962a73d990


Detailed log of new commits:

Author: agv
Date: Wed Jul 3 20:04:16 2019 +0300

    0030831: ShapeFix algorithm (creation of seam edge) takes too long time with thin faces
    
    In class ShapeFix_ComposeShell the U- and V-closedness of input face is taken immediately avoiding the error when the face is small in any of these dimensions.
(0085415)
agv (developer)
2019-07-03 20:11

With this change the result is valid shapes and the processing time is greatly reduced:

>> Elapsed time: 0 Hours 0 Minutes 0.00192222837359 Seconds
>> Elapsed time: 0 Hours 0 Minutes 0.00816187029704 Seconds
(0085416)
kgv (developer)
2019-07-03 20:24
edited on: 2019-07-03 20:25

+  // agv 2019/07/03 - avoid false detection of 'Closed' on very thin faces
+  if (theSurface->IsKind(STANDARD_TYPE(Geom_ElementarySurface))) {

This is an obsolete (before moving OCCT to git) style, which should be avoided in new patches.
The change description should be within git commit message, authorship is deduced from git commit author field (as well as change date),
and code itself should contain only comments documenting the actual status, when needed.

(0085421)
git (administrator)
2019-07-04 11:43

Branch CR30831 has been updated by agv.

SHA-1: 796ca537820772db2d7adf85962cce2d7ae7e6af


Detailed log of new commits:

Author: agv
Date: Thu Jul 4 11:42:11 2019 +0300

    Correction of a comment to the new code block.


- Issue History
Date Modified Username Field Change
2019-07-03 19:53 agv New Issue
2019-07-03 19:53 agv Assigned To => msv
2019-07-03 19:53 agv File Added: faces.bin
2019-07-03 19:54 agv Assigned To msv => agv
2019-07-03 20:05 msv Status new => assigned
2019-07-03 20:05 msv Category OCCT:Modeling Algorithms => OCCT:Shape Healing
2019-07-03 20:06 git Note Added: 0085414
2019-07-03 20:11 agv Note Added: 0085415
2019-07-03 20:12 agv Assigned To agv => gka
2019-07-03 20:12 agv Status assigned => resolved
2019-07-03 20:18 kgv Summary ShapeFix algorithm (creation of seam edge) takes too long time with thin faces => Shape Healing - ShapeFix algorithm (creation of seam edge) takes too long time with thin faces
2019-07-03 20:24 kgv Note Added: 0085416
2019-07-03 20:25 kgv Note Edited: 0085416 View Revisions
2019-07-03 20:25 kgv Note Edited: 0085416 View Revisions
2019-07-04 11:43 git Note Added: 0085421


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker