View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0030726 | Open CASCADE | OCCT:Visualization | public | 2019-05-22 13:10 | 2019-06-08 13:21 |
| Reporter | nds | Assigned To | bugmaster | ||
| Priority | low | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.4.0 | Fixed in Version | 7.4.0 | ||
| Summary | 0030726: Visualization - change Selected state of owner within AIS_Selection instead of AIS_InteractiveContext | ||||
| Description | Selected state of SelectMgr_EntityOwner means whether the owner selected or not. It is proposed to move this state update from context into AIS_Selection. Almost in all cases of this state update, we call Select/AddTo/Clear of AIS_Selection and, after, update the state of the owner in context now. This logic, separated between two classes, might lead to incorrect update of selected state of the owner. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR30726 has been created by nds. SHA-1: de3dec2077b7d4d14fd6a6d5b72b4d290a4b88d6 Detailed log of new commits: Author: nds Date: Wed May 22 13:13:33 2019 +0300 0030726: Visualization - change Selected state of owner in AIS_Selection |
|
|
Branch CR30726 has been updated by nds. SHA-1: 7d778441498ef0f0f545c800c671ee693bb5cf05 Detailed log of new commits: Author: nds Date: Wed May 22 14:24:12 2019 +0300 0030726: Visualization - change Selected state of owner in AIS_Selection # IsHilighted by owner should use the same logic like when it is highlighted. IsSelected is used for selection state, not highlight. # # Without this correction, object is never shown as selected by click (Select(bool)): # if (!HighlightStyle (theOwner, aCustomStyle) || # (!aCustomStyle.IsNull() && aCustomStyle != anObjSelStyle)) # IsSelected is already true, so the highlight style is equal to selection style, nothing to do. |
|
|
Branch CR30726_1 has been created by nds. SHA-1: 1fb65e1396c98353e9ee0c0a14d4354531b74937 Detailed log of new commits: Author: nds Date: Wed May 22 13:13:33 2019 +0300 0030726: Visualization - change Selected state of owner in AIS_Selection # IsHilighted by owner should use the same logic like when it is highlighted. IsSelected is used for selection state, not highlight. # # Without this correction, object is never shown as selected by click (Select(bool)): # if (!HighlightStyle (theOwner, aCustomStyle) || # (!aCustomStyle.IsNull() && aCustomStyle != anObjSelStyle)) # IsSelected is already true, so the highlight style is equal to selection style, nothing to do. |
|
|
Dear Kirill, could you please review it. Job on Jenkins is: http://jenkins-test-12.nnov.opencascade.com/view/CR30726-master-NDS/ Thank you in advance, Natalia |
|
|
> # IsHilighted by owner should use the same logic like when it is highlighted. IsSelected is used for selection state, not highlight. > # > # Without this correction, object is never shown as selected by click (Select(bool)): Please remove # from commit description - just put comments without prefix. Please also document in commit that AIS_InteractiveContext::IsHilighted() behavior has been changed. |
|
|
Branch CR30726_2 has been created by nds. SHA-1: c9f43340646a40b5deb4190550b940beb00a1559 Detailed log of new commits: Author: nds Date: Thu Jun 6 11:50:21 2019 +0300 0030726: Visualization - change Selected state of owner in AIS_Selection AIS_InteractiveContext::IsHilighted() behavior has been changed. It should use the same logic for owner processing like when it is highlighted. IsSelected of owner is used for selection state, not highlight. Without this correction, object is never shown as selected by click (Select(bool)): if (!HighlightStyle (theOwner, aCustomStyle) || (!aCustomStyle.IsNull() && aCustomStyle != anObjSelStyle)) IsSelected is already true, so the highlight style is equal to selection style, nothing to do. |
|
|
Dear Kirill, Corrected. Jenkins job is the same. Best regards, Natalia |
|
|
Please raise the patch. |
|
|
Combination - OCCT branch : CR30726_1 master SHA - 1fb65e1396c98353e9ee0c0a14d4354531b74937 d67d4b811012eef8913d3c535c29654d0acf3c4c Products branch : master SHA - c337118ac41004248abf27585e4c0e972f1a923e was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 16285.500000000035 / 16313.930000000051 [-0.17%] Products Total CPU difference: 10549.590000000051 / 10490.14000000005 [+0.57%] Windows-64-VC14: OCCT Total CPU difference: 17693.390625 / 17714.90625 [-0.12%] Products Total CPU difference: 12089.5625 / 12054.984375 [+0.29%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR30726_2 has been deleted by inv. SHA-1: c9f43340646a40b5deb4190550b940beb00a1559 |
|
|
Branch CR30726_1 has been deleted by inv. SHA-1: 1fb65e1396c98353e9ee0c0a14d4354531b74937 |
|
|
Branch CR30726 has been deleted by inv. SHA-1: 7d778441498ef0f0f545c800c671ee693bb5cf05 |
|
occt: master 8d2c79f4 2019-06-06 08:50:21 Committer: bugmaster Details Diff |
0030726: Visualization - change Selected state of owner in AIS_Selection AIS_InteractiveContext::IsHilighted() behavior has been changed. It should use the same logic for owner processing like when it is highlighted. IsSelected of owner is used for selection state, not highlight. Without this correction, object is never shown as selected by click (Select(bool)): if (!HighlightStyle (theOwner, aCustomStyle) || (!aCustomStyle.IsNull() && aCustomStyle != anObjSelStyle)) IsSelected is already true, so the highlight style is equal to selection style, nothing to do. |
Affected Issues 0030726 |
|
| mod - src/AIS/AIS_InteractiveContext.cxx | Diff File | ||
| mod - src/AIS/AIS_InteractiveContext_1.cxx | Diff File | ||
| mod - src/AIS/AIS_Selection.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-05-22 13:10 | nds | New Issue | |
| 2019-05-22 13:10 | nds | Assigned To | => kgv |
| 2019-05-22 13:10 | nds | Assigned To | kgv => nds |
| 2019-05-22 13:10 | nds | Priority | normal => low |
| 2019-05-22 13:13 | git | Note Added: 0084539 | |
| 2019-05-22 14:24 | git | Note Added: 0084545 | |
| 2019-06-04 22:12 | git | Note Added: 0084826 | |
| 2019-06-05 10:10 | nds | Note Added: 0084846 | |
| 2019-06-05 10:10 | nds | Assigned To | nds => kgv |
| 2019-06-05 10:10 | nds | Status | new => resolved |
| 2019-06-05 10:17 | kgv | Note Added: 0084847 | |
| 2019-06-05 10:17 | kgv | Summary | Visualization - change Selected state of owner in AIS_Selection => Visualization - change Selected state of owner within AIS_Selection instead of AIS_InteractiveContext |
| 2019-06-05 10:18 | kgv | Assigned To | kgv => nds |
| 2019-06-05 10:18 | kgv | Severity | minor => integration request |
| 2019-06-05 10:18 | kgv | Status | resolved => assigned |
| 2019-06-06 11:51 | git | Note Added: 0084906 | |
| 2019-06-06 11:58 | nds | Note Added: 0084908 | |
| 2019-06-06 11:58 | nds | Assigned To | nds => kgv |
| 2019-06-06 11:58 | nds | Status | assigned => resolved |
| 2019-06-06 12:01 | kgv | Note Added: 0084909 | |
| 2019-06-06 12:01 | kgv | Assigned To | kgv => bugmaster |
| 2019-06-06 12:01 | kgv | Status | resolved => reviewed |
| 2019-06-06 19:13 | bugmaster | Note Added: 0084939 | |
| 2019-06-06 19:13 | bugmaster | Status | reviewed => tested |
| 2019-06-06 19:13 | bugmaster | Test case number | => Not required |
| 2019-06-08 13:11 | bugmaster | Changeset attached | => occt master 8d2c79f4 |
| 2019-06-08 13:11 | bugmaster | Status | tested => verified |
| 2019-06-08 13:11 | bugmaster | Resolution | open => fixed |
| 2019-06-08 13:20 | git | Note Added: 0084953 | |
| 2019-06-08 13:20 | git | Note Added: 0084955 | |
| 2019-06-08 13:21 | git | Note Added: 0084964 |
