View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0030668Open CASCADEOCCT:Visualizationpublic2019-04-22 13:072019-09-20 15:08
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version7.4.0Fixed in Version7.4.0 
Summary0030668: Visualization - revise adding ZLayer API
DescriptionCurrent ZLayer API prevents insertion of new Layer between two existing ones.
In particular, this makes it impossible defining a new layer after OcctCellZLayer_Top (preserving depth) but before OcctCellZLayer_Topmost (clearing depth) without undesired altering properties of built-in layers (OcctCellZLayer_Topmost).
TagsNo tags attached.
Test case numberNot required

Relationships

child of 0030886 closedbugmaster Open CASCADE Documentation - provide information about some changes in upgrade 7.4.0 

Activities

git

2019-07-15 21:07

administrator   ~0085655

Branch CR30668 has been created by kgv.

SHA-1: 3f7d05bd506b77455588d71b5469ec44fb138b85


Detailed log of new commits:

Author: kgv
Date: Mon Jul 15 21:06:05 2019 +0300

    0030668: Visualization - revise adding ZLayer API
    
    V3d_Viewer::AddZLayer() has been extended with new arguments
    specifying layer settings and index of existing layer to append new one after.
    The default logic has been adjusted to append new layer with IsImmediate() flag
    after Graphic3d_ZLayerId_Top and before Graphic3d_ZLayerId_Topmost standard immediate layers.
    
    Graphic3d_Layer now provides LayerId() property.
    Graphic3d_ZLayerSettings has been extended with IsRaytracable() property;
    Ray-Tracing now processes multiple layers instead of Graphic3d_ZLayerId_Default.

git

2019-07-16 10:45

administrator   ~0085661

Branch CR30668_1 has been created by kgv.

SHA-1: fe42e5a7c6a0672cc4cdf0563673d2f97738b203


Detailed log of new commits:

Author: kgv
Date: Mon Jul 15 21:06:05 2019 +0300

    0030668: Visualization - revise adding ZLayer API
    
    V3d_Viewer::AddZLayer() has been extended with new arguments
    specifying layer settings and index of existing layer to insert new one before.
    The default logic has been adjusted to append new layer before Graphic3d_ZLayerId_Top
    (between Graphic3d_ZLayerId_Default and Graphic3d_ZLayerId_Top).
    
    Graphic3d_Layer now provides LayerId() property.
    Graphic3d_ZLayerSettings has been extended with IsRaytracable() property;
    Ray-Tracing now processes multiple layers instead of Graphic3d_ZLayerId_Default.

git

2019-07-16 17:54

administrator   ~0085675

Branch CR30668_2 has been created by kgv.

SHA-1: 19be21229a0777311f34504ee0f5491b1cf2d586


Detailed log of new commits:

Author: kgv
Date: Mon Jul 15 21:06:05 2019 +0300

    0030668: Visualization - revise adding ZLayer API
    
    V3d_Viewer::AddZLayer() has been replaced by
    V3d_Viewer::InsertLayerBefore() and V3d_Viewer::InsertLayerAfter() methods
    allowing to specify Layer settings and index of existing layer to insert new one before/after.
    The behavior of V3d_Viewer::AddZLayer() has been adjusted to append
    new Layer before Graphic3d_ZLayerId_Top
    (between Graphic3d_ZLayerId_Default and Graphic3d_ZLayerId_Top).
    
    Graphic3d_Layer now provides LayerId() property.
    Graphic3d_ZLayerSettings has been extended with IsRaytracable() property;
    Ray-Tracing now processes multiple layers instead of Graphic3d_ZLayerId_Default.
    
    Moved some methods from OpenGl_View to the base class Graphic3d_CView.

git

2019-07-16 18:13

administrator   ~0085676

Branch CR30668_2 has been updated forcibly by kgv.

SHA-1: 41b0f076d4e6a6da56a4ce031e41e042660d9f15

git

2019-07-16 20:06

administrator   ~0085681

Branch CR30668_2 has been updated forcibly by kgv.

SHA-1: 3630d4fc525c438948218884a95d27dd262a95d5

git

2019-07-16 20:51

administrator   ~0085682

Branch CR30668_2 has been updated forcibly by kgv.

SHA-1: 7b5cbbc51bfaf6e4f250a1ac96bfeb6d8eec5f45

kgv

2019-07-16 23:28

developer   ~0085684

Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30668_2-master-KGV/view/COMPARE/

osa

2019-07-18 10:52

developer   ~0085737

The patch CR30668_2 was reviewed without remarks

git

2019-07-18 11:10

administrator   ~0085742

Branch CR30668_2 has been updated forcibly by kgv.

SHA-1: 48283bc80d7c2092bbd540f31738d42ade6f6c15

bugmaster

2019-07-18 11:15

administrator   ~0085744

Combination -
OCCT branch : CR30668_2
master SHA - 7b5cbbc51bfaf6e4f250a1ac96bfeb6d8eec5f45
32ce09545dc9c46a47a51a964a24b1f472e6c2c4
Products branch : master SHA - ce8f14216a548db739b749891b6f800b0d5c6e8b
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 11570.050000000481 / 11586.520000000495 [-0.14%]
Products
---
Windows-64-VC14:
OCCT
Total CPU difference: 17619.015625 / 17623.078125 [-0.02%]
Products
Total CPU difference: 12039.53125 / 12058.53125 [-0.16%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2019-07-20 11:56

administrator   ~0085840

Branch CR30668 has been deleted by inv.

SHA-1: 3f7d05bd506b77455588d71b5469ec44fb138b85

git

2019-07-20 11:56

administrator   ~0085841

Branch CR30668_1 has been deleted by inv.

SHA-1: fe42e5a7c6a0672cc4cdf0563673d2f97738b203

git

2019-07-20 11:56

administrator   ~0085842

Branch CR30668_2 has been deleted by inv.

SHA-1: 48283bc80d7c2092bbd540f31738d42ade6f6c15

Related Changesets

occt: master 1c728f2d

2019-07-15 18:06:05

kgv


Committer: bugmaster Details Diff		 0030668: Visualization - revise adding ZLayer API

V3d_Viewer::AddZLayer() has been replaced by
V3d_Viewer::InsertLayerBefore() and V3d_Viewer::InsertLayerAfter() methods
allowing to specify Layer settings and index of existing layer to insert new one before/after.
The behavior of V3d_Viewer::AddZLayer() has been adjusted to append
new Layer before Graphic3d_ZLayerId_Top
(between Graphic3d_ZLayerId_Default and Graphic3d_ZLayerId_Top).

Graphic3d_Layer now provides LayerId() property.
Graphic3d_ZLayerSettings has been extended with IsRaytracable() property;
Ray-Tracing now processes multiple layers instead of Graphic3d_ZLayerId_Default.

Moved some methods from OpenGl_View to the base class Graphic3d_CView.		 Affected Issues
0030668
mod - src/Aspect/Aspect_GenId.cxx Diff File
mod - src/Aspect/Aspect_GenId.hxx Diff File
mod - src/D3DHost/D3DHost_GraphicDriver.cxx Diff File
mod - src/Graphic3d/Graphic3d_CView.cxx Diff File
mod - src/Graphic3d/Graphic3d_CView.hxx Diff File
mod - src/Graphic3d/Graphic3d_GraphicDriver.cxx Diff File
mod - src/Graphic3d/Graphic3d_GraphicDriver.hxx Diff File
mod - src/Graphic3d/Graphic3d_Layer.cxx Diff File
mod - src/Graphic3d/Graphic3d_Layer.hxx Diff File
mod - src/Graphic3d/Graphic3d_ZLayerSettings.hxx Diff File
mod - src/OpenGl/OpenGl_FrameStats.cxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver.cxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver.hxx Diff File
mod - src/OpenGl/OpenGl_LayerFilter.hxx Diff File
mod - src/OpenGl/OpenGl_LayerList.cxx Diff File
mod - src/OpenGl/OpenGl_LayerList.hxx Diff File
mod - src/OpenGl/OpenGl_View.cxx Diff File
mod - src/OpenGl/OpenGl_View.hxx Diff File
mod - src/OpenGl/OpenGl_View_Raytrace.cxx Diff File
mod - src/OpenGl/OpenGl_View_Redraw.cxx Diff File
mod - src/V3d/V3d_Viewer.cxx Diff File
mod - src/V3d/V3d_Viewer.hxx Diff File
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File
mod - tests/v3d/glsl/tiles Diff File

Issue History

Date Modified Username Field Change
2019-04-22 13:07 kgv New Issue
2019-04-22 13:07 kgv Assigned To => kgv
2019-07-15 21:07 git Note Added: 0085655
2019-07-16 10:45 git Note Added: 0085661
2019-07-16 17:54 git Note Added: 0085675
2019-07-16 18:13 git Note Added: 0085676
2019-07-16 20:06 git Note Added: 0085681
2019-07-16 20:51 git Note Added: 0085682
2019-07-16 23:28 kgv Note Added: 0085684
2019-07-16 23:28 kgv Assigned To kgv => osa
2019-07-16 23:28 kgv Status new => resolved
2019-07-18 10:52 osa Note Added: 0085737
2019-07-18 10:52 osa Assigned To osa => bugmaster
2019-07-18 10:52 osa Status resolved => reviewed
2019-07-18 11:10 git Note Added: 0085742
2019-07-18 11:14 bugmaster Test case number => Not required
2019-07-18 11:15 bugmaster Note Added: 0085744
2019-07-18 11:15 bugmaster Status reviewed => tested
2019-07-20 11:42 bugmaster Changeset attached => occt master 1c728f2d
2019-07-20 11:42 bugmaster Status tested => verified
2019-07-20 11:42 bugmaster Resolution open => fixed
2019-07-20 11:56 git Note Added: 0085840
2019-07-20 11:56 git Note Added: 0085841
2019-07-20 11:56 git Note Added: 0085842
2019-09-20 15:08 nds Relationship added child of 0030886