MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030537Open CASCADE[OCCT] OCCT:Visualizationpublic2019-03-04 20:072020-09-13 11:51
Reporternds 
Assigned Tonds 
PrioritynormalSeverityfeature 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.5.0Fixed in Version 
Summary0030537: Visualization - wrapping text in font text formatter
DescriptionProvide a possibility to wrap the text given into Font_TextFormatter.
TagsNo tags attached.
Test case numberNot required
Attached Filespng file icon wrapped_text.png (10,637 bytes) 2020-09-05 09:31

- Relationships
related to 0030857closedapn Visualization - using one implementation of Text in graphic group 
related to 0031762assignednds Visualization, Font_TextFormatter - tabulation length is respected with one extra symbol shift 

-  Notes
(0082596)
git (administrator)
2019-03-04 20:09

Branch CR30537 has been created by nds.

SHA-1: 858c86bc219d831d4baf2bb6506991761949c5bd


Detailed log of new commits:

Author: nds
Date: Mon Mar 4 20:04:26 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
(0082600)
git (administrator)
2019-03-05 06:43

Branch CR30537 has been updated by nds.

SHA-1: 217d9b95df29d8d34807608d8738719e48304529


Detailed log of new commits:

Author: nds
Date: Tue Mar 5 06:38:12 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    #compilation correction

(0082695)
git (administrator)
2019-03-05 14:04

Branch CR30537 has been updated by nds.

SHA-1: 85092818767d50c34928ff76619d24dc5377a40c


Detailed log of new commits:

Author: nds
Date: Tue Mar 5 13:52:37 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    #LineWidth public method, correction to compute line width in Format()

(0082700)
git (administrator)
2019-03-05 18:56

Branch CR30537 has been updated by nds.

SHA-1: 3ae32a0a4e0fea48e00947c1761f60a0e123e45e


Detailed log of new commits:

Author: nds
Date: Tue Mar 5 18:51:12 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    #corners should be arranged around (0,0) point, example of the first point if rect width is 100, symbol has an empty width:
    # - left alignment: (-50, 0)
    # - center alignment: (0, 0)
    # - right alignment: (50, 0)

(0082702)
git (administrator)
2019-03-05 19:14

Branch CR30537 has been updated by nds.

SHA-1: f3a4b8369495a2c2723cb19d91cdd9cff4401df3


Detailed log of new commits:

Author: nds
Date: Tue Mar 5 18:54:28 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    #corners should be arranged around (0,0) point, example of the first point if rect width is 100, symbol has an empty width:
    # - left alignment: (-50, 0)
    # - center alignment: (0, 0)
    # - right alignment: (50, 0)
    
    (cherry picked from commit 783914e968375a3165dffc83ae66c285a8c8dcbc)

(0082704)
git (administrator)
2019-03-05 20:04

Branch CR30537 has been updated by nds.

SHA-1: 1bbbcca13bc8d1edb782c51793c73c453dd2ef92


Detailed log of new commits:

Author: nds
Date: Tue Mar 5 19:57:36 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    # last row length correction
    
    (cherry picked from commit 7dab09204f899fc54dbd5379bcd76e7d23af831d)

(0085741)
git (administrator)
2019-07-18 11:09

Branch CR30537_1 has been created by nds.

SHA-1: 7ba0c7dc49b4de17aa99908ceea25cc9bdff8909


Detailed log of new commits:

Author: nds
Date: Thu Mar 7 16:28:20 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    (cherry picked from commit 8016b09836d484f061a75ac303953f9d80c05109)
    
    # Conflicts:
    # src/Graphic3d/Graphic3d_Group.hxx
    # src/OpenGl/OpenGl_Text.hxx
    (cherry picked from commit c0a38f3a5294cc0f168bc592f17f4ec9837d5a48)
    (cherry picked from commit ba793f42f8cc07e041f448e2685dca63ecde547f)
(0085751)
nds (developer)
2019-07-18 11:47

Jenkins job:
http://jenkins-test-12.nnov.opencascade.com/view/CR30537_1-CR30537_1-NDS/ [^]
(0085769)
kgv (developer)
2019-07-18 17:34

+  //! Iterator through light sources.
+  class Iterator
+  {
+  public:
+    //! Constructor with initialization.
+    Iterator (const Handle(Font_TextFormatter)& theFormatter,
+              IterationFilter theFilter = IterationFilter_None)

It looks redundant passing/requiring handle in iterator - usually iterators hold a reference (pointer) to the collection.

+    //! Returns current symbol.
+    const Standard_Utf32Char& Symbol() const { return mySymbolChar; }
+
+    //! Returns the next symbol if exists.
+    const Standard_Utf32Char& SymbolNext() const { return mySymbolCharNext; }
+
+    //! Returns current symbol position.
+    const Standard_Integer& SymbolPosition() const { return mySymbolPosition; }
+
+    //! Returns the next symbol position.
+    const Standard_Integer& SymbolPositionNext() const { return mySymbolNext; }

Please avoid returning/passing primitive types like Standard_Integer, Standard_Utf32Char via reference.

-  Font_TextFormatter aFormatter;
-  aFormatter.SetupAlignment (theAlignX, theAlignY);
-  aFormatter.Reset();
+  Handle(Font_TextFormatter) aFormatter = new Font_TextFormatter();

I would suggest avoiding creation of handle where it is not actually needed.

+  //!< Returns true if the symbol is CR, BEL, FF, NP, BS or VT
+  Standard_EXPORT static Standard_Boolean IsCommandSymbol (const Standard_Utf32Char& theSymbol);


This expected to be inline.

+void Graphic3d_Group::Text (const Handle(Font_TextFormatter)&       theTextFormatter,
+                            const gp_Ax2&                           theOrientation,
+                            const Standard_Real                     theHeight,

The expansion of Text() methods should last.
Consider defining a common structure for passing auxiliary parameters and Text representation modes,
and replacing all Text() methods with single one (existing methods to be preserved for a while as deprecated redirections to new method).

-    Font_TextFormatter aFormatter;
-    aFormatter.SetupAlignment (myParams.HAlign, myParams.VAlign);
-    aFormatter.Reset();
+    Handle(Font_TextFormatter) aFormatter = myFormatter;
+    if (myFormatter.IsNull())

It is preferred putting shared temporary instance of Font_TextFormatter inside OpenGl_Context.

+  //!< Returns internal container of the top left corners of a formatted rectangles.
+  const NCollection_Vector < NCollection_Vec2<Standard_ShortReal> >& GetCorners() const 
{ return myCorners; }
+
+  const NCollection_Vector<Standard_ShortReal>& GetNewLines() const { return myNewLines; }

...
+  //! Returns position of the first symbol in a line using alignment
+  Standard_EXPORT Standard_ShortReal GetFirstPosition() const;

"Get" is unexpected prefix.

+  if (aFirstCornerId >= getRectsNb())

Usage of trivial getter within the class implementation looks dubious.
(0085973)
git (administrator)
2019-08-02 07:16

Branch CR30537_2 has been created by nds.

SHA-1: 25a41791e3c93a47596bb768b3aaaa192abced10


Detailed log of new commits:

Author: nds
Date: Fri Aug 2 07:11:31 2019 +0300

    0030537: Visualization - wrapping text in font text formatter - correction after review
    
    (cherry picked from commit 9e7172d37227121ae550f7e4f10fc59725622ed3)

Author: nds
Date: Thu Mar 7 16:28:20 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    (cherry picked from commit 8016b09836d484f061a75ac303953f9d80c05109)
    
    # Conflicts:
    # src/Graphic3d/Graphic3d_Group.hxx
    # src/OpenGl/OpenGl_Text.hxx
    (cherry picked from commit c0a38f3a5294cc0f168bc592f17f4ec9837d5a48)
    (cherry picked from commit ba793f42f8cc07e041f448e2685dca63ecde547f)
    (cherry picked from commit 7ba0c7dc49b4de17aa99908ceea25cc9bdff8909)
(0085975)
git (administrator)
2019-08-02 07:38

Branch CR30537_3 has been created by nds.

SHA-1: 0d9c24acb9d1ef06c1f4212c00b90d50475a3fa1


Detailed log of new commits:

Author: nds
Date: Thu Mar 7 16:28:20 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
(0085989)
nds (developer)
2019-08-02 15:24

Dear Kirill,

please review the branch.

Some remarks are corrected as you recommended.
Remarks NOT corrected:
1. The expansion of Text() methods should last.
   -> I propose to implement it in another issue 0030857, if possible (to do not make this integration too thick).
2. It is preferred putting shared temporary instance of Font_TextFormatter inside OpenGl_Context.
  -> I'm not sure that correctly understand this recomendation. Do you mean having one instance as default one? If yes, the fix contains it.
On the other hand, I would expect that each text have own text formatter (as it caches calculated positions/sizes) and avoid recompute formatting on each render() call. It seems that it improves performance.

Best regards, Natalia
(0085990)
kgv (developer)
2019-08-02 15:30

> 1. The expansion of Text() methods should last.
> -> I propose to implement it in another issue 0030857, if possible (to do not make this integration too thick).
Then please process the referred issue first.

> 2. It is preferred putting shared temporary instance of Font_TextFormatter inside OpenGl_Context.
> -> I'm not sure that correctly understand this recomendation. Do you mean having one instance as default one? If yes, the fix contains it.
In context of implicitly created formatter, this formatter is created temporarily.
The idea is to create this temporary formatter once and reuse it to avoid extra memory flactuations/keep memory buffers allocated.
(0086002)
nds (developer)
2019-08-02 16:32

Dear Kirill,

thank you for explanation.
1. Ok
2. If several text presentations are shown in the viewer, each one has long text(for example) with own formatter. Don't you think that render() for each will require much time to recompute it? Anyway, it is possible do not use SetTextFormatter for text group, then the default formatter(from Context) will be used(acoording to current implementation) and your case works here.

Best regards, Natalia
(0086067)
git (administrator)
2019-08-07 15:25

Branch CR30537_4 has been created by nds.

SHA-1: fe7b06965a80e25b4d07a214d7a6e2d3eefcdd1c


Detailed log of new commits:

Author: nds
Date: Wed Aug 7 15:23:18 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
(0086427)
git (administrator)
2019-08-23 09:25

Branch CR30537_5 has been created by nds.

SHA-1: 91ba6d212b5b3398191212a4922c7a3f0ccdc730


Detailed log of new commits:

Author: nds
Date: Fri Aug 23 09:22:27 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
(0090503)
git (administrator)
2020-02-13 00:29

Branch CR30537_6 has been created by nds.

SHA-1: 5001dd8fd5cdaba17014b3b54f5053245541b3f3


Detailed log of new commits:

Author: nds
Date: Mon Sep 2 18:44:07 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
(0092493)
git (administrator)
2020-06-05 20:29

Branch CR30537_7 has been created by nds.

SHA-1: 5d2f1b3f2344b6af2cdc5be2f2c04fea672c992e


Detailed log of new commits:

Author: nds
Date: Mon Sep 2 18:44:07 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
(0092706)
git (administrator)
2020-06-25 04:38

Branch CR30537_8 has been created by nds.

SHA-1: d1b6b099474d2d1b59fec64c77d5945783321bd2


Detailed log of new commits:

Author: nds
Date: Mon Sep 2 18:44:07 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
(0092745)
git (administrator)
2020-06-26 08:44

Branch CR30537_8 has been updated by nds.

SHA-1: f9cb6d307975f32f5b0b4fca6d0bfddb4d593e16


Detailed log of new commits:

Author: nds
Date: Fri Jun 26 08:46:06 2020 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.

(0092746)
git (administrator)
2020-06-26 08:48

Branch CR30537_9 has been created by nds.

SHA-1: e77235938dc1767e8cddbae338104d2ba5c01ae1


Detailed log of new commits:

Author: nds
Date: Mon Sep 2 18:44:07 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
(0092770)
nds (developer)
2020-06-26 15:40

Dear Kirill,

please, review.
Your last comment is also corrected in the proposed patch.

Jenkins job: http://jenkins-test-12.nnov.opencascade.com/view/CR30537-master-NDS/ [^]

Thank you in advance, Natalia
(0093987)
git (administrator)
2020-09-03 14:46

Branch CR30537_9 has been updated by nds.

SHA-1: 457247c7a6e067028740789a38029627d4fa7cce


Detailed log of new commits:

Author: nds
Date: Thu Sep 3 14:38:02 2020 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    AIS_TextLabel extending with Font_TextFormatter to prepare test case for text wrapping
    Prs3d_Text returns created graphic text to be able to manage it outside.

Author: nds
Date: Thu Sep 3 08:42:55 2020 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    remarks correction.

(0093994)
git (administrator)
2020-09-03 17:01

Branch CR30537_10 has been created by nds.

SHA-1: b8c7e9cda9e5822cc195f70b007e739d0d60dc2d


Detailed log of new commits:

Author: nds
Date: Mon Sep 2 18:44:07 2019 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
    AIS_TextLabel extending with Font_TextFormatter to prepare test case for text wrapping
    Prs3d_Text returns created graphic text to be able to manage it outside.
(0094005)
git (administrator)
2020-09-03 22:06

Branch CR30537_10 has been updated forcibly by nds.

SHA-1: d4a56ece2434fc81490a06143ce0549eb44066b4
(0094006)
nds (developer)
2020-09-04 08:17

Dear Kirill,

could you please review modifications.
Jenkins job: http://jenkins-test-12.nnov.opencascade.com/view/CR30537-master-nds/ [^]

Thank you in advance, Natalia
(0094042)
git (administrator)
2020-09-05 09:30

Branch CR30537_10 has been updated forcibly by nds.

SHA-1: 925deff927c97956be71e2db0238ff447512cdb3
(0094160)
kgv (developer)
2020-09-06 10:53

-        Prs3d_Text::Draw (Prs3d_Root::CurrentGroup (thePrs), anAsp, myText, anOrientation, aHasOwnAnchor);

+        Handle(Graphic3d_Text) aText = 
+          Prs3d_Text::Draw (Prs3d_Root::CurrentGroup (thePrs), anAsp, myText, anOrientation, aHasOwnAnchor);


Patch has to be rebased onto current master (deprecated Prs3d_Root)...
(0094161)
kgv (developer)
2020-09-06 11:14
edited on: 2020-09-06 11:17

+  //! @return text formatter
+  const Handle(Font_TextFormatter)& TextFormatter() const { return myFormatter; }

Please put into description "; NULL by default, which means standard text formatter will be used".

+        if (!myFormatter.IsNull())
+          aText->SetTextFormatter (myFormatter);

I suppose NULL-check could be skipped.

+//! Example of correspondence of an index to the text symbol in "row_1\n\nrow_2\n":
+//! "row_1\n"  - 0-5
+//! "\n"       - 6
+//! "\n"       - 7
+//! "row_2\n"  - 8-13

I think that new-line formatting of this section will be screwed by Doxygen generator - consider adding extra tags.

+//! The iterator gives an access to each symbol inside the initial row. Also it's possible
+//! to get only significant/writable symbols of the text.

Tip: it is preferable splitting long lines on sentence ending / punctual symbols.

+  Standard_DEPRECATED("BottomLeft should be used instead.")

Tip: most (all?) other Standard_DEPRECATED occurrences have no trailing dot in message - would be nice being consistent.

+  inline const NCollection_Vec2<Standard_ShortReal>& BottomLeft (const Standard_Integer theIndex) 
const
...
+  inline Standard_ShortReal MaximumSymbolWidth() const { return myMaxSymbolWidth; }

Redundant "inline".

+  //!< Returns horizontal alignment style
+  Graphic3d_HorizontalTextAlignment HorizontalTextAlignment() const { return myAlignX; }
+
+  //!< Returns vertical   alignment style
+  Graphic3d_VerticalTextAlignment VerticalTextAlignment() const { return myAlignY; }
...

Here and in other places - please correct unexpected "//!<" tags with "//!".

+  const NCollection_Vector<Standard_ShortReal>& NewLines() const { return myNewLines; }

Missing description.

+
+  friend Iterator;

Is it really necessary?

+  //! @return default formatter of text within this context
+  void SetTextFormatter (const Handle(Font_TextFormatter)& theFormatter) { myFormatter = theFormatter; 
}

Unexpected "@return".

+
+  return aText;

Redundant empty line.

+pload ALL
+vinit View1

Please load only necessary plugins.

+checkview -screenshot -3d -path ${imagedir}/${test_image}.png

Please use "vdump $imagedir/${casename}.png" directly in new tests.

(0094168)
git (administrator)
2020-09-06 12:10

Branch CR30537_10 has been updated forcibly by nds.

SHA-1: 03eb78308e3369131bf80bbf9ef862bc6ab96eb3
(0094170)
git (administrator)
2020-09-06 12:54

Branch CR30537_10 has been updated by nds.

SHA-1: 60bf2297737c5e7ad2dc54052484fdfd35260204


Detailed log of new commits:

Author: nds
Date: Sun Sep 6 12:57:04 2020 +0300

    remarks correction

(0094186)
git (administrator)
2020-09-07 11:02

Branch CR30537_10 has been updated forcibly by nds.

SHA-1: c9a0f42c5b712c4d63eb5a362052db339bf07021
(0094187)
git (administrator)
2020-09-07 11:07

Branch CR30537_11 has been created by nds.

SHA-1: 60f7b2253650edf27be6404314c17e6e8a20c21a


Detailed log of new commits:

Author: nds
Date: Mon Sep 7 11:10:32 2020 +0300

    0030537: Visualization - wrapping text in font text formatter
    
    Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
    Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
    OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
    AIS_TextLabel extending with Font_TextFormatter to prepare test case for text wrapping.
    Prs3d_Text returns created graphic text to be able to manage it outside.
(0094199)
nds (developer)
2020-09-07 15:24

Corrected, could you please review it once again.
(0094316)
nds (developer)
2020-09-09 19:37

OCCT: CR30537_11,
PRODUCTS: NOT
(0094556)
bugmaster (administrator)
2020-09-13 11:07

Combination -
OCCT branch : IR-2020-09-11
master SHA - d1b25684e9402d995dafec22fb98f83957d5fb76
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-09-11 SHA - a7e55a291cf6642cb4af945a999deeeb5f91272a
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17333.360000000142 / 17325.800000000123 [+0.04%]
Products
Total CPU difference: 12056.720000000096 / 12079.64000000011 [-0.19%]
Windows-64-VC14:
OCCT
Total CPU difference: 18817.921875 / 18792.46875 [+0.14%]
Products
Total CPU difference: 13294.09375 / 13274.75 [+0.15%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0094596)
git (administrator)
2020-09-13 11:46

Branch CR30537_11 has been deleted by inv.

SHA-1: 60f7b2253650edf27be6404314c17e6e8a20c21a
(0094597)
git (administrator)
2020-09-13 11:46

Branch CR30537_10 has been deleted by inv.

SHA-1: c9a0f42c5b712c4d63eb5a362052db339bf07021
(0094601)
git (administrator)
2020-09-13 11:47

Branch CR30537_9 has been deleted by inv.

SHA-1: 457247c7a6e067028740789a38029627d4fa7cce
(0094608)
git (administrator)
2020-09-13 11:47

Branch CR30537_8 has been deleted by inv.

SHA-1: f9cb6d307975f32f5b0b4fca6d0bfddb4d593e16
(0094609)
git (administrator)
2020-09-13 11:47

Branch CR30537_7 has been deleted by inv.

SHA-1: 5d2f1b3f2344b6af2cdc5be2f2c04fea672c992e
(0094615)
git (administrator)
2020-09-13 11:47

Branch CR30537_6 has been deleted by inv.

SHA-1: 5001dd8fd5cdaba17014b3b54f5053245541b3f3
(0094625)
git (administrator)
2020-09-13 11:48

Branch CR30537_5 has been deleted by inv.

SHA-1: 91ba6d212b5b3398191212a4922c7a3f0ccdc730
(0094626)
git (administrator)
2020-09-13 11:48

Branch CR30537_4 has been deleted by inv.

SHA-1: fe7b06965a80e25b4d07a214d7a6e2d3eefcdd1c
(0094628)
git (administrator)
2020-09-13 11:48

Branch CR30537_3 has been deleted by inv.

SHA-1: 0d9c24acb9d1ef06c1f4212c00b90d50475a3fa1
(0094629)
git (administrator)
2020-09-13 11:48

Branch CR30537_2 has been deleted by inv.

SHA-1: 25a41791e3c93a47596bb768b3aaaa192abced10
(0094631)
git (administrator)
2020-09-13 11:48

Branch CR30537_1 has been deleted by inv.

SHA-1: 7ba0c7dc49b4de17aa99908ceea25cc9bdff8909
(0094636)
git (administrator)
2020-09-13 11:48

Branch CR30537 has been deleted by inv.

SHA-1: 1bbbcca13bc8d1edb782c51793c73c453dd2ef92

- Related Changesets
occt: master 60f7b225
Timestamp: 2020-09-07 08:10:32
Author: nds
Details ] Diff ]
0030537: Visualization - wrapping text in font text formatter

Font_TextFormatter inherits Standard_Transient, now it is given as a handle in functions.
Graphic3d_Text - extended with Font_TextFormatter to be able to have it filled out of text render. If it is not defined here, the default text formatter of context is used.
OpenGl_Context - has default Font_TextFormatter for rendering OpenGl_Text.
AIS_TextLabel extending with Font_TextFormatter to prepare test case for text wrapping.
Prs3d_Text returns created graphic text to be able to manage it outside.
mod - src/AIS/AIS_TextLabel.cxx Diff ] File ]
mod - src/AIS/AIS_TextLabel.hxx Diff ] File ]
mod - src/Font/Font_TextFormatter.cxx Diff ] File ]
mod - src/Font/Font_TextFormatter.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_Text.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_Text.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_TextBuilder.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_TextBuilder.hxx Diff ] File ]
mod - src/Prs3d/Prs3d_Text.cxx Diff ] File ]
mod - src/Prs3d/Prs3d_Text.hxx Diff ] File ]
mod - src/StdPrs/StdPrs_BRepTextBuilder.cxx Diff ] File ]
mod - src/StdPrs/StdPrs_BRepTextBuilder.hxx Diff ] File ]
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff ] File ]
add - tests/3rdparty/text3d/text_wrapped Diff ] File ]

- Issue History
Date Modified Username Field Change
2019-03-04 20:07 nds New Issue
2019-03-04 20:07 nds Assigned To => nds
2019-03-04 20:09 git Note Added: 0082596
2019-03-05 06:43 git Note Added: 0082600
2019-03-05 14:04 git Note Added: 0082695
2019-03-05 18:56 git Note Added: 0082700
2019-03-05 19:14 git Note Added: 0082702
2019-03-05 20:04 git Note Added: 0082704
2019-07-18 11:09 git Note Added: 0085741
2019-07-18 11:47 nds Note Added: 0085751
2019-07-18 17:34 kgv Note Added: 0085769
2019-08-02 07:16 git Note Added: 0085973
2019-08-02 07:38 git Note Added: 0085975
2019-08-02 08:40 nds Relationship added related to 0030857
2019-08-02 15:24 nds Note Added: 0085989
2019-08-02 15:24 nds Assigned To nds => kgv
2019-08-02 15:24 nds Status new => resolved
2019-08-02 15:30 kgv Note Added: 0085990
2019-08-02 15:30 kgv Assigned To kgv => nds
2019-08-02 15:30 kgv Status resolved => assigned
2019-08-02 16:32 nds Note Added: 0086002
2019-08-02 16:32 nds Assigned To nds => kgv
2019-08-07 15:25 git Note Added: 0086067
2019-08-23 09:25 git Note Added: 0086427
2019-09-04 16:17 kgv Assigned To kgv => nds
2019-09-04 16:17 kgv Severity minor => feature
2019-09-04 16:17 kgv Target Version 7.4.0 => 7.5.0
2020-02-13 00:29 git Note Added: 0090503
2020-06-05 20:29 git Note Added: 0092493
2020-06-25 04:38 git Note Added: 0092706
2020-06-26 07:23 nds File Added: inspector_V3d_Viewer.png
2020-06-26 07:28 nds File Deleted: inspector_V3d_Viewer.png
2020-06-26 08:44 git Note Added: 0092745
2020-06-26 08:48 git Note Added: 0092746
2020-06-26 15:40 nds Note Added: 0092770
2020-06-26 15:40 nds Assigned To nds => kgv
2020-06-26 15:40 nds Status assigned => resolved
2020-06-26 17:26 kgv Assigned To kgv => nds
2020-06-26 17:26 kgv Status resolved => assigned
2020-09-03 14:46 git Note Added: 0093987
2020-09-03 17:01 git Note Added: 0093994
2020-09-03 22:06 git Note Added: 0094005
2020-09-04 08:17 nds Note Added: 0094006
2020-09-04 08:17 nds Assigned To nds => kgv
2020-09-04 08:17 nds Status assigned => resolved
2020-09-05 09:30 git Note Added: 0094042
2020-09-05 09:31 nds File Added: wrapped_text.png
2020-09-06 10:53 kgv Note Added: 0094160
2020-09-06 11:14 kgv Note Added: 0094161
2020-09-06 11:15 kgv Assigned To kgv => nds
2020-09-06 11:15 kgv Status resolved => assigned
2020-09-06 11:17 kgv Note Edited: 0094161 View Revisions
2020-09-06 12:10 git Note Added: 0094168
2020-09-06 12:54 git Note Added: 0094170
2020-09-07 11:02 git Note Added: 0094186
2020-09-07 11:07 git Note Added: 0094187
2020-09-07 15:24 nds Note Added: 0094199
2020-09-07 15:24 nds Assigned To nds => kgv
2020-09-07 15:24 nds Status assigned => resolved
2020-09-07 15:36 kgv Assigned To kgv => bugmaster
2020-09-07 15:36 kgv Status resolved => reviewed
2020-09-09 19:37 nds Note Added: 0094316
2020-09-12 10:19 kgv Relationship added related to 0031762
2020-09-13 11:07 bugmaster Note Added: 0094556
2020-09-13 11:07 bugmaster Status reviewed => tested
2020-09-13 11:21 bugmaster Test case number => Not required
2020-09-13 11:24 nds Changeset attached => occt master 60f7b225
2020-09-13 11:24 nds Assigned To bugmaster => nds
2020-09-13 11:24 nds Status tested => verified
2020-09-13 11:24 nds Resolution open => fixed
2020-09-13 11:46 git Note Added: 0094596
2020-09-13 11:46 git Note Added: 0094597
2020-09-13 11:47 git Note Added: 0094601
2020-09-13 11:47 git Note Added: 0094608
2020-09-13 11:47 git Note Added: 0094609
2020-09-13 11:47 git Note Added: 0094615
2020-09-13 11:48 git Note Added: 0094625
2020-09-13 11:48 git Note Added: 0094626
2020-09-13 11:48 git Note Added: 0094628
2020-09-13 11:48 git Note Added: 0094629
2020-09-13 11:48 git Note Added: 0094631
2020-09-13 11:48 git Note Added: 0094636


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker