View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0030456 | Open CASCADE | OCCT:Configuration | public | 2019-01-23 13:25 | 2020-12-02 17:11 |
Reporter | oan | Assigned To | apn | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Target Version | 7.5.0 | Fixed in Version | 7.5.0 | ||
Summary | 0030456: Make OCCT_CHECK_AND_UNSET_GROUP more general | ||||
Description | occt_macros.cmake is quite useful for OCCT-based projects. However, it is impossible to unset group of variables with random ending due to OCCT_CHECK_AND_UNSET_GROUP accepts specific variables only (x_DIR, x_LIBRARY, etc.) It is suggested to make it more general in order to unset all variables with specified prefix. This can be done using the following code: get_cmake_property(VARS VARIABLES) string (REGEX MATCHALL "(^|;)${GROUP_NAME}[A-Za-z0-9_]*" LOCAL_RESULT "${VARS}") | ||||
Tags | No tags attached. | ||||
Test case number | Not needed | ||||
|
Branch CR30456 has been created by apn. SHA-1: 61066a148ee5e8cbd39f21c909dfb900d19c19f2 Detailed log of new commits: Author: apn Date: Fri Jul 19 16:25:59 2019 +0300 0030456: Make OCCT_CHECK_AND_UNSET_GROUP more general Modify OCCT_CHECK_AND_UNSET_GROUP function to allow unset any group of variables |
|
Dear oan, could you please review occt and products branches CR30456. Compilation was checked: http://jenkins-test-12.nnov.opencascade.com/view/CR30456-master-APN/ |
|
Dear Andrey, Thanks for the update, I will check it using the first moment I will be available. Regards, Oleg. |
|
Dear Andrey, It works without visible regressions with OCCT native environment, I have no remarks. Reviewed. |
|
Branch CR30456 has been deleted by kgv. SHA-1: 61066a148ee5e8cbd39f21c909dfb900d19c19f2 |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-01-23 13:25 | oan | New Issue | |
2019-01-23 13:25 | oan | Assigned To | => bugmaster |
2019-01-23 14:54 | bugmaster | Assigned To | bugmaster => apn |
2019-07-19 16:28 | git | Note Added: 0085796 | |
2019-07-19 17:26 | apn | Test case number | => Not needed |
2019-07-19 17:26 | apn | Note Added: 0085808 | |
2019-07-19 17:26 | apn | Assigned To | apn => oan |
2019-07-19 17:26 | apn | Status | new => resolved |
2019-09-18 13:51 | oan | Note Added: 0087251 | |
2019-09-25 22:08 |
|
Target Version | 7.4.0 => 7.5.0 |
2019-10-04 12:10 | oan | Note Added: 0087809 | |
2019-10-04 12:10 | oan | Assigned To | oan => apn |
2019-10-04 12:10 | oan | Status | resolved => reviewed |
2019-10-04 18:22 | apn | Assigned To | apn => bugmaster |
2019-10-04 19:55 | apn | Status | reviewed => tested |
2019-10-23 01:07 | apn | Changeset attached | => occt master 620a6baa |
2019-10-23 01:07 | apn | Assigned To | bugmaster => apn |
2019-10-23 01:07 | apn | Status | tested => verified |
2019-10-23 01:07 | apn | Resolution | open => fixed |
2019-10-23 11:51 | git | Note Added: 0088458 | |
2020-12-02 16:40 |
|
Fixed in Version | => 7.5.0 |
2020-12-02 17:11 |
|
Status | verified => closed |