View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0030425CommunityOCCT:Visualizationpublic2018-12-25 09:292019-08-11 10:50
Reporternds Assigned Tobugmaster  
PrioritynormalSeverityintegration request 
Status closedResolutionfixed 
Target Version7.4.0Fixed in Version7.4.0 
Summary0030425: Visualization - possibility to redefine AIS_Selection
DescriptionIt is proposed:
- to change AIS_Selection methods to have the virtual state,
- give Set/Get methods for the interface in AIS_InteractiveContext.

The purpose is to show/hide a custom manipulator by selection change in the context.
TagsNo tags attached.
Test case numberNot required

Activities

git

2019-08-02 15:12

administrator   ~0085985

Branch CR30425 has been created by nds.

SHA-1: 1939dd52ff3d045e36704a39b7dfc7ea272ba6ed


Detailed log of new commits:

Author: nds
Date: Tue Dec 25 09:26:49 2018 +0300

    0030425: Visualization - possibility to redefine AIS_Selection
    
    (cherry picked from commit 672fb1a467db74be47f4c41ab56d2a519b4cbb70)
    (cherry picked from commit 28ab6a20977f69318559db4f2bd3dd8f49ac3b28)
    (cherry picked from commit b412a87c5ce11b284c68d9a0a4213ddc08f78804)

nds

2019-08-02 15:14

developer   ~0085986

Dear Kirill,

could you please review modifications.

Thank you in advance, Natalia

kgv

2019-08-02 15:19

developer   ~0085987 

+  //! Sets selection instance to manipulate a container of selected owners
+  //! \param theSelection an instance of the selection
+  void SetSelection (const Handle(AIS_Selection)& theSelection) { mySelection = theSelection; }
+
+  //! Returns selection instance
+  const Handle(AIS_Selection)& Selection() const { return mySelection;

Please declare getter first and correct \param doxygen style for consistency with other class documentation.

No other remarks, please raise after fixing.

kgv

2019-08-02 15:19

developer   ~0085988

And clean up
> (cherry picked from commit
messages from commit.

nds

2019-08-06 15:08

developer   ~0086034

Dear Kirill,

please review.
Jenkins job and tests are not necessary.

Thank you in advance, Natalia

kgv

2019-08-06 15:13

developer   ~0086035

Forgotten to push new branch with remarks?

git

2019-08-06 15:23

administrator   ~0086036

Branch CR30425_1 has been created by nds.

SHA-1: 084d64752a395c720a37566629660062562c6099


Detailed log of new commits:

Author: nds
Date: Tue Dec 25 09:26:49 2018 +0300

    0030425: Visualization - possibility to redefine AIS_Selection

nds

2019-08-06 15:26

developer   ~0086037

Now corrected, please process it.

bugmaster

2019-08-08 14:46

administrator   ~0086088

Last edited: 2019-08-08 14:46

 Tested in faramework of WEEK-31
Combination -
OCCT branch : WEEK-31
master SHA - 8996b4490a69f1a96ca9b689dc239d1f8acf5fc5
5f5b1aed1c6e139bbd34314eca77ae7abcd8895c
Products branch : WEEK-31 SHA - 1144fe7d76516b4f51602e5bca86c8f2a51359c7
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16240.920000000013 / 16237.229999999976 [+0.02%]
Products
Total CPU difference: 10476.010000000046 / 10493.010000000033 [-0.16%]
Windows-64-VC14:
OCCT
Total CPU difference: 17724.421875 / 17592.765625 [+0.75%]
Products
Total CPU difference: 12048.796875 / 12065.453125 [-0.14%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2019-08-11 10:49

administrator   ~0086141

Branch CR30425_1 has been deleted by inv.

SHA-1: 084d64752a395c720a37566629660062562c6099

git

2019-08-11 10:50

administrator   ~0086147

Branch CR30425 has been deleted by inv.

SHA-1: 1939dd52ff3d045e36704a39b7dfc7ea272ba6ed

Related Changesets

occt: master 87bda9d8

2018-12-25 06:26:49

nds


Committer: bugmaster Details Diff		 0030425: Visualization - possibility to redefine AIS_Selection Affected Issues
0030425
mod - src/AIS/AIS_InteractiveContext.hxx Diff File
mod - src/AIS/AIS_Selection.hxx Diff File

Issue History

Date Modified Username Field Change
2018-12-25 09:29 nds New Issue
2018-12-25 09:29 nds Assigned To => nds
2019-08-02 15:12 git Note Added: 0085985
2019-08-02 15:14 nds Note Added: 0085986
2019-08-02 15:14 nds Assigned To nds => kgv
2019-08-02 15:14 nds Severity minor => integration request
2019-08-02 15:14 nds Status new => resolved
2019-08-02 15:19 kgv Note Added: 0085987
2019-08-02 15:19 kgv Assigned To kgv => nds
2019-08-02 15:19 kgv Status resolved => assigned
2019-08-02 15:19 kgv Note Added: 0085988
2019-08-06 15:08 nds Note Added: 0086034
2019-08-06 15:08 nds Assigned To nds => kgv
2019-08-06 15:09 nds Status assigned => resolved
2019-08-06 15:13 kgv Note Added: 0086035
2019-08-06 15:13 kgv Assigned To kgv => nds
2019-08-06 15:13 kgv Status resolved => assigned
2019-08-06 15:23 git Note Added: 0086036
2019-08-06 15:26 nds Note Added: 0086037
2019-08-06 15:26 nds Assigned To nds => kgv
2019-08-06 15:26 nds Status assigned => resolved
2019-08-06 15:40 kgv Assigned To kgv => bugmaster
2019-08-06 15:40 kgv Status resolved => reviewed
2019-08-06 17:27 bugmaster Test case number => Not required
2019-08-08 14:46 bugmaster Note Added: 0086088
2019-08-08 14:46 bugmaster Status reviewed => tested
2019-08-08 14:46 bugmaster Note Edited: 0086088
2019-08-11 10:40 bugmaster Changeset attached => occt master 87bda9d8
2019-08-11 10:40 bugmaster Status tested => verified
2019-08-11 10:40 bugmaster Resolution open => fixed
2019-08-11 10:49 git Note Added: 0086141
2019-08-11 10:50 git Note Added: 0086147