View Issue Details

IDProjectCategoryView StatusLast Update
0030292Open CASCADEOCCT:Modeling Algorithmspublic2023-03-02 13:31
Reporterkgv Assigned Toakaftasev  
PrioritynormalSeverityminor 
Status verifiedResolutionfixed 
Product Version7.3.0 
Target Version7.7.1 
Summary0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
DescriptionBRepBndLib::Add() has flag to either use triangulation when possible or to use geometric data.

It looks natural that useTriangulation flag affects using any tessellated data for computing bounding box, including Face triangulation as well as Edge polyline, but apparently the latter is not the case.

It is proposed to update implementation and description of the tool to ignore any tessellated data including polygon3d within Edge.
Steps To Reproducetest lowalgos bnd bug30292
TagsNo tags attached.
Test case numberlowalgos/bnd/bug30292

Activities

git

2018-10-25 10:19

administrator   ~0080295

Branch CR30292 has been created by kgv.

SHA-1: 5a75e65eb4493ebd520e98507981290da4bcfcc1


Detailed log of new commits:

Author: kgv
Date: Thu Oct 25 10:13:44 2018 +0300

    0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false

msv

2018-10-25 11:22

developer   ~0080296

It is needed to implement the same logic for edges without faces as for faces: polygon is used if there are no geometry or the flag useTriangulation is true. Geometry is used if the flag useTriangulation is false or there are no polygon.

It seems the proposed patch fixes this well for the method Add(). It is needed to do the same for the method AddOptimal().

Also, it is needed to update the description of the method Add() in the header file.

msv

2018-10-25 11:23

developer   ~0080297

The non-regression test cases are also needed.

git

2022-12-15 16:50

administrator   ~0112636

Branch CR30292_1 has been created by ifv.

SHA-1: 4cdb0557ff999cb7e8a6132bc5e35bf4e4817a59


Detailed log of new commits:

Author: ifv
Date: Thu Dec 15 16:48:49 2022 +0300

    0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
    
    BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
    BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.

git

2022-12-16 17:56

administrator   ~0112667

Branch CR30292_1 has been updated forcibly by ifv.

SHA-1: e4ef8dfcbc3064dc4036cc7a3cbf1878aa6aa779

ifv

2022-12-19 10:53

developer   ~0112685

Branch CR30292_1 is ready for review

Test results
http://jenkins-test-10.nnov.opencascade.com/view/CR30292_1-master-ifv/view/COMPARE/

git

2023-01-27 15:47

administrator   ~0113007

Branch CR30292_2 has been created by andrey.kaftasev_159541.

SHA-1: 1f33feb254efdff49f8b4b26b743b1233b005c3e


Detailed log of new commits:

Author: akaftasev
Date: Fri Jan 27 15:47:21 2023 +0300

    0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
    
    BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
    BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.

git

2023-02-03 16:57

administrator   ~0113065

Branch CR30292_2 has been updated forcibly by andrey.kaftasev_159541.

SHA-1: 860235155ba7327d3a5e6f14d3f44f7387e23da8

git

2023-02-06 14:17

administrator   ~0113082

Branch CR30292_2 has been updated forcibly by andrey.kaftasev_159541.

SHA-1: 2c5519d47914804e47d6aa951d490e1917dc8871

akaftasev

2023-02-06 19:48

developer   ~0113088

Please, integrate branch:
OCCT - CR30292_2

vglukhik

2023-02-12 18:00

administrator   ~0113115

Combination -
OCCT branch : SHA -
Products branch : SHA -
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18869.980000000163 / 18416.460000000254 [+2.46%]
Products
Total CPU difference: 12095.80000000011 / 12108.910000000147 [-0.11%]
Windows-64-VC142:
OCCT
Total CPU difference: 20579.4375 / 20947.5625 [-1.76%]
Products
Total CPU difference: 13954.984375 / 14923.015625 [-6.49%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2023-02-12 18:17

administrator   ~0113120

Branch CR30292 has been deleted by mnt.

SHA-1: 5a75e65eb4493ebd520e98507981290da4bcfcc1

git

2023-02-12 18:17

administrator   ~0113121

Branch CR30292_1 has been deleted by mnt.

SHA-1: e4ef8dfcbc3064dc4036cc7a3cbf1878aa6aa779

git

2023-02-12 18:17

administrator   ~0113122

Branch CR30292_2 has been deleted by mnt.

SHA-1: 2c5519d47914804e47d6aa951d490e1917dc8871

Related Changesets

occt: master 6d140acb

2023-02-06 14:17:10

akaftasev


Committer: vglukhik Details Diff
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false

BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.
Affected Issues
0030292
mod - src/BRepBndLib/BRepBndLib.cxx Diff File
mod - src/BRepTest/BRepTest_CurveCommands.cxx Diff File
add - tests/lowalgos/bnd/bug30292 Diff File

Issue History

Date Modified Username Field Change
2018-10-25 01:18 kgv New Issue
2018-10-25 01:18 kgv Assigned To => msv
2018-10-25 10:19 git Note Added: 0080295
2018-10-25 11:22 msv Note Added: 0080296
2018-10-25 11:22 msv Assigned To msv => ifv
2018-10-25 11:22 msv Status new => assigned
2018-10-25 11:23 msv Note Added: 0080297
2019-08-12 18:01 msv Target Version 7.4.0 => 7.5.0
2020-09-14 22:53 msv Target Version 7.5.0 => 7.6.0
2021-08-29 18:51 msv Target Version 7.6.0 => 7.7.0
2022-10-24 10:43 szy Target Version 7.7.0 => 7.8.0
2022-12-15 16:50 git Note Added: 0112636
2022-12-16 17:56 git Note Added: 0112667
2022-12-19 10:51 ifv Test case number => lowalgos/bnd/bug30292
2022-12-19 10:53 ifv Assigned To ifv => msv
2022-12-19 10:53 ifv Status assigned => resolved
2022-12-19 10:53 ifv Steps to Reproduce Updated
2022-12-19 10:53 ifv Note Added: 0112685
2022-12-19 11:50 msv Assigned To msv => emv
2022-12-29 15:24 ebelouso Assigned To emv => akaftasev
2023-01-27 15:47 git Note Added: 0113007
2023-02-03 16:57 git Note Added: 0113065
2023-02-06 14:17 git Note Added: 0113082
2023-02-06 19:48 akaftasev Assigned To akaftasev => bugmaster
2023-02-06 19:48 akaftasev Status resolved => reviewed
2023-02-06 19:48 akaftasev Note Added: 0113088
2023-02-12 17:50 vglukhik Changeset attached => occt master 6d140acb
2023-02-12 17:50 akaftasev Assigned To bugmaster => akaftasev
2023-02-12 17:50 akaftasev Status reviewed => verified
2023-02-12 17:50 akaftasev Resolution open => fixed
2023-02-12 18:00 vglukhik Note Added: 0113115
2023-02-12 18:17 git Note Added: 0113120
2023-02-12 18:17 git Note Added: 0113121
2023-02-12 18:17 git Note Added: 0113122
2023-03-02 13:31 ebelouso Target Version 7.8.0 => 7.7.1