View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0030277 | Open CASCADE | OCCT:Coding | public | 2018-10-21 22:06 | 2020-12-02 17:11 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 7.2.0 | ||||
| Target Version | 7.5.0 | Fixed in Version | 7.5.0 | ||
| Summary | 0030277: Coding Rules - avoid extremely long class names in STEP packages | ||||
| Description | STEP packages define files with really long names. Such names (apart from difficulty to refer to them) imply various issues on systems with limited length of process arguments (Windows) as well as packaging into some archives:
CMake Warning in src/TKSTEPAttr/CMakeLists.txt:
The object file directory
C:/workssd/Develop/Projects/CADAssistant/cadassistant-test/work/occt/occt.git/work/android-armeabi-v7a-gcc-make/src/TKSTEPAttr/CMakeFiles/TKSTEPAttr.dir/
has 153 characters. The maximum full path to an object file is 250
characters (see CMAKE_OBJECT_PATH_MAX). Object file
__/StepVisual/StepVisual_AnnotationCurveOccurrenceAndAnnotationOccurrenceAndGeomReprItemAndReprItemAndStyledItem.cxx.o
cannot be safely placed under this directory. The build may not work
correctly.
[ 75%] Built target TKSTEPBase [ 75%] Building CXX object src/TKSTEPAttr/CMakeFiles/TKSTEPAttr.dir/__/StepVisual/StepVisual_AnnotationCurveOccurrenceAndAnnotationOccurrenceAndGeomReprItemAndReprItemAndStyledItem.cxx.o src\TKSTEPAttr\CMakeFiles\TKSTEPAttr.dir\build.make:85: recipe for target 'src/TKSTEPAttr/CMakeFiles/TKSTEPAttr.dir/__/StepVisual/StepVisual_AnnotationCurveOccurrenceAndAnnotationOccurrenceAndGeomReprItemAndReprItemAndStyledItem.cxx.o' failed CMakeFiles\Makefile2:2119: recipe for target 'src/TKSTEPAttr/CMakeFiles/TKSTEPAttr.dir/all' failed Makefile:128: recipe for target 'all' failed The system cannot find the path specified. It is proposed renaming such classes to fit into some reasonable limit. | ||||
| Steps To Reproduce | Not required | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Galina, could you please suggest some better naming for StepVisual_AnnotationCurveOccurrenceAndAnnotationOccurrenceAndGeomReprItemAndReprItemAndStyledItem ? |
|
|
Hi Kirill. I propose for this entity: StepVisual_AnnotationCurveOccurrenceAndGeomReprItem |
|
|
Branch CR30277 has been created by mkrylova. SHA-1: 994a4f7cd26859819d47b7a6baf5da02c4456362 Detailed log of new commits: Author: mkrylova Date: Wed Jul 8 12:46:33 2020 +0300 0030277: Coding Rules - avoid extremely long class names in STEP packages Has changed the names of classes that are too long and fixed names in files where these classes are used |
|
|
Branch CR30277 has been updated by mkrylova. SHA-1: 57fd422b739ab049810530f2035a20af851348ec Detailed log of new commits: Author: mkrylova Date: Thu Jul 9 13:05:24 2020 +0300 #fixed FILES |
|
|
Branch CR30277_1 has been created by mkrylova. SHA-1: ced439890d71aa66918112f798027cfc267c133b Detailed log of new commits: Author: mkrylova Date: Wed Jul 8 12:46:33 2020 +0300 0030277: Coding Rules - avoid extremely long class names in STEP packages Has changed the names of classes that are too long and fixed names in files where these classes are used |
|
|
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30277-master-mkrylova/view/ALL/ |
|
|
The patch was reviewed |
|
|
Combination - OCCT branch : IR-2020-07-10 master SHA - 74440d215bf268902458b25e36a61c791f21fc38 a206de37fbfa0bf71bd534ae47192bbec23b8522 Products branch : IR-2020-07-10 SHA - 6e90d3ea8d7f26e39ec8b263c708ad6ecf5dfaaa was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 17210.790000000085 / 17175.910000000105 [+0.20%] Products Total CPU difference: 11229.020000000071 / 11228.490000000076 [+0.00%] Windows-64-VC14: OCCT Total CPU difference: 18725.6875 / 18705.46875 [+0.11%] Products Total CPU difference: 11144.125 / 13046.140625 [-14.58%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR30277_1 has been deleted by inv. SHA-1: ced439890d71aa66918112f798027cfc267c133b |
|
|
Branch CR30277 has been deleted by inv. SHA-1: 57fd422b739ab049810530f2035a20af851348ec |
|
occt: master 210914d5 2020-07-08 09:46:33
Committer: bugmaster Details Diff |
0030277: Coding Rules - avoid extremely long class names in STEP packages Has changed the names of classes that are too long and fixed names in files where these classes are used |
Affected Issues 0030277 |
|
| mod - src/RWStepAP214/RWStepAP214_GeneralModule.cxx | Diff File | ||
| mod - src/RWStepAP214/RWStepAP214_ReadWriteModule.cxx | Diff File | ||
| mod - src/RWStepVisual/FILES | Diff File | ||
| mod - src/StepAP214/StepAP214_Protocol.cxx | Diff File | ||
| mod - src/StepVisual/FILES | Diff File | ||
| add - src/StepVisual/StepVisual_CharacterizedObjAndRepresentationAndDraughtingModel.hxx | Diff File | ||
| rm - src/StepVisual/StepVisual_CharacterizedObjectAndCharacterizedRepresentationAndDraughtingModelAndRepresentation.hxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-10-21 22:06 | kgv | New Issue | |
| 2018-10-21 22:06 | kgv | Assigned To | => kgv |
| 2018-10-21 22:06 | kgv | Relationship added | related to 0028444 |
| 2018-10-21 23:46 | kgv | Note Added: 0080164 | |
| 2018-10-21 23:46 | kgv | Assigned To | kgv => gka |
| 2018-10-21 23:46 | kgv | Status | new => feedback |
| 2018-10-31 18:16 | kgv | Description Updated | |
| 2019-07-10 19:27 |
|
Target Version | 7.4.0 => 7.5.0 |
| 2020-06-03 11:26 |
|
Note Added: 0092454 | |
| 2020-06-03 11:27 |
|
Assigned To | gka => kgv |
| 2020-06-17 13:31 | kgv | Assigned To | kgv => mkrylova |
| 2020-06-17 13:31 | kgv | Status | feedback => assigned |
| 2020-07-08 12:44 | git | Note Added: 0093047 | |
| 2020-07-08 12:45 |
|
Assigned To | mkrylova => kgv |
| 2020-07-08 12:45 |
|
Assigned To | kgv => osa |
| 2020-07-08 12:49 |
|
Status | assigned => resolved |
| 2020-07-08 12:49 |
|
Steps to Reproduce Updated | |
| 2020-07-09 13:03 | git | Note Added: 0093058 | |
| 2020-07-09 17:30 | git | Note Added: 0093068 | |
| 2020-07-10 09:23 |
|
Note Added: 0093076 | |
| 2020-07-10 09:24 |
|
Note Added: 0093077 | |
| 2020-07-10 09:24 |
|
Assigned To | osa => bugmaster |
| 2020-07-10 09:24 |
|
Status | resolved => reviewed |
| 2020-07-11 12:13 | bugmaster | Note Added: 0093105 | |
| 2020-07-11 12:13 | bugmaster | Status | reviewed => tested |
| 2020-07-11 12:18 | bugmaster | Test case number | => Not required |
| 2020-07-11 12:22 | bugmaster | Changeset attached | => occt master 210914d5 |
| 2020-07-11 12:22 | bugmaster | Status | tested => verified |
| 2020-07-11 12:22 | bugmaster | Resolution | open => fixed |
| 2020-07-11 12:30 | git | Note Added: 0093114 | |
| 2020-07-11 12:30 | git | Note Added: 0093115 | |
| 2020-12-02 16:40 |
|
Fixed in Version | => 7.5.0 |
| 2020-12-02 17:11 |
|
Status | verified => closed |
