View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0030269 | Open CASCADE | OCCT:Modeling Algorithms | public | 2018-10-19 11:04 | 2018-10-28 16:13 |
| Reporter | kgv | Assigned To | apn | ||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.3.1 | ||||
| Target Version | 7.4.0 | Fixed in Version | 7.4.0 | ||
| Summary | 0030269: Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add() | ||||
| Description | Trying to compute AABB for an invalid shape with Edge having no curve leads to Standard_NullObject. This is unexpected and inconsistent to other places within BRepBndLib which just skip Edges without geometry. | ||||
| Tags | No tags attached. | ||||
| Test case number | bugs modalg_7 bug30269 | ||||
|
|
Branch CR30269 has been created by kgv. SHA-1: 96a685718d322d1ef588a80c02913cc5161d039d Detailed log of new commits: Author: kgv Date: Fri Oct 19 11:06:41 2018 +0300 0030269: Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add() Added BRep_Tool::IsGeometric() check before every BRepAdaptor_Curve::Initialize(). |
|
|
Trivial patch is ready for review. |
|
|
Line 283 is extra if edge is not geometric. The better fix is to put check for geometry in the line 272 "if(BRep_Tool::Degenerated(anE))". The same is for line 308. Please consider creating a test case. |
|
|
f.brep (2,191 bytes) |
|
|
Branch CR30269_1 has been created by kgv. SHA-1: 412c640c012e6dc4cffc992788445f6c46a6dace Detailed log of new commits: Author: kgv Date: Fri Oct 19 11:06:41 2018 +0300 0030269: Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add() Added BRep_Tool::IsGeometric() check before every BRepAdaptor_Curve::Initialize(). |
|
|
Updated patch is ready for review. The fix has been also propagated to OBB. |
|
|
No remarks to the code. I did not find test results. |
|
|
Branch CR30269_1 has been updated forcibly by kgv. SHA-1: cb5cb3b58ce736c1d709f782c79a6a018770406b |
|
|
Test case bugs/vis/bug641 has been updated as IMPROVEMENT (the original issue #0000641 for the same bug has been closed for unknown reason). http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30269_1-master-KGV/ |
|
|
Branch CR30269_1 has been updated forcibly by kgv. SHA-1: e653d5f7172ba5709d1f2979b57fac7c5096d8f1 |
|
|
Reviewed. |
|
|
Combination - OCCT branch : CR30269_1 SHA - e653d5f7172ba5709d1f2979b57fac7c5096d8f1 Products branch : master SHA - cd3543d117f1e585e93c7a94dee07b720ee3fd36 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences Test case: bugs modalg_7 bug30269 - OK CPU differences: Debian80-64: OCCT Total CPU difference: 17622.289999999895 / 17553.839999999873 [+0.39%] Products Total CPU difference: 7428.9400000000605 / 7416.290000000055 [+0.17%] Windows-64-VC14: OCCT Total CPU difference: 17668.174056798347 / 17582.732309098545 [+0.49%] Products Total CPU difference: 8346.474702699976 / 8362.40240479998 [-0.19%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR30269_1 has been deleted by inv. SHA-1: e653d5f7172ba5709d1f2979b57fac7c5096d8f1 |
|
|
Branch CR30269 has been deleted by inv. SHA-1: 96a685718d322d1ef588a80c02913cc5161d039d |
|
occt: master 87a64d53 2018-10-19 08:06:41 Committer: apn Details Diff |
0030269: Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add() Added BRep_Tool::IsGeometric() check before every BRepAdaptor_Curve::Initialize(). |
Affected Issues 0030269 |
|
| mod - src/BRepBndLib/BRepBndLib.cxx | Diff File | ||
| mod - src/BRepBndLib/BRepBndLib_1.cxx | Diff File | ||
| add - tests/bugs/modalg_7/bug30269 | Diff File | ||
| mod - tests/bugs/vis/bug641 | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-10-19 11:04 | kgv | New Issue | |
| 2018-10-19 11:04 | kgv | Assigned To | => msv |
| 2018-10-19 11:09 | git | Note Added: 0080117 | |
| 2018-10-19 11:10 | kgv | Note Added: 0080118 | |
| 2018-10-19 11:10 | kgv | Severity | minor => trivial |
| 2018-10-19 11:10 | kgv | Status | new => resolved |
| 2018-10-19 11:12 | kgv | Product Version | 7.3.0 => 6.3.1 |
| 2018-10-19 16:30 |
|
Note Added: 0080140 | |
| 2018-10-19 16:30 |
|
Assigned To | msv => kgv |
| 2018-10-19 16:30 |
|
Status | resolved => assigned |
| 2018-10-20 13:20 | kgv | File Added: f.brep | |
| 2018-10-20 13:22 | git | Note Added: 0080149 | |
| 2018-10-20 13:23 | kgv | Relationship added | related to 0029939 |
| 2018-10-20 13:23 | kgv | Note Added: 0080150 | |
| 2018-10-20 13:23 | kgv | Assigned To | kgv => msv |
| 2018-10-20 13:23 | kgv | Status | assigned => resolved |
| 2018-10-20 18:49 |
|
Note Added: 0080151 | |
| 2018-10-21 12:41 | git | Note Added: 0080152 | |
| 2018-10-21 12:43 | kgv | Note Added: 0080153 | |
| 2018-10-21 15:09 | git | Note Added: 0080157 | |
| 2018-10-22 10:46 |
|
Note Added: 0080169 | |
| 2018-10-22 10:46 |
|
Assigned To | msv => bugmaster |
| 2018-10-22 10:46 |
|
Status | resolved => reviewed |
| 2018-10-22 16:14 | apn | Test case number | => bugs modalg_7 bug30269 |
| 2018-10-22 16:14 | apn | Note Added: 0080198 | |
| 2018-10-22 16:14 | apn | Status | reviewed => tested |
| 2018-10-28 13:20 | apn | Changeset attached | => occt master 87a64d53 |
| 2018-10-28 13:20 | apn | Assigned To | bugmaster => apn |
| 2018-10-28 13:20 | apn | Status | tested => verified |
| 2018-10-28 13:20 | apn | Resolution | open => fixed |
| 2018-10-28 16:13 | git | Note Added: 0080419 | |
| 2018-10-28 16:13 | git | Note Added: 0080420 |
