MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030239Open CASCADE[OCCT] OCCT:Visualizationpublic2018-10-14 13:582018-12-13 12:13
Reporterkgv 
Assigned Toapn 
PrioritynormalSeverityintegration request 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.4.0*Fixed in Version 
Summary0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitmask instead of dedicated Boolean flags to constructor
DescriptionCurrently primitive array constructors take dedicated Boolean flags for requesting vertex attributes like Normals, Colors, Texels.

This makes syntax confusing, because there is too many flags in constructors and their order is not straightforward.

It is proposed replacing Boolean flags with a single bitmask argument.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed
Attached Files

- Relationships

-  Notes
(0079945)
git (administrator)
2018-10-14 14:49

Branch CR30239 has been created by kgv.

SHA-1: a50f98447d751092470e6411e8cd7bf5fdcdffef


Detailed log of new commits:

Author: kgv
Date: Sun Oct 14 14:00:46 2018 +0300

    0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitmask instead of dedicated Boolean flags to constructor
(0079979)
git (administrator)
2018-10-15 23:49

Branch CR30239 has been updated forcibly by kgv.

SHA-1: 187a5cf637ff4703b941f8a4949d221dcb0ba08b
(0079981)
git (administrator)
2018-10-15 23:51

Branch CR30239 has been updated forcibly by kgv.

SHA-1: 06113ca08cd6cde0c94a5bd05717f207a81fd338
(0079983)
kgv (developer)
2018-10-15 23:54

Please take the patch.
(0080032)
apn (administrator)
2018-10-16 22:29

Combination -
OCCT branch : CR30239 SHA - a50f98447d751092470e6411e8cd7bf5fdcdffef
Products branch : CR30239 SHA - 38277e384d6ac06b5184c98ab1ed007a2c2eb56d
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17507.10999999992 / 17553.839999999873 [-0.27%]
Products
Total CPU difference: 7446.830000000072 / 7416.290000000055 [+0.41%]
Windows-64-VC14:
OCCT
Total CPU difference: 17568.193015898425 / 17582.732309098545 [-0.08%]
Products
Total CPU difference: 8354.961157099993 / 8362.40240479998 [-0.09%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0080177)
git (administrator)
2018-10-22 11:52

Branch CR30239 has been deleted by inv.

SHA-1: 06113ca08cd6cde0c94a5bd05717f207a81fd338

- Related Changesets
occt: master 34253146
Timestamp: 2018-10-14 11:00:46
Author: kgv
Committer: apn
Details ] Diff ]
0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitmask instead of dedicated Boolean flags to constructor
mod - src/Graphic3d/FILES Diff ] File ]
add - src/Graphic3d/Graphic3d_ArrayFlags.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfPoints.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfPolygons.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfPolylines.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfPrimitives.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfPrimitives.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfQuadrangles.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfQuadrangleStrips.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfSegments.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfTriangleFans.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfTriangles.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_ArrayOfTriangleStrips.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_BoundBuffer.hxx Diff ] File ]
add - src/Graphic3d/Graphic3d_Buffer.cxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_Buffer.hxx Diff ] File ]
mod - src/Graphic3d/Graphic3d_IndexBuffer.hxx Diff ] File ]
mod - src/OpenGl/OpenGl_PrimitiveArray.cxx Diff ] File ]
mod - src/OpenGl/OpenGl_PrimitiveArray.hxx Diff ] File ]
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2018-10-14 13:58 kgv New Issue
2018-10-14 13:58 kgv Assigned To => kgv
2018-10-14 14:49 git Note Added: 0079945
2018-10-15 14:21 kgv Relationship added related to 0030076
2018-10-15 23:49 git Note Added: 0079979
2018-10-15 23:51 git Note Added: 0079981
2018-10-15 23:54 kgv Note Added: 0079983
2018-10-15 23:54 kgv Assigned To kgv => bugmaster
2018-10-15 23:54 kgv Status new => resolved
2018-10-15 23:54 kgv Status resolved => reviewed
2018-10-16 22:29 apn Test case number => Not needed
2018-10-16 22:29 apn Note Added: 0080032
2018-10-16 22:29 apn Status reviewed => tested
2018-10-21 20:16 apn Changeset attached => occt master 34253146
2018-10-21 20:16 apn Assigned To bugmaster => apn
2018-10-21 20:16 apn Status tested => verified
2018-10-21 20:16 apn Resolution open => fixed
2018-10-22 11:52 git Note Added: 0080177
2018-12-06 12:40 aba Relationship added related to 0030358
2018-12-13 12:13 kgv Relationship replaced parent of 0030358


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker